Pull request 1354 in include-what-you-use: Remove 'IsTemplateTypeParmUseFullUse' function

[notifi...@include-what-you-use.org]

New pull request 1354 by bolshakov-a: Remove 'IsTemplateTypeParmUseFullUse' function
https://github.com/include-what-you-use/include-what-you-use/pull/1354

More general `CanForwardDeclareType` works already well even for `SubstTemplateTypeParmType`s.

The case of using a reference in a `sizeof` expression is already handled in `IwyuBaseAstVisitor::VisitUnaryExprOrTypeTraitExpr`.

Probably, the commits should be squashed (they are separated for clarity). Or even, the test case should be extracted as the first commit, and all the code changes as the second one.

[notifi...@include-what-you-use.org]

Comment #1 on pull request 1354 by kimgr: Remove 'IsTemplateTypeParmUseFullUse' function
https://github.com/include-what-you-use/include-what-you-use/pull/1354

Looks good to me! I don't have a strong preference for commit partitioning here, feel free to do what you prefer and let me know when it's ready to merge.

[notifi...@include-what-you-use.org]

Comment #2 on pull request 1354 by bolshakov-a: Remove 'IsTemplateTypeParmUseFullUse' function
https://github.com/include-what-you-use/include-what-you-use/pull/1354

I've decided to extract the test case into a separate commit.

[notifi...@include-what-you-use.org]

Comment #3 on pull request 1354 by kimgr: Remove 'IsTemplateTypeParmUseFullUse' function
https://github.com/include-what-you-use/include-what-you-use/pull/1354

Nice, I think that makes sense.