English custom field value is used instead of primary

1 view
Skip to first unread message

Sergejs Gribs

unread,
Oct 28, 2009, 4:43:46 PM10/28/09
to in-port...@googlegroups.com
When ModRewriteHelper tries to find default item template using correspoding custom field value in category, it uses English (language with id 1) instead if using primary language translation. It's very uncomfortable if you have other language set as primary, as you can't understand why custom field value is filled in category edit form, but it doesn't affect anything.

Attached patch fixes the issue.
use_primary_lang_not_id_1.patch

Alexander Obuhovich

unread,
Oct 29, 2009, 3:00:51 PM10/29/09
to in-port...@googlegroups.com
I've also have noticed this error about 2 year ago, but forgot to report it, because most of projects I work with have primary language with id #1.

Thanks for finding it. I think, that we should search for "l1_" through all code to make sure, that such problem doesn't happen in other system places.


On Wed, Oct 28, 2009 at 10:43 PM, Sergejs Gribs <serg...@gmail.com> wrote:
When ModRewriteHelper tries to find default item template using correspoding custom field value in category, it uses English (language with id 1) instead if using primary language translation. It's very uncomfortable if you have other language set as primary, as you can't understand why custom field value is filled in category edit form, but it doesn't affect anything.

Attached patch fixes the issue.





--
Best Regards,

http://www.alex-time.com

Dmitry A.

unread,
Nov 18, 2009, 1:51:45 PM11/18/09
to In-Portal Bugs
Any one knows if we have a Task for this yet?

Can't find anything related in Issue Tracker, but may be it's just
me...

DA.

On Oct 29, 1:00 pm, Alexander Obuhovich <aik.b...@gmail.com> wrote:
> I've also have noticed this error about 2 year ago, but forgot to report it,
> because most of projects I work with have primary language with id #1.
>
> Thanks for finding it. I think, that we should search for "l1_" through all
> code to make sure, that such problem doesn't happen in other system places.
>

Alexander Obuhovich

unread,
Nov 18, 2009, 1:55:42 PM11/18/09
to in-port...@googlegroups.com
I've checked, we don't have one in Tracker, but I suppose we have one in wiki.

--

You received this message because you are subscribed to the Google Groups "In-Portal Bugs" group.
To post to this group, send email to in-port...@googlegroups.com.
To unsubscribe from this group, send email to in-portal-bug...@googlegroups.com.
For more options, visit this group at http://groups.google.com/group/in-portal-bugs?hl=en.





--
Best Regards,

http://www.in-portal.org
http://www.alex-time.com

Phil

unread,
Nov 19, 2009, 4:25:52 AM11/19/09
to In-Portal Bugs
Hi,

I also propose that when another language is setup as primary for
admin, automatically switch admin lang for the new primary lang
(actually, it stays on English).

Phil.
> > in-portal-bug...@googlegroups.com<in-portal-bugs%2Bunsu...@googlegroups.com>
> > .

Alexander Obuhovich

unread,
Nov 23, 2009, 9:45:54 AM11/23/09
to in-port...@googlegroups.com
I've came across this bug in other project not so long ago. Dima/Sergey please check if there is task for this issue and if not create one and link with this discussion.

On Wed, Oct 28, 2009 at 10:43 PM, Sergejs Gribs <serg...@gmail.com> wrote:
When ModRewriteHelper tries to find default item template using correspoding custom field value in category, it uses English (language with id 1) instead if using primary language translation. It's very uncomfortable if you have other language set as primary, as you can't understand why custom field value is filled in category edit form, but it doesn't affect anything.

Attached patch fixes the issue.

--~--~---------~--~----~------------~-------~--~----~

You received this message because you are subscribed to the Google Groups "In-Portal Bugs" group.
To post to this group, send email to in-port...@googlegroups.com
To unsubscribe from this group, send email to in-portal-bug...@googlegroups.com
For more options, visit this group at http://groups.google.com/group/in-portal-bugs?hl=en
-~----------~----~----~----~------~----~------~--~---

Dmitry A.

unread,
Dec 7, 2009, 12:00:44 AM12/7/09
to In-Portal Bugs
New task filed (patch attached)

439: English Custom Field value is used instead of Primary

http://tracker.in-portal.org/view.php?id=439


DA.

On Nov 23, 8:45 am, Alexander Obuhovich <aik.b...@gmail.com> wrote:
> I've came across this bug in other project not so long ago. Dima/Sergey
> please check if there is task for this issue and if not create one and link
> with this discussion.
>
>
>
>
>
> On Wed, Oct 28, 2009 at 10:43 PM, Sergejs Gribs <sergb...@gmail.com> wrote:
> > When ModRewriteHelper tries to find default item template using
> > correspoding custom field value in category, it uses English (language with
> > id 1) instead if using primary language translation. It's very uncomfortable
> > if you have other language set as primary, as you can't understand why
> > custom field value is filled in category edit form, but it doesn't affect
> > anything.
>
> > Attached patch fixes the issue.
>
> > --~--~---------~--~----~------------~-------~--~----~
> > You received this message because you are subscribed to the Google Groups
> > "In-Portal Bugs" group.
> > To post to this group, send email to in-port...@googlegroups.com
> > To unsubscribe from this group, send email to
> > in-portal-bug...@googlegroups.com<in-portal-bugs%2Bunsubscribe@go oglegroups.com>
Reply all
Reply to author
Forward
0 new messages