Incorrect setting page saving detection

1 view
Skip to first unread message

Alexander Obuhovich

unread,
Aug 20, 2012, 1:18:01 PM8/20/12
to Bugs In-Portal
In http://tracker.in-portal.org/view.php?id=0001118 (5.2.0-B1) task we've added nice message, that is shown on configuration page when all settings were successfully saved.

However after using it a bit on my projects I've discovered, that message is shown if at least one of system settings, displayed on a page, was saved successfully.
Also on "Configuration -> Website -> Advanced" page, which is quite long, it's hard to see error in a setting value is is at the bottom of a page.

I'm proposing to:
  1. display "Saved" message only when ALL system settings were saved without validation errors
  2. scroll window/frame to first error on a page


Ready for testing.


--
Best Regards,

http://www.in-portal.com
http://www.alex-time.com
system_setting_validation_fixes.patch
Reply all
Reply to author
Forward
0 new messages