Try not to use $_REQUEST in Debugger

7 views
Skip to first unread message

Alexander Obuhovich

unread,
Sep 10, 2012, 4:01:11 AM9/10/12
to Bugs In-Portal
There is $_REQUEST super-global variable in PHP, that used to contain Get/Post/Cookie variables all together. However since PHP 5.3.0 actual contents of this variable can be altered using "request_order" ini setting.
Unfortunately by default it no longer contains Cookie values. This is not big issue for In-Portal because it uses it's own $_REQUEST-alike variable maintenance system.

However it's a problem for Debugger, which thinks that there are always all variables inside a $_REQUEST and some of them are Get, some Post and some Cookies.
I'm proposing merge $_GET, $_POST, $_COOKIE arrays manually in the debugger and not rely on $_REQUEST variable's content.

--
Best Regards,

http://www.in-portal.com
http://www.alex-time.com

Dmitry A.

unread,
Oct 18, 2012, 11:34:11 PM10/18/12
to in-port...@googlegroups.com
Hi Alex,


I don't see why not, but for my information I'd like to know: 

1. what are the probability of $_REQUEST being changed (different)

2. what are is the performance impact of doing manually.


DA

Alexander Obuhovich

unread,
Oct 20, 2012, 7:30:28 AM10/20/12
to in-port...@googlegroups.com
$_REQUEST variable is combination of $_GET, $_POST, $_COOKIE variables according to request_order setting from php.ini file. In-Portal doesn't use it at all, but Debugger does.

That's why change in default value of request_order setting in php.ini resulted in cookies not being displayed in debugger at all.


--
You received this message because you are subscribed to the Google Groups "In-Portal Bugs Team" group.
To view this discussion on the web visit https://groups.google.com/d/msg/in-portal-bugs/-/0jD5avJily8J.
To post to this group, send email to in-port...@googlegroups.com.
To unsubscribe from this group, send email to in-portal-bug...@googlegroups.com.
For more options, visit this group at http://groups.google.com/group/in-portal-bugs?hl=en.

Dmitry A.

unread,
Oct 24, 2012, 2:00:30 AM10/24/12
to in-port...@googlegroups.com
Thanks for clarifying.

Let's create a task and clean this up in 5.2.1 version if you agree.


DA

Alexander Obuhovich

unread,
Oct 26, 2012, 12:08:58 PM10/26/12
to in-port...@googlegroups.com
Here is the task: http://tracker.in-portal.org/view.php?id=1421

Ready for testing.


To view this discussion on the web visit https://groups.google.com/d/msg/in-portal-bugs/-/EMAzPLu3sNsJ.

To post to this group, send email to in-port...@googlegroups.com.
To unsubscribe from this group, send email to in-portal-bug...@googlegroups.com.
For more options, visit this group at http://groups.google.com/group/in-portal-bugs?hl=en.
dont_use_request_core.patch
dont_use_request_modules.patch
Reply all
Reply to author
Forward
0 new messages