[In-Commerce] Payment type sorting is ignored

1 view
Skip to first unread message

Alexander Obuhovich

unread,
Feb 8, 2010, 4:15:11 AM2/8/10
to In-Portal Bugs
Payment type sorting defined via "Priority" field on payment type editing screen is ignored, when dropdown from payment types is displayed on "Billing" step during checkout. I propose we sort by Priority DESC, Name ASC.

--
Best Regards,

http://www.in-portal.com
http://www.alex-time.com

Dmitry A.

unread,
Feb 8, 2010, 1:16:30 PM2/8/10
to In-Portal Bugs Team
Hi,

Looks like the issue is in using the following tag in in-commerce/
elements/content_boxes/checkout/billing_options.elm.tpl

<inp2:ord_PredefinedOptions render_as="inp_option_item"
field="PaymentType" selected="selected"/>

I believe it doesn't apply sorting to the list since Options requested
directly.

Do have to start using the PrintList instead?


DA.

Alexander Obuhovich

unread,
Feb 8, 2010, 1:37:11 PM2/8/10
to in-port...@googlegroups.com
Nope, options_sql option should fixed to include that sorting, because now it doesn't.


--
You received this message because you are subscribed to the Google Groups "In-Portal Bugs Team" group.
To post to this group, send email to in-port...@googlegroups.com.
To unsubscribe from this group, send email to in-portal-bug...@googlegroups.com.
For more options, visit this group at http://groups.google.com/group/in-portal-bugs?hl=en.

Dmitry V. Andrejev

unread,
Feb 8, 2010, 1:45:47 PM2/8/10
to in-port...@googlegroups.com
Can you give more ideas if it's global fix or something we do in Event Handler for PaymentTypes?

DA.
-- 
With best regards,

Dmitry V. Andrejev

Alexander Obuhovich

unread,
Feb 8, 2010, 2:42:39 PM2/8/10
to in-port...@googlegroups.com
No event handler. As I've said it's all in "options_sql" for PaymentType field in orders_config.php :)

Dmitry Andrejev

unread,
Feb 8, 2010, 8:40:37 PM2/8/10
to in-port...@googlegroups.com
Okay - you are right.

Here is a patch, but I have also clean up a code in this orders_config.php file since it was really terrible.

DA
Payment_type_sorting_is_ignore-Dmitry-20100208-v1.patch

Dmitry A.

unread,
Feb 11, 2010, 10:57:41 AM2/11/10
to In-Portal Bugs Team
Any comments here?

On Feb 8, 7:40 pm, Dmitry Andrejev <dandre...@gmail.com> wrote:
> Okay - you are right.
>
> Here is a patch, but I have also clean up a code in this orders_config.php
> file since it was really terrible.
>
> DA
>

> On Mon, Feb 8, 2010 at 1:42 PM, Alexander Obuhovich <aik.b...@gmail.com>wrote:
>
>
>
> > No event handler. As I've said it's all in "options_sql" for PaymentType
> > field in orders_config.php :)
>

> > On Mon, Feb 8, 2010 at 8:45 PM, Dmitry V. Andrejev <dandre...@gmail.com>wrote:
>
> >>  Can you give more ideas if it's global fix or something we do in Event
> >> Handler for PaymentTypes?
>
> >> DA.
>
> >> On 2/8/2010 12:37 PM, Alexander Obuhovich wrote:
>
> >> Nope, options_sql option should fixed to include that sorting, because now
> >> it doesn't.
>

> >>> in-portal-bug...@googlegroups.com<in-portal-bugs%2Bunsubscribe@go oglegroups.com>


> >>> .
> >>> For more options, visit this group at
> >>>http://groups.google.com/group/in-portal-bugs?hl=en.
>
> >> --
> >> Best Regards,
>
> >>http://www.in-portal.com
> >>http://www.alex-time.com
> >> --
> >> You received this message because you are subscribed to the Google Groups
> >> "In-Portal Bugs Team" group.
> >> To post to this group, send email to in-port...@googlegroups.com.
> >> To unsubscribe from this group, send email to
> >> in-portal-bug...@googlegroups.com.
> >> For more options, visit this group at
> >>http://groups.google.com/group/in-portal-bugs?hl=en.
>
> >> --
> >> With best regards,
>
> >> Dmitry V. Andrejev
>
> >>  --
> >> You received this message because you are subscribed to the Google Groups
> >> "In-Portal Bugs Team" group.
> >> To post to this group, send email to in-port...@googlegroups.com.
> >> To unsubscribe from this group, send email to

> >> in-portal-bug...@googlegroups.com<in-portal-bugs%2Bunsubscribe@go oglegroups.com>


> >> .
> >> For more options, visit this group at
> >>http://groups.google.com/group/in-portal-bugs?hl=en.
>
> > --
> > Best Regards,
>
> >http://www.in-portal.com
> >http://www.alex-time.com
>
> > --
> > You received this message because you are subscribed to the Google Groups
> > "In-Portal Bugs Team" group.
> > To post to this group, send email to in-port...@googlegroups.com.
> > To unsubscribe from this group, send email to

> > in-portal-bug...@googlegroups.com<in-portal-bugs%2Bunsubscribe@go oglegroups.com>


> > .
> > For more options, visit this group at
> >http://groups.google.com/group/in-portal-bugs?hl=en.
>
>
>

>  Payment_type_sorting_is_ignore-Dmitry-20100208-v1.patch
> 71KViewDownload

Alexander Obuhovich

unread,
Mar 14, 2010, 3:43:05 PM3/14/10
to in-port...@googlegroups.com
A month has passed and no new opinions. Seems every one is happy.
Here is the task: http://tracker.in-portal.org/view.php?id=613

Phil ..:: domicilis.biz ::..

unread,
Mar 14, 2010, 5:55:09 PM3/14/10
to in-port...@googlegroups.com
well, it's a good task, as it seems to me that it wasn't working well
even in v4,x.

ps: I have "Access Denied." when I try to see this task :S

2010/3/14 Alexander Obuhovich <aik....@gmail.com>:

Dmitry A.

unread,
Mar 14, 2010, 6:33:10 PM3/14/10
to In-Portal Bugs Team
Hi Phil,


The task is closed from public since In-Commerce is a commercial
module. However, there is nothing in the task that you don't see here.

Thanks for your comments!

DA.

On Mar 14, 4:55 pm, "Phil ..:: domicilis.biz ::.."


<p...@domicilis.biz> wrote:
> well, it's a good task, as it seems to me that it wasn't working well
> even in v4,x.
>
> ps: I have "Access Denied." when I try to see this task :S
>

> 2010/3/14 Alexander Obuhovich <aik.b...@gmail.com>:


>
>
>
> > A month has passed and no new opinions. Seems every one is happy.
> > Here is the task:http://tracker.in-portal.org/view.php?id=613
>

Phil ..:: domicilis.biz ::..

unread,
Mar 15, 2010, 12:27:50 PM3/15/10
to in-port...@googlegroups.com
ok, I just wanted to follow the thread, as I read all posts and tasks created.

2010/3/14 Dmitry A. <dand...@gmail.com>
Reply all
Reply to author
Forward
0 new messages