All sub-menu items appear as current, when you are printing expanded site menu version
3 views
Skip to first unread message
Alexander Obuhovich
Apr 8, 2010, 7:04:06 AM4/8/10
to In-Portal Bugs
All sub-menu items appear as current, when you are printing expanded site menu version.
For example when you want print menu mentioned above and highlight current page in it, then you should compare this using given tag:
<inp2:m_if check="m_Get" name="m_cat_id" equals_to="$cat_id">highlighted</inp2:m_if> .
Mentioned above tag will always display "highlighted" because of "m_cat_id" request variable, which is compare here is always overwritten from <inp2:st_CachedMenu .../> tag. It was done long ago to automatically pass category into menu item links and for this tag to work: <inp2:m_Link template="$template"/>. Proper way to build links to menu items is by directly passing category id to them like this <inp2:m_Link template="$template" m_cat_id="$cat_id"/>.
As a fix I propose to remove code, that sets m_cat_id from st_CachedMenu tag and patch all our themes (if needed). For users who have customized their themes or created new onces I propose to write note about required change in theme templates in "ChangeLogMessage" field in task, that would be created based on this discussion.
--
Best Regards,
http://www.in-portal.com
http://www.alex-time.com
- menu1
- menu11
- menu12
- menu13
- menu2
- menu21
- menu22
- menu23
For example when you want print menu mentioned above and highlight current page in it, then you should compare this using given tag:
<inp2:m_if check="m_Get" name="m_cat_id" equals_to="$cat_id">highlighted</inp2:m_if> .
Mentioned above tag will always display "highlighted" because of "m_cat_id" request variable, which is compare here is always overwritten from <inp2:st_CachedMenu .../> tag. It was done long ago to automatically pass category into menu item links and for this tag to work: <inp2:m_Link template="$template"/>. Proper way to build links to menu items is by directly passing category id to them like this <inp2:m_Link template="$template" m_cat_id="$cat_id"/>.
As a fix I propose to remove code, that sets m_cat_id from st_CachedMenu tag and patch all our themes (if needed). For users who have customized their themes or created new onces I propose to write note about required change in theme templates in "ChangeLogMessage" field in task, that would be created based on this discussion.
--
Best Regards,
http://www.in-portal.com
http://www.alex-time.com
Dmitry Andrejev
Apr 8, 2010, 8:55:36 AM4/8/10
to in-port...@googlegroups.com
Yes, I agree with this.
Will file a task soon and it probably should be scheduled for 5.0.4
Cheers!
DA.
> --
> You received this message because you are subscribed to the Google Groups
> "In-Portal Bugs Team" group.
> To post to this group, send email to in-port...@googlegroups.com.
> To unsubscribe from this group, send email to
> in-portal-bug...@googlegroups.com.
> For more options, visit this group at
> http://groups.google.com/group/in-portal-bugs?hl=en.
>
Dmitry A.
Apr 9, 2010, 1:03:00 AM4/9/10
to In-Portal Bugs Team
Task filed:
687: All Sub-menu Items appear as "current" when expanded Site Menu is
printed
http://tracker.in-portal.org/view.php?id=687
DA.
Dmitry A.
Jan 4, 2011, 11:14:16 PM1/4/11
to in-port...@googlegroups.com
Hi Alex,
I recall you have mentioned that there might be some side affects when we add this and some In-Portal users/project developers might not like this.
Can you please explain this one more time, I want to make sure we are on the same page and this change not going to cause any misunderstandings.
Thanks.
DA
Reply all
Reply to author
Forward
0 new messages