Customized form blocks were not using "form_row" design resulting fatal error

4 views
Skip to first unread message

Alexander Obuhovich

unread,
Sep 8, 2010, 1:53:27 PM9/8/10
to In-Portal Bugs
Customized form blocks were not using "form_row" design resulting fatal error on pages, that were having such blocks.

Task: http://tracker.in-portal.org/view.php?id=857

Ready for testing.

This is bug created during other task scheduled to 5.1.1 release. Therefore problem can only be reproduced in 5.1.x branch, since it wasn't released at all.

--
Best Regards,

http://www.in-portal.com
http://www.alex-time.com

Dmitry Andrejev

unread,
Sep 10, 2010, 6:42:37 PM9/10/10
to in-port...@googlegroups.com
Thanks for the patch and task (it's already tested as you know).

There might be another issue that rose from this patch. We are getting blank screens on some of Catalog pages.

We had similar issues before and it was related to some JS processing in the catalog_tabs.tpl, but I wonder if it's related to changed latest.


Thanks.

DA

--
You received this message because you are subscribed to the Google Groups "In-Portal Bugs Team" group.
To post to this group, send email to in-port...@googlegroups.com.
To unsubscribe from this group, send email to in-portal-bug...@googlegroups.com.
For more options, visit this group at http://groups.google.com/group/in-portal-bugs?hl=en.



--


Best regards,

Dmitry A.

Alexander Obuhovich

unread,
Sep 11, 2010, 2:18:59 PM9/11/10
to in-port...@googlegroups.com
That is unrelated to form blocks, but is related to task, that was commited in 5.1.1 release (http://tracker.in-portal.org/view.php?id=786):

http://source.in-portal.org/in-portal/branches/5.1.x/core/kernel/db/db_tag_processor.php?r1=13882&r2=13883&pathrev=13883

Tag "IterateGridFields" was a bit changed. As a result, when:
  1. grid was never visited by user
  2. width of at least one column was not set explicitly in unit config
  3. user visits that grid
empty width was returned instead of default width equals to 100px resulting malformed array of grid column widths (GridScroller.MinWidths array) with trailing comma.

Task about this created: http://tracker.in-portal.org/view.php?id=858

Ready for testing.
picker_column_width_was_not_set.patch

Dmitry Andrejev

unread,
Sep 11, 2010, 4:31:02 PM9/11/10
to in-port...@googlegroups.com
New patch tested good (updated task) and can be committed.

Alex, thanks for the fix!!!

DA.
Reply all
Reply to author
Forward
0 new messages