Guest Favorites Merged For All Guest

8 views
Skip to first unread message

Phil -- wbtc.fr --

unread,
Jan 24, 2011, 9:44:09 AM1/24/11
to in-port...@googlegroups.com
Hi,

tested on all v5.x.x:
  1. authorize favorites for guest users in admin, for example in news section
  2. click on a news to put it as favorite, without begin logged (you will see the broken heart, meaning it's added)
  3. go to another computer, display the same news, you'll see it's added as favorite on this other computer
The same thing happens wether it's another computer, browser, different IP... Then I can guess that favorites for guests are not stored in a cookie, but rather in a session?

p

Alexander Obuhovich

unread,
Jan 24, 2011, 12:50:23 PM1/24/11
to in-port...@googlegroups.com
Does Guest user have "FAVORITES" permission?

Do you test on clear installation or on your project?

--
You received this message because you are subscribed to the Google Groups "In-Portal Bugs Team" group.
To post to this group, send email to in-port...@googlegroups.com.
To unsubscribe from this group, send email to in-portal-bug...@googlegroups.com.
For more options, visit this group at http://groups.google.com/group/in-portal-bugs?hl=en.



--
Best Regards,

http://www.in-portal.com
http://www.alex-time.com

Dmitry A.

unread,
Jan 24, 2011, 12:55:01 PM1/24/11
to in-port...@googlegroups.com
No Alex, it's OFF by default.

It's Phil who wants to use it for Guests :)


Sorry Phil, but we don't have the ability to track Users without the Login. It's kind of possible to store this in Cookie or depend on IP, but it's VERY insecure which is why we are NOT even considered it in the past.


I hope it makes sense to you too.


DA

Phil -- wbtc.fr --

unread,
Jan 24, 2011, 4:02:08 PM1/24/11
to in-port...@googlegroups.com
Yes Dmitry, it's OFF by default, and Yes Alex I activated it.

Many websites permits to add favorites even if you are not logged in, and I don't see any security threat to use a cookie for this... How do they do on other websites, which have thousand of visitors per hour? We can't stick on this kind of statement when the web usage is different...

Do you need examples? Youtube, Google... and many other big audience websites

2011/1/24 Dmitry A. <dand...@gmail.com>

--

Alexander Obuhovich

unread,
Jan 24, 2011, 5:09:30 PM1/24/11
to in-port...@googlegroups.com
So Dmitry was right, you need for Guest users to have favorites :)

That would be a feature then, since I'm not considering it's a bug in current favorite tracking system. It's just another viewpoint for an existing system.

Phil -- wbtc.fr --

unread,
Jan 24, 2011, 5:29:35 PM1/24/11
to in-port...@googlegroups.com
Yes I need it, but I was thinking as a big, as we can set a permission which finally don't work ;-)

The main thing is to give user the willing to come back on the website again, and maybe sign later, better than never...

2011/1/24 Alexander Obuhovich <aik....@gmail.com>

Dmitry A.

unread,
Jan 25, 2011, 12:02:31 AM1/25/11
to in-port...@googlegroups.com
Hi Phil,


Yes, we have nothing against this feature. I personally see it as a pretty cool thing and really would be glad to finalize the specs (we still not sure how it's done, either via cookie or something else) and then put it on the TODO list along with others (you know we have plenty). By the way, what is the best example website for this?

Phil, you are welcome to participate in development or sponsor the development of this feature in case if it's so critical to your project.


Thanks for your input!


DA

Alexander Obuhovich

unread,
Jan 25, 2011, 3:50:46 AM1/25/11
to in-port...@googlegroups.com
For technical viewpoint we can do something like this:
  • generate random cookie for user computer (when missing)
  • add UserCookie column to Favorites table
  • when Favorite is added, then also store UserCookie value with it
  • when Favotite is removed, then check, that UserCookie of Favorite matches the one from user computer
  • check if guest has a cookie based on that UserCookie value

This way:
  • check for logged-in users is made using: Favorites.PortalUserId = <LoggedInUserId>
  • check for non logged-in users is made using: Favorites.PortalUserId = GUEST AND Favorites.UserCookie = <UserCookieHere>

Theoretically we even will be able to list all current guest favorites in "My Favorites" section if it won't be set as login-required.


Then, after user is registered/logged-in from that computer we can do several things:
  • store UserCookie in PortalUser table
  • show Favorite list (when logged-in) combined:
    • based on user cookie
    • based on user id
This way, when user presses Logout button, then he still will see favorites he used to add, while being non logged-in.




DA

--
You received this message because you are subscribed to the Google Groups "In-Portal Bugs Team" group.
To post to this group, send email to in-port...@googlegroups.com.
To unsubscribe from this group, send email to in-portal-bug...@googlegroups.com.
For more options, visit this group at http://groups.google.com/group/in-portal-bugs?hl=en.

Phil -- wbtc.fr --

unread,
Jan 25, 2011, 4:09:27 AM1/25/11
to in-port...@googlegroups.com
Alex,

thanks for fast reply on this. It seems good as you describe it. Dmitry, this is not critical (critical things are problems like broken shipping engine), and I could wait for a task.

I agree on Alex's proposal.

p

2011/1/25 Alexander Obuhovich <aik....@gmail.com>

Dmitry A.

unread,
Jan 25, 2011, 11:32:49 PM1/25/11
to in-port...@googlegroups.com
Hi Phil,


Yes, thank you for pointing out on shipping issues once again. We are looking into this trying to pin point the problem. I have a feeling that patch should available soon.

Alex, I am still checking on your solution and what's available on the web so we can compare the approaches.


Cheers!

DA

Phil -- wbtc.fr --

unread,
Jan 26, 2011, 5:12:02 AM1/26/11
to in-port...@googlegroups.com
I was thinking about a local in-cookie favorites storage...

2011/1/26 Dmitry A. <dand...@gmail.com>

DA

--

Alexander Obuhovich

unread,
Jan 26, 2011, 5:49:20 AM1/26/11
to in-port...@googlegroups.com
Maybe we can implement site-wide guest activity tracking. For example we can remember user cookie used in all records being created (along with CreatedById field) and then, after user registers and uses the same cookie, then we can assign that created items to him.

Phil -- wbtc.fr --

unread,
Jan 26, 2011, 6:21:38 AM1/26/11
to in-port...@googlegroups.com
This sounds a very good idea !

2011/1/26 Alexander Obuhovich <aik....@gmail.com>

Dmitry A.

unread,
Feb 2, 2011, 9:03:11 PM2/2/11
to in-port...@googlegroups.com
Hi Alex,


I have read through your notes and see it's a clever plan!

Would you please create a feature request from this discussion.


Cheers!

Alexander Obuhovich

unread,
Feb 5, 2011, 8:57:25 AM2/5/11
to in-port...@googlegroups.com
Task: http://tracker.in-portal.org/view.php?id=989

--
You received this message because you are subscribed to the Google Groups "In-Portal Bugs Team" group.
To post to this group, send email to in-port...@googlegroups.com.
To unsubscribe from this group, send email to in-portal-bug...@googlegroups.com.
For more options, visit this group at http://groups.google.com/group/in-portal-bugs?hl=en.
Reply all
Reply to author
Forward
0 new messages