What is "CreatedBySystem" field in sections

[Alexander Obuhovich]

What is "CreatedBySystem" field in sections (which actually checks, that ThemeId != 0) and what's difference between it and IsSystem field. For now all pages, that are auto-created during theme scanning have IsSystem field set to 1 and ThemeId > 0. When user creates virtual page, then it's always has ThemeId = 0. Can't see the difference.

This is related to discussion about section protection against deletion, since if we can figure out why we need that IsSystem field, then we can use it to protect pages, not to invent one more yes/no type field.

--
Best Regards,

http://www.in-portal.com
http://www.alex-time.com

[Phil ..:: domicilis.biz ::..]

I'm happy you  ask this, as I didn't dare to ask this question on the other post :-D

2010/3/29 Alexander Obuhovich <aik....@gmail.com>

--
You received this message because you are subscribed to the Google Groups "In-Portal Bugs Team" group.
To post to this group, send email to in-port...@googlegroups.com.
To unsubscribe from this group, send email to in-portal-bug...@googlegroups.com.
For more options, visit this group at http://groups.google.com/group/in-portal-bugs?hl=en.

[Dmitry Andrejev]

Ok, I am trying to shed some light here:

1. CreatedBySystem is used ONLY in 1 place:

Categories_tp.php, ItemIcon method:

if ($object->GetDBField('CreatedBySystem')) {

if (!$object->GetDBField('IsMenu')) {

return 'icon16_section_menuhidden_system.png';

}

return 'icon16_section_system.png';

}

Seem like we can successfully use ThemeId = 0 check instead.

By the way, I think we have a little BUG when NOT all Sections created by System have "IsSystem=1". In cases when section was created as section which will home other system sub-sections (when theme is scanned) it has IsSystem = 0 . I just noticed that.

Alex back to you now, what you think?

I think it's VERY related to the other discussion and may be we should combine two so we don't have go back and forth here.

DA.

[Alexander Obuhovich]

Yes, we can combine them. Ah, here is and explanation. We want to make container sections created during theme rebuld appear with same red icon as sections related to physical templates (that ones have IsSystem = 1).

That IsSystem field is used to display design dropdown on section editing (for sections where IsSystem = 0).

Here where that IsSystem field is used:

• page from url detection
• wherever to include category in menu item url's
• menu item url forming (allows to use "id:<SECTION_ID>" template names)
  
• during copy/paste - system pages are not copied
• deletion protection of system pages in non-debug mode

Also by default system pages have links to their real template and not url based on their location in structure, like virtual sections do.

So we can try to set IsSystem to that container sections created during theme scan and see how it will go. But major problem is that system pages doesn't allow design to be selected, so once developer set's IsSystem = 1, then he won't be able to change that page design from dropdown and he won't see current design on form either.

[Dmitry A.]

1. Combine - agreed

2. Putting IsSystem for Container sections - I think it will be okay
to try, I haven't seem a case when we had TO rename that system
template at all. I think it was more theory then real live scenario...
By the way that templates design for Container section still will be
changed in the DBG mode (text box field).

Let's see what we have in the other related discussion and I think we
should create 1 task to cover both:

http://groups.google.com/group/in-portal-dev/browse_thread/thread/e07d7763773f7ca4

DA.

On Mar 30, 3:28 am, Alexander Obuhovich <aik.b...@gmail.com> wrote:
> Yes, we can combine them. Ah, here is and explanation. We want to make
> container sections created during theme rebuld appear with same red icon as
> sections related to physical templates (that ones have IsSystem = 1).
>
> That IsSystem field is used to display design dropdown on section editing
> (for sections where IsSystem = 0).
>
> Here where that IsSystem field is used:
>

>    - page from url detection
>    - wherever to include category in menu item url's
>    - menu item url forming (allows to use "id:<SECTION_ID>" template names)
>    - during copy/paste - system pages are not copied
>    - deletion protection of system pages in non-debug mode

>
> Also by default system pages have links to their real template and not url
> based on their location in structure, like virtual sections do.
>
> So we can try to set IsSystem to that container sections created during
> theme scan and see how it will go. But major problem is that system pages
> doesn't allow design to be selected, so once developer set's IsSystem = 1,
> then he won't be able to change that page design from dropdown and he won't
> see current design on form either.
>

> On Mon, Mar 29, 2010 at 11:21 PM, Dmitry Andrejev <dandre...@gmail.com>wrote:
>
>
>
>
>
> > Ok, I am trying to shed some light here:
>
> > 1. CreatedBySystem is used ONLY in 1 place:
>
> > Categories_tp.php, ItemIcon method:
>
> > if ($object->GetDBField('CreatedBySystem')) {
> >  if (!$object->GetDBField('IsMenu')) {
> > return 'icon16_section_menuhidden_system.png';
> >  }
> > return 'icon16_section_system.png';
> > }
>
> > Seem like we can successfully use ThemeId = 0 check instead.
>
> > By the way, I think we have a little BUG when NOT all Sections created by
> > System have "IsSystem=1". In cases when section was created as section which
> > will home other system sub-sections (when theme is scanned) it has IsSystem
> > = 0 . I just noticed that.
>
> > Alex back to you now, what you think?
>
> > I think it's VERY related to the other discussion and may be we should
> > combine two so we don't have go back and forth here.
>
> > DA.
>
> > On Mon, Mar 29, 2010 at 9:26 AM, Phil ..:: domicilis.biz ::.. <
> > p...@domicilis.biz> wrote:
>
> >> I'm happy you  ask this, as I didn't dare to ask this question on the
> >> other post :-D
>

> >> 2010/3/29 Alexander Obuhovich <aik.b...@gmail.com>

>
> >> What is "CreatedBySystem" field in sections (which actually checks, that
> >>> ThemeId != 0) and what's difference between it and IsSystem field. For now
> >>> all pages, that are auto-created during theme scanning have IsSystem field
> >>> set to 1 and ThemeId > 0. When user creates virtual page, then it's always
> >>> has ThemeId = 0. Can't see the difference.
>
> >>> This is related to discussion about section protection against deletion,
> >>> since if we can figure out why we need that IsSystem field, then we can use
> >>> it to protect pages, not to invent one more yes/no type field.
>
> >>> --
> >>> Best Regards,
>
> >>>http://www.in-portal.com
> >>>http://www.alex-time.com
>
> >>> --
> >>> You received this message because you are subscribed to the Google Groups
> >>> "In-Portal Bugs Team" group.
> >>> To post to this group, send email to in-port...@googlegroups.com.
> >>> To unsubscribe from this group, send email to

> >>> in-portal-bug...@googlegroups.com<in-portal-bugs%2Bunsubscribe@go oglegroups.com>

> >>> .
> >>> For more options, visit this group at
> >>>http://groups.google.com/group/in-portal-bugs?hl=en.
>
> >>  --
> >> You received this message because you are subscribed to the Google Groups
> >> "In-Portal Bugs Team" group.
> >> To post to this group, send email to in-port...@googlegroups.com.
> >> To unsubscribe from this group, send email to

> >> in-portal-bug...@googlegroups.com<in-portal-bugs%2Bunsubscribe@go oglegroups.com>

> >> .
> >> For more options, visit this group at
> >>http://groups.google.com/group/in-portal-bugs?hl=en.
>
> >  --
> > You received this message because you are subscribed to the Google Groups
> > "In-Portal Bugs Team" group.
> > To post to this group, send email to in-port...@googlegroups.com.
> > To unsubscribe from this group, send email to

> > in-portal-bug...@googlegroups.com<in-portal-bugs%2Bunsubscribe@go oglegroups.com>

[Alexander Obuhovich]

ok.

To unsubscribe from this group, send email to in-portal-bug...@googlegroups.com.

For more options, visit this group at http://groups.google.com/group/in-portal-bugs?hl=en.

[Dmitry A.]

Based on this discussion

http://groups.google.com/group/in-portal-dev/browse_thread/thread/e07d7763773f7ca4

We'll be renaming IsSystem to PageType and probably getting rid of
"CreatedBySystem" field.

Still to confirm and create a task for the main discussion (link
above).

DA.

On Apr 1, 5:18 pm, Alexander Obuhovich <aik.b...@gmail.com> wrote:
> ok.
>
>
>
>
>
> On Wed, Mar 31, 2010 at 8:42 AM, Dmitry A. <dandre...@gmail.com> wrote:
> > 1. Combine - agreed
>
> > 2. Putting IsSystem for Container sections - I think it will be okay
> > to try, I haven't seem a case when we had TO rename that system
> > template at all. I think it was more theory then real live scenario...
> > By the way that templates design for Container section still will be
> > changed in the DBG mode (text box field).
>
> > Let's see what we have in the other related discussion and I think we
> > should create 1 task to cover both:
>

> >http://groups.google.com/group/in-portal-dev/browse_thread/thread/e07...

[Phil -- wbtc.fr --]

"Page type" is definitively better !

p.

2010/4/5 Dmitry A. <dand...@gmail.com>:

> To unsubscribe from this group, send email to in-portal-bug...@googlegroups.com.

[Dmitry A.]

Task has been filed:

683: Preventing the Deletion of specific Sections in the Catalog

http://tracker.in-portal.org/view.php?id=683

DA.

On Apr 4, 9:55 pm, "Phil -- wbtc.fr --" <p...@wbtc.fr> wrote:
> "Page type" is definitively better !
>
> p.
>

> 2010/4/5 Dmitry A. <dandre...@gmail.com>:
>
>
>
> > Based on this discussion
>
> >http://groups.google.com/group/in-portal-dev/browse_thread/thread/e07...