Compiling rc10

[Martin Kelly]

Hi, I've been trying to update the imms Debian package and have had
troubles compiling rc10. I applied the Log(DEBUG) -> Log(Info) patch,
but it still searches for the header auddrct.h (which no longer exists
in newer versions of Audacious) and the function drct_playqueue_add
(which has been renamed).

I got it to compile with svn and this patch:

http://code.google.com/p/imms/issues/detail?id=18

I'm wondering whether I have any options other than waiting for the
next imms release or making the next Debian package come from svn.

Thanks,
Martin Kelly

[Michael Grigoriev]

Thanks for the patch, Martin.

I tried it out, but it seems to cause Audacious 2.5 to crash.

I can't spot anything obviously wrong by looking at the code, and unfortunately I don't have too much time to debug this.

Any ideas what's wrong with it?

As as aside, do you know if Audacious has any sort of documentation describing interface changes between versions?

Have fun,

Michael.

--
You received this message because you are subscribed to the Google Groups "imms-users" group.
To post to this group, send email to imms-...@googlegroups.com.
To unsubscribe from this group, send email to imms-users+...@googlegroups.com.
For more options, visit this group at http://groups.google.com/group/imms-users?hl=en.

[Martin Kelly]

On 05/20/2011 11:06 AM, Michael Grigoriev wrote:
> Thanks for the patch, Martin.
> I tried it out, but it seems to cause Audacious 2.5 to crash.
> I can't spot anything obviously wrong by looking at the code, and
> unfortunately I don't have too much time to debug this.
> Any ideas what's wrong with it?
>
> As as aside, do you know if Audacious has any sort of documentation
> describing interface changes between versions?
>
> Have fun,
> Michael.

Unfortunately, I have no idea about documentation or interface changes.
I only recently started looking at Audacious code :(. So I'm not sure
how to proceed from here.

[Michael Grigoriev]

I got it to work. The issue was the change from filename_to_utf8 to g_filename_to_utf8. The later is more picky about its inputs, so lack of NULL checking on its return value was causing a crash.

All of the client code could use a major cleanup. There are way too compatibility layers to make it work with XMMS, BMP and other obsolete players, that are not really needed anymore. But, in the mean time, it works again, and the fix is committed to SVN. Thanks again for your patch, it was a very useful starting point.

Have fun,

Michael.

[Martin Kelly]

I'm glad you finally got it to work. Note that the patch isn't
actually mine; I just noticed it. I want to make sure to give credit
where credit is due!

Do you plan to release this as an official version (even if just a
minor update). It seems like a good idea, as incompatibility with
Audacious was rather crippling (I haven't used IMMS for several years
for this reason). If you don't, I can package the current SVN and put
that into Debian instead.

[Michael Grigoriev]

Ok, built a new release.

Note that versioning has changed: I now use SNV revision as the version number.

http://code.google.com/p/imms/downloads/list

Thanks for volunteering to update the Debian package!

Have fun,

Michael.

[Martin Kelly]

Awesome! I'll tell the Debian maintainer for imms.

On Jul 10, 3:32 pm, Michael Grigoriev <m...@luminal.org> wrote:
> Ok, built a new release.
> Note that versioning has changed: I now use SNV revision as the version

> number.http://code.google.com/p/imms/downloads/list

[Artur R. Czechowski]

Hi,

Has anyone tested it? I've a strange behavior here.

1. Name looks like garbled UTF-8 string. See screenshot:
http://blabluga.hell.pl/imms/img/name.png
2. When turn off the imms checkbox "IMMS Configuration"
3. When turn on the imms checkbox "About IMMS" popup is shown.
4. IMMS plugin does not work at all.

Could anyone confirm any option from below?
* IMMS is working and I'm doing something wrong
* IMMS does not work and bahave as I described above.

Regards
Artur

--
- You can take my soul but not my lack of enthusiasm.
/Wally, "Dilbert" 2004.11.23/

[Michael Grigoriev]

Hi, Artur,

Are you using Audacious 2.4.x? I think the new version is only compatible with 2.5.

I'll try to see if I can make it work with both, but I might not be able to get around to it for a while.

Have fun,
Michael.

[Artur R. Czechowski]

On Thu, Jul 21, 2011 at 12:31:15PM -0400, Michael Grigoriev wrote:
> Hi, Artur,
>
> Are you using Audacious 2.4.x? I think the new version is only compatible
> with 2.5.

Thanks for the info :) I'll ask Debian maintainers of Audacious about their
plans to upload 2.5.x to Debian.

Regards
Artur