Re: [Imdbpy-devel] broken search and other parsers (call for help)

21 views
Skip to first unread message

H. Turgut Uyar

unread,
Dec 3, 2012, 8:16:47 AM12/3/12
to imdbpy...@lists.sourceforge.net
On 12/01/2012 08:40 PM, Davide Alberani wrote:
> So, honestly, while I'm glad to receive many "the search is broken!"
> bug reports, this time I'd really appreciate more some patches. :-)

I'll have a go at it but other volunteers would be most welcome. I'm not
sure if I can get it done in time if changes turn out to be more than I
expected.

Davide, sorry to ask this again: Do you have a set of correct .p files
available for download somewhere? I thought the ones I generated last
week were OK but I guess the search pages I fetched were broken due to
the "; instead of &" issue in search URLs.

--
H. Turgut Uyar <uy...@itu.edu.tr> [GPG KeyID: 0x1E18F231]
http://web.itu.edu.tr/uyar/


------------------------------------------------------------------------------
Keep yourself connected to Go Parallel:
BUILD Helping you discover the best ways to construct your parallel projects.
http://goparallel.sourceforge.net
_______________________________________________
Imdbpy-devel mailing list
Imdbpy...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/imdbpy-devel

Davide Alberani

unread,
Dec 3, 2012, 10:22:15 AM12/3/12
to H. Turgut Uyar, IMDbPY development
On Mon, Dec 3, 2012 at 2:16 PM, H. Turgut Uyar <uy...@itu.edu.tr> wrote:
>
> Davide, sorry to ask this again: Do you have a set of correct .p files
> available for download somewhere?

Hmmm... the latest I have are these:
http://bender.mimante.net/imdbpy/http-mobile.tgz

but I'm not too sure if they are good or not.

As usual, thanks for the help!


--
Davide Alberani <davide....@gmail.com> [PGP KeyID: 0x465BFD47]
http://www.mimante.net/

H. Turgut Uyar

unread,
Dec 3, 2012, 10:53:08 AM12/3/12
to imdbpy...@lists.sourceforge.net
On 12/03/2012 05:22 PM, Davide Alberani wrote:
> On Mon, Dec 3, 2012 at 2:16 PM, H. Turgut Uyar <uy...@itu.edu.tr> wrote:
>>
>> Davide, sorry to ask this again: Do you have a set of correct .p files
>> available for download somewhere?
>
> Hmmm... the latest I have are these:
> http://bender.mimante.net/imdbpy/http-mobile.tgz
>

OK, I got them. Not just the format, the data seems to have changed too.
I couldn't find any movie search results with multiple akas.

I have a few commits now, mainly regarding the movie search parser.
Should I apply them to the main repository or would you prefer me to
fork it and send you a pull request?

--
H. Turgut Uyar <uy...@itu.edu.tr> [GPG KeyID: 0x1E18F231]
http://web.itu.edu.tr/uyar/


Davide Alberani

unread,
Dec 3, 2012, 11:02:18 AM12/3/12
to H. Turgut Uyar, IMDbPY development
On Mon, Dec 3, 2012 at 4:53 PM, H. Turgut Uyar <uy...@itu.edu.tr> wrote:
>
> OK, I got them. Not just the format, the data seems to have changed too.
> I couldn't find any movie search results with multiple akas.

Yup; it's in the FAQs:

Q: I use akas.imdb.com. What happened to the list of the AKAs under
the movies and people on the search page there?

A: The objective of this project was to simplify search both
technically and in the UI. Instead of providing all AKAs on the search
results page, we focus on including results with AKAs that closely
match the search term, if any. All AKAs for individual titles are
still viewable via title pages.

> I have a few commits now, mainly regarding the movie search parser.
> Should I apply them to the main repository or would you prefer me to
> fork it and send you a pull request?

I think you have ti right to push directly to the main repository.
No problem at all: it can't be more broken that it is now. :-)

Thanks!


--
Davide Alberani <davide....@gmail.com> [PGP KeyID: 0x465BFD47]
http://www.mimante.net/

H. Turgut Uyar

unread,
Dec 3, 2012, 11:20:48 AM12/3/12
to Davide Alberani, IMDbPY development
On 12/03/2012 06:02 PM, Davide Alberani wrote:
> On Mon, Dec 3, 2012 at 4:53 PM, H. Turgut Uyar <uy...@itu.edu.tr> wrote:
>>
>> OK, I got them. Not just the format, the data seems to have changed too.
>> I couldn't find any movie search results with multiple akas.
>
> Yup; it's in the FAQs:
>
> Q: I use akas.imdb.com. What happened to the list of the AKAs under
> the movies and people on the search page there?
>
> A: The objective of this project was to simplify search both
> technically and in the UI. Instead of providing all AKAs on the search
> results page, we focus on including results with AKAs that closely
> match the search term, if any. All AKAs for individual titles are
> still viewable via title pages.
>

My bad, sorry. I still don't read this as "there will be at most one
aka" but I guess it's implied.

>> I have a few commits now, mainly regarding the movie search parser.
>> Should I apply them to the main repository or would you prefer me to
>> fork it and send you a pull request?
>
> I think you have ti right to push directly to the main repository.
> No problem at all: it can't be more broken that it is now. :-)
>

The movie search parser now produces some results. Due to the multiple
aka - single aka change, I cannot validate them against earlier results.
Direct hit search seems to work too. Now I'll try to handle the
remaining issues like TV episodes. I don't know when I can get to the
other search parsers though.


--
H. Turgut Uyar <uy...@itu.edu.tr> [GPG KeyID: 0x1E18F231]
http://web.itu.edu.tr/uyar/

Davide Alberani

unread,
Dec 10, 2012, 3:13:46 PM12/10/12
to H. Turgut Uyar, IMDbPY development
On Mon, Dec 3, 2012 at 5:20 PM, H. Turgut Uyar <uy...@itu.edu.tr> wrote:
>
> Now I'll try to handle the remaining issues like TV episodes

Fixing https://bitbucket.org/alberanid/imdbpy/issue/18/attributeerror-when-calling-search_movie
I've introduced an hack to handle tv episodes.

I'm absolutely not sure that it is always correct, but at least doesn't throw
an exception (ok, I'm almost sure it's somewhat wrong, but again... ;))



--
Davide Alberani <davide....@gmail.com> [PGP KeyID: 0x465BFD47]
http://www.mimante.net/

------------------------------------------------------------------------------
LogMeIn Rescue: Anywhere, Anytime Remote support for IT. Free Trial
Remotely access PCs and mobile devices and provide instant support
Improve your efficiency, and focus on delivering more value-add services
Discover what IT Professionals Know. Rescue delivers
http://p.sf.net/sfu/logmein_12329d2d
Reply all
Reply to author
Forward
0 new messages