Re: ImapGrab better update
Daniel Roesler
I'm sorry it's been over two months since you suggested your changes.
I examined your code an implemented several changes. You can check out
the changes on the SVN
(http://imapgrab.svn.sourceforge.net/viewvc/imapgrab/). I added the
--localuser option to the main program. I also added [Google Mail]
exception to the -_Gmail_ option. I also added another option for
mailboxes that adds only the [Gmail]/* or [Google Mail]/* folders (use
-m "_Gmail_"). I also changed around the handling of folder paths
(similar to what you did, but with different variable names). Folder
paths were very confusing before, so I hope I cleared it up a bit
(there are no interface changes for this, just code changes).
I didn't implement the shebang change ("/usr/bin/env python" is
usually best path for portability). I also didn't implement changes
for excepting the [Gmail] or [Google Mail] folder itself. The option
"_Gmail_" doesn't include them by default (only [Gmail]/* or [Google
Mail]/*), but I'm not sure I see a reason to insert logic to except
those directories specifically later in the code. Is there a situation
where you are using that logic? If you are downloading all folders,
wouldn't you just use the option -m "_ALL_, -[Google Mail]"? I worry
that specifically filtering for one or two folders might lead to rare
situations where those folders might be used. I'm thinking about a
private server that has a folder called [Gmail] for some unrelated
reason. I would like people to be able to download a folder called
[Gmail] or [Google Mail], and let those who can't filter it out (with
the "-[Gmail]" or "-[Google Mail]" option in -m).
I plan on releasing this version as 0.1.4, so please take a look and
see if there is anything else you want me to add/fix/clarify.
Avast!
Daniel Roesler
dia...@gmail.com
http://daylightpirates.org/index.php/Programs/ImapGrab
On Sun, Jul 19, 2009 at 8:14 AM, Peter Kehl <peter...@gmail.com> wrote:
> please feel free to forward the email or change the code in any way
>
> --
> Best regards,
>
> Peter Kehl
>
> On Sat, Jul 18, 2009 at 8:20 AM, Daniel Roesler <dia...@gmail.com> wrote:
>> Hey Peter!
>>
>> Sorry for the late reply. I've been out of town. I will take a look at
>> your patches, and let you know when I incorporate them (should be a
>> few days). Do you mind if I forward your emails to the mailing list
>> (imap...@googlegroups.com)?
>>
>> Avast!
>> Daniel Roesler
>> dia...@gmail.com
>> http://daylightpirates.org/index.php/Programs/ImapGrab
>>
>> On Thu, Jul 16, 2009 at 1:11 PM, Peter Kehl<peter...@gmail.com> wrote:
>>> Daniel,
>>>
>>> then I've noticed that for some Google users, it calls their mailbox
>>> [Google Mail] instead of [Gmail]. So I've added that to the Google
>>> exceptions and also to except [Google Mail] itself - as it also fails
>>> when doing IMAP SELECT.
>>>
>>> Attached.
>>>
>>> Best regards,
>>>
>>> Peter Kehl
>>