[ imagination-Bugs-3440628 ] Fixing aspect ratio problems in version 3.0
SourceForge.net
Message generated for change (Comment added) made by jakeotr
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=1125540&aid=3440628&group_id=244319
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Ted Merrill (tedmerrill)
Assigned to: Nobody/Anonymous (nobody)
Summary: Fixing aspect ratio problems in version 3.0
Initial Comment:
Without a fix, using imagination 3.0, the exported .vob files are slightly squoze and cliipped... enough to bother me!
There are several problems.
One is that the output is assumed to have square pixels, whereas in fact it doesn't: for example, NTSC vob files at 480x720 with 4:3 aspect ratio
have pixels that have a ratio of about 8/9 (or 9/8 depending on how you state it).
Another problem is that img->video_ratio is never recomputed when a .img project file is loaded; instead a default value of 1.25 is still used.
I made a simple hack fix that works for me and also points to the way to a clean solution.
The basic idea of my fix is to use square pixels within imagination itself, and tell ffmpeg to reformat to the correct pixels size.
To fix video_ratio, in main_window.c i set it to 640/480 instead of 720/576 (yes, i want NTSC).
A correct fix would change it based on whatever was loaded or selected.
I also changed img_get_format_options() case 0 (VOB) case 0 to set video_size[0] to 640 instead of 720.
A correct fix would change the other cases as well to appropriate values.
Finally, in export.c:img_exporter_vob() in the forming of the ffmpeg command i replaced img->video_size[0], img->video_size[1] with 720, 480 .
A correct fix would use different variables for video_size for this case than for the display cases; also fix the other exporters.
Of course i had to set PLUGINS_INSTALLED to 1 in support.h (otherwise the resulting program sometimes crashes).
With these fixes, imagination works perfectly for my limited case of 4:3 NTSC VOB output.
-Ted Merrill
----------------------------------------------------------------------
Comment By: jakeotr (jakeotr)
Date: 2012-01-24 09:38
Message:
I followed your directions and the program compiled and works ok....but it
wont write a .vob file. It seems to go through the project fast but does
not write a file....any ideas?
thanks
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=1125540&aid=3440628&group_id=244319