Documentation Bugs: no addEventListener on AdsLoader

132 views
Skip to first unread message

Kevin Brogan

unread,
Nov 8, 2019, 1:23:37 PM11/8/19
to Interactive Media Ads SDK
https://developers.google.com/interactive-media-ads/docs/sdks/html5/v3/reference/js/ima.AdsLoader

A few things:

There is a notice about the AdsLoader extending goog.events.EventTarget but no link to said EventTarget interface.
Searching for EventTarget returns "No Results" on the search page.

The AdsManager has addEventListener as a property and there is no reference to goog.events.EventTarget. This is inconsistent with the layout of AdsLoader's documentation.

When the new documentation was released, there is now also a capture parameter on addEventListener, but it doesn't make sense to have a capture parameter because ima events do not bubble through any hierarchy.

The feedback form for the documentation is broken, displaying an empty white box with no method to send any feedback. Chrome 78, Windows 10

IMA SDK

unread,
Nov 8, 2019, 6:09:24 PM11/8/19
to kevin....@sendtonews.com, ima...@googlegroups.com
Hi Kevin,

Thank you for reaching out to us. The goog.events.EventTarget of the AdsLoader and the AdsManager is an abstract way to explain that developers can attach events to these class but goog.events.EventTarget doesn't really exist.

The event bubble parameter of the IMA SDK's AdsLoader allows us to bubble up through the IMA's iFrame DOM. The event propagation is strictly restricted to the iFrame's DOM.

I was able to reproduce the issue where the documentation's feedback placeholder is not displaying. I'll share it with the rest of the team, they are going to review this issue and I'll get back to this thread as soon as I have more information.

Regards,
Arnaud Casame
IMA SDK Team


ref:_00D1U1174p._5001UMWjA4:ref

IMA SDK

unread,
Nov 11, 2019, 1:41:37 PM11/11/19
to kevin....@sendtonews.com, ima...@googlegroups.com
Hi Kevin,

A fix for the Send Feedback issue is now live. The feedback dialog box of the documentation is displayed as intended when the button is clicked.


Regards,
Arnaud Casame
IMA SDK Team


ref:_00D1U1174p._5001UMWjA4:ref
Reply all
Reply to author
Forward
0 new messages