Question regarding Test Case 16310

13 views
Skip to first unread message

Sven Rienstra

unread,
Mar 22, 2012, 5:32:36 AM3/22/12
to ihe-xdw-im...@googlegroups.com
Hi all,

I have a question regarding test case 16310, the test involves updating the XDW-Document-for-Updater.xml document. The only task defined in the document is already completed, so my question is, what should be updated in the document?

Regards,

Sven Rienstra


Boufahja Abderrazek

unread,
Mar 22, 2012, 8:53:20 AM3/22/12
to sven.r...@topicus.nl, ihe-xdw-im...@googlegroups.com
Hi Sven,

I am Abderrazek from IHE / gazelle team.

There are only one task on the XDW document, and what the content updater is supposed to do is to add a new task on the document, add eventually a XDWdocumentHistory/
documentEvent, set the workflowStatus of the document as closed, and update the workflowDocumentSequenceNumber. I hope I have not forget something else.

Best regards,

    Abderrazek.


2012/3/22 Sven Rienstra <Sven.R...@topicus.nl>

--
You received this message because you are subscribed to the Google Groups "ihe-xdw-implementors" group.
To post to this group, send email to ihe-xdw-im...@googlegroups.com.
To unsubscribe from this group, send email to ihe-xdw-implemen...@googlegroups.com.
For more options, visit this group at http://groups.google.com/group/ihe-xdw-implementors?hl=en.



--
Abderrazek BOUFAHJA
Ingénieur polytechnicien
Tel : +21696733593
Tel : +33635432836

image001.gif

Boufahja Abderrazek

unread,
Mar 23, 2012, 5:24:07 AM3/23/12
to Parisot, Charles (GE Healthcare), sven.r...@topicus.nl, ihe-xdw-im...@googlegroups.com, lynn felhofer
Hi Charles,

     >>-       I am unclear about: “add eventually an XDW document History/Document Event”, adding a new task requires to update the EventHistory,, so eventually is improper.

I agree with you, the update of /XDW.WorkflowDocument/XDWdocumentHistory/documentEvent must be required if we modify the workflowStatus of the XDW document, as it was explained on the table 5.4.3-4. I think that modifying a task, or adding a new task without the modification of the workflowStatus does not require an update of the /XDW.WorkflowDocument/XDWdocumentHistory element.

Adding a new task or updating a task requires to update the XDWTask/taskEventHistory.

    >>-       When you say “Set the workflow status of the document”, I suppose you mean “set the workflow status to complete”.

The workflowStatus describes the status of the document ,not the tasks; it can only be OPEN or CLOSE.

i have forgotten also the fact that a document updater shall add itself as an author of the document, on the /XDW.WorkflowDocument/author element.

I agree also with your remark about the content of the task, for the test case 16310.
 
I will discuss with Lynn how to update the description of the test case 16310 by referring to this discussion.

Best regards,

     Abderrazek.


 


2012/3/22 Parisot, Charles (GE Healthcare) <charles...@med.ge.com>

Abderazek,

 

I am confused with some of your words:

-       Adding a new task in an XDW workflow document for a Document Updater Actor is fine.

-       I am unclear about: “add eventually an XDW document History/Document Event”, adding a new task requires to update the EventHistory,, so eventually is improper.

-       When you say “Set the workflow status of the document”, I suppose you mean “set the workflow status to complete”.

-       Update the workflow sequence. No issue.

 

It would be good to reference a newly created document in the task.  This would do two things: ensure that the mechanism to publish a document and creating a task are implemented.  In general, performing an unexpected task that produces nothing would be unusual.

 

Charles  




--
Abderrazek BOUFAHJA
IHE Development team

--
You received this message because you are subscribed to the Google Groups "ihe-xdw-implementors" group.
To post to this group, send email to ihe-xdw-im...@googlegroups.com.
To unsubscribe from this group, send email to ihe-xdw-implemen...@googlegroups.com.
For more options, visit this group at http://groups.google.com/group/ihe-xdw-implementors?hl=en.

Parisot, Charles (GE Healthcare)

unread,
Mar 23, 2012, 7:28:46 AM3/23/12
to Boufahja Abderrazek, sven.r...@topicus.nl, ihe-xdw-im...@googlegroups.com, lynn felhofer

Abderrazek,

 

This statement : “I think that modifying a task, or adding a new task without the modification of the workflowStatus does not require an update of the /XDW.WorkflowDocument/XDWdocumentHistory element.”

 

Is incorrect.  Any display of the History shall allow a review of all changes/step of the workflow.  Adding a step is definitively important.

If your understanding what that it is only changes in the workflow status that needs to be tracked in the history….the history would be empty except for one element.

This is wrong: the history is what a physician looks at when it reviews the overall workflow history ! 

 

If this is not clear in the profile, a CP is needed, I believe.

 

What do other think ?

 

Charles

2012/3/22 Sven Rienstra <Sven.R...@topicus.nl>

Parisot, Charles (GE Healthcare)

unread,
Mar 22, 2012, 1:15:14 PM3/22/12
to abderraze...@gmail.com, sven.r...@topicus.nl, ihe-xdw-im...@googlegroups.com

Abderazek,

 

I am confused with some of your words:

-       Adding a new task in an XDW workflow document for a Document Updater Actor is fine.

-       I am unclear about: “add eventually an XDW document History/Document Event”, adding a new task requires to update the EventHistory,, so eventually is improper.

-       When you say “Set the workflow status of the document”, I suppose you mean “set the workflow status to complete”.

-       Update the workflow sequence. No issue.

 

It would be good to reference a newly created document in the task.  This would do two things: ensure that the mechanism to publish a document and creating a task are implemented.  In general, performing an unexpected task that produces nothing would be unusual.

 

Charles  

 

 

From: ihe-xdw-im...@googlegroups.com [mailto:ihe-xdw-im...@googlegroups.com] On Behalf Of Boufahja Abderrazek
Sent: jeudi 22 mars 2012 13:53
To: sven.r...@topicus.nl
Cc: ihe-xdw-im...@googlegroups.com
Subject: Re: [ihe-xdw-implementors:12]] Question regarding Test Case 16310

 

Hi Sven,

image001.gif

Mauro Zanardini

unread,
Mar 23, 2012, 11:55:59 AM3/23/12
to charles...@med.ge.com, Boufahja Abderrazek, sven.r...@topicus.nl, ihe-xdw-im...@googlegroups.com, lynn felhofer
Charles,

I think you are confusing between XDWdocumentHistory and the taskList (or the taskEventHistory),

XDWdocumentHistory is the element that permit to track only changes of the WorkflowStatus of the Workflow Document. So it contains a DocumentEvent for each change of status, from OPEN to CLOSE or vice versa.  We can use this element like below:

 <ns3:XDWdocumentHistory>

   <ns2:documentEvent>

     <ns2:eventTime>2006-05-04T18:13:51.0Z</ns2:eventTime>

     <ns2:eventType>OPEN</ns2:eventType>

     <ns2:previousStatus></ns2:previousStatus>

   </ns2:documentEvent>

   <ns2:documentEvent>

     <ns2:eventTime>2006-05-07T09:53:45.0Z</ns2:eventTime>

     <ns2:eventType>CLOSE</ns2:eventType>

     <ns2:previousStatus>OPEN</ns2:previousStatus>

   </ns2:documentEvent>

 </ns3:XDWdocumentHistory>


Regards
Mauro

2012/3/23 Parisot, Charles (GE Healthcare) <charles...@med.ge.com>



--
Dott. Mauro Zanardini
Project Engineer

Consorzio Arsenàl.IT
Centro Veneto Ricerca e Innovazione per la Sanità Digitale
Viale Oberdan, 5
31100 Treviso

E-mail: mzana...@consorzioarsenal.it

lynn felhofer

unread,
Mar 23, 2012, 12:04:45 PM3/23/12
to ihe-xdw-im...@googlegroups.com
I agree with Mauro, and also wonder whether XDWdocumentHistory should be "R", rather than "O", so that original Creator of the XDW document makes the first documentEvent entry, and then subsequent entries are added if the status is updated.

To provide clarity, a few of us will be getting on the phone about this topic later today and we will provide an update to this email group shortly.

Lynn

Parisot, Charles (GE Healthcare)

unread,
Mar 24, 2012, 7:17:04 AM3/24/12
to Mauro Zanardini, Boufahja Abderrazek, sven.r...@topicus.nl, ihe-xdw-im...@googlegroups.com, lynn felhofer

Mauro, Abderazek,

 

You are right.  Thanks for clarifying.

 

Charles

Sven Rienstra

unread,
Mar 28, 2012, 10:40:36 AM3/28/12
to <felhofer@charter.net>, <ihe-xdw-implementors@googlegroups.com>
I tried to add the initial created documentevent to a new document but the validator won't validate it:
cvc-enumeration-valid: Value '' is not facet-valid with respect to enumeration '[OPEN, CLOSED]'. It must be a value from the enumeration.
cvc-type.3.1.3: The value '' of element 'ns4:previousStatus' is not valid.

My xml looks like this:
<ns4:XDWdocumentHistory>
    <ns4:documentEvent>
      <ns4:eventTime>2012-03-28T16:30:02.450+02:00</ns4:eventTime>
      <ns4:eventType>create</ns4:eventType>
      <ns4:previousStatus/>
    </ns4:documentEvent>
  </ns4:XDWdocumentHistory>

I could add a previousStatus, but it would incorrect. So do we need to add the initial event and how? 

Sven

Boufahja Abderrazek

unread,
Mar 29, 2012, 4:39:05 AM3/29/12
to sven.r...@topicus.nl, <felhofer@charter.net>, <ihe-xdw-implementors@googlegroups.com>
Hi Sven,

Yes in fact, there are a problem on the validation of this element of the document XDW. We think there are a problem on this part of the schema, we will discuss about that this afternoon and we will inform you later about that.

Thank you for notifying this problem.

Regards,

    Abderrazek.

2012/3/28 Sven Rienstra <Sven.R...@topicus.nl>
Reply all
Reply to author
Forward
0 new messages