Runner exception handling patch

[Kim Gräsman]

Hello,

I'm using Igloo for a side project, and it occurred to me that there's
no exception handler for the spec execution, so the entire runner
terminates if a spec throws an unexpected exception.

Have we decided explicitly that we like that behavior (for ease of
debugging, for example)?

I noticed it really bugged me in my current context, so I hacked up a
patch to catch all std::exceptions and report them with existing
mechanisms. Feel free to adopt if it's generally useful.

I keep thinking that it would be nice to be able to register custom
exception types to handle, but I can't be bothered at the moment...

- Kim

[Joakim Karlsson]

Hi Kim,

Sorry for not replying sooner.

I'll take a look at your patch. I think we semi-automatically assumed
unknown exceptions shouldn't be caught.

How is it bugging you in your current context?

/Joakim

[Kim Gräsman]

Hi there,

IIRC, the default behavior on Windows was that std::unexpected was called, and I got a less-than-helpful "The program has requested that the runtime terminate in an unusual manner." message box.

It's weird, though, now that I think about it... std::unexpected/terminate/abort should only be called when a new exception is thrown as part of stack unwinding or if a function violates its exception spec. But I don't think either happens in this case. Maybe I should investigate closer...

- Kim