Code Review required for Libero Generate Movement

[shiju01]

Hi all

Kindly check the  hi-lighted if condition below  !!!


    /**************************************************************************
     *     Create Line
     *    @param Distribution order order
     *    @param orderLine line
     *    @param qty qty
     *    @param storages storage info
     *    @param force force delivery
     */
    private void createLine (MDDOrder order, MDDOrderLine orderLine, BigDecimal qty,
        MStorageOnHand[] storages, boolean force)
    {
        //    Complete last Shipment - can have multiple shipments
        if (m_lastC_BPartner_Location_ID != order.getC_BPartner_Location_ID() )
            completeMovement();
        m_lastC_BPartner_Location_ID = order.getC_BPartner_Location_ID();
        //    Create New Shipment
        if (m_movement == null)
        {
            MLocator locator = MLocator.get(getCtx(),orderLine.getM_Locator_ID());
            m_movement = createMovement(order, m_movementDate);
            m_movement.setAD_Org_ID(locator.getAD_Org_ID());
            //m_movement.setM_Warehouse_ID(orderLine.getM_Warehouse_ID());    //    sets Org too
            m_movement.setIsInTransit(true);
            m_movement.setDD_Order_ID(order.getDD_Order_ID());

            if (order.getC_BPartner_ID() != order.getC_BPartner_ID())

                m_movement.setC_BPartner_ID(order.getC_BPartner_ID());

            if (order.getC_BPartner_Location_ID() != order.getC_BPartner_Location_ID())

                m_movement.setC_BPartner_Location_ID(order.getC_BPartner_Location_ID());