Reverse Invoice with Payment Cash

[Victor Suárez]

Hello community.

I have  a doubt. When I reverse an Invoice with Payment Rule is CASH ('B'), it's create a payment, with "PayAmt" in negative, and it's complete it, but I think this other payment shouldn't be created. If not, reverse the existing payment, and associated with this invoice.

WDYT?

[Martin Schönbeck]

Hi Victor,

I my opinion it depends on when the original. payment was created. If it was created implicitly by completing the invoice it of should be reversed when reversing this completion. Reversing a completion should reverse anything which was initiated by this completion.

Regards,
Martin

[Victor Suárez]

Currently, iDempiere always creates the Payment, when it is effective, and does not come from a POS Order, even if the Invoice is reversed. 

// POS supports multiple payments

boolean fromPOS = false;

if ( getC_Order_ID() > 0 )

{

fromPOS = getC_Order().getC_POS_ID() > 0;

}

  // Create Cash Payment

if (PAYMENTRULE_Cash.equals(getPaymentRule()) && !fromPOS
                 /// Should be Validated if Reversed    
                   !isReversal()) {
                   //   ... Payment is Created  ...
                }

[Victor Suárez]

I think that payment should be reversed like this:

public void reversePayment(boolean accrual) {

  if(PAYMENTRULE_Cash.equals(getPaymentRule()) && getC_Payment_ID() > 0) {

        boolean fromPOS = false;

if (getC_Order_ID() > 0)

   fromPOS = getC_Order().getC_POS_ID() > 0;

  // Reverse Cash Payment

  if (!fromPOS ) {

MPayment payment = new MPayment(getCtx(), getC_Payment_ID(), get_TrxName());

if(accrual) {

   payment.setDocAction(DocAction.ACTION_Reverse_Accrual);

   payment.reverseAccrualIt();

} else {

   payment.setDocAction(DocAction.ACTION_Reverse_Correct);

   payment.reverseCorrectIt();

}

payment.saveEx(get_TrxName());

     }

}

}