A little Proposal to Improve CSV Import file Loader

[hideaki hagiwara]

Hi,all.

I am Hideaki Hagiwara in Japan.

I often use CSV Import file Loader.

It is very useful function. 

I like CSV Import file Loader and I recomend my customer to use it.

So, I have a little proposal to Improve CSV Import file Loader.

I would like to add argument Charset to create FileWriter instance at validateFile() method of MImportTemplate class.

*please refer image.

Because, Japanese people use windows-31j Charset at Excel usually, but windows-31j Charset be Error to Garbled characters(Mojibake in Japanese).

UTF-8 is no problem, but I am not sure, other some charset may be Error of Garbled characters like a windows-31j Charset.

I think that to add argument Charset to create FileWriter instance at validateFile method of MImportTemplate class is no problem for UTF-8 too.

And I think this little improvement useful for not only Japanese people, but also other people. 

May I create JIRA ticket?

Best regards,

[Heng Sin Low]

make sense to me, please create jira ticket and if possible, a pull request for it.

--
You received this message because you are subscribed to the Google Groups "iDempiere" group.
To unsubscribe from this group and stop receiving emails from it, send an email to idempiere+...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/idempiere/9b2ecc8d-7211-44fb-97c9-3a6a3d725122%40googlegroups.com.

[hideaki hagiwara]

Hi, Hengsin.

Thanks for quick response.

I created JIRA Tciket.

https://idempiere.atlassian.net/browse/IDEMPIERE-4305

And I Will create pull request soon.

:-D

Best regards,