Aging - some lines are hidden if using C_Currency_ID as parameter

[Nicolas Micoud]

Hello,

If I execute the Aging process with an empty C_Currency_ID parameter, I got 22 lines in the T_Aging table.
If I execute the Aging process with a C_Currency_ID > 0 parameter, I got 22 lines in the T_Aging table.

It's correct.

But when the report engine display data, the "filter on currency" display only 14 lines ~ those where T_Aging.C_Currency_ID = Parameter.C_Currency_ID
I expect to see all lines with amounts converted in the selected currency.

=> Which is NOT correct

I think is because of the automatic filter which compares the parameter with same table columnnames.

Is there an easy way to swith off this filter ?

Otherwise, I do not see another way but change the parameter name (C_Currency_ID => C_Currency_ID_To) in the process and in the code (tested locally and it works).

WDYT ?

Thanks,

Nicolas

[Carlos Antonio Ruiz Gomez]

Hi Nicolas, the behavior you describe sounds in line with the
description of the process on the Help:

"If you select a currency, you get only invoices of that currency,
otherwise the amounts are converted to your primary accounting currency."

Regards,

Carlos Ruiz




El 29/07/19 a las 15:54, Nicolas Micoud escribió:

[Nicolas Micoud]

... RTFM :D

Reading... the "otherwise the amounts are converted to your primary accounting currency" doesn't work.

My primary currency is USD and for instance, all EUR amounts remains in EUR. Looking in code, if p_Currency_ID is 0, no conversion is done.

In fact, the requirement was to display all amounts in the primary currency (USD) - which should is the default (according to the description) - and I thought it was because of a "bad" filter.

Wondering if another criteria would be useful in order to have :
 - convert all amounts in currency (actual parameter)
 - filter on currency (new parameter)

wdyt ?

Thanks,

Nicolas

[Carlos Antonio Ruiz Gomez]

Well - that sounds like a mismatch between the documentation and the behavior.

I think as you said - if you rename the actual parameter - it will work as "convert" - and you can add the new parameter with name C_Currency_ID for filter.  It sounds useful and more inline with what is expected, if you do a migration script, please fix also the Process Help to match with the process.

Regards,

Carlos Ruiz

El 29/07/19 a las 16:23, Nicolas Micoud escribió:

[Nicolas Micoud]

Hi Carlos,

Could you confirm the content of the patch please ?

 - Add a new parameter (ConvertAmountsInCurrency_ID) - and use it in the code instead of the current C_Currency_ID
 - update the Process Help text :

If you select a currency, you get only invoices of that currency, otherwise the amounts are converted to your primary accounting currency.

Will become :

If you select a currency, you get only invoices of that currency.
If you fill the "Convert Amounts in Currency", all amounts will be converted in that currency

Thanks,

Nicolas

[Carlos Antonio Ruiz Gomez]

Yes, that sounds good

El 29/07/19 a las 17:49, Nicolas Micoud escribió:

[Nicolas Micoud]

Thanks Carlos

Ref: https://idempiere.atlassian.net/browse/IDEMPIERE-4014