[idempiere/idempiere] 119a9a: IDEMPIERE-7069: Inclusive Pricelist with Summary T...

1 view
Skip to first unread message

Alan Lescano

unread,
Jul 31, 2026, 7:51:51 AM (3 days ago) Jul 31
to idempi...@googlegroups.com
Branch: refs/heads/master
Home: https://github.com/idempiere/idempiere
Commit: 119a9aef72d9e118b6e40e4db3dd49d63b0b1490
https://github.com/idempiere/idempiere/commit/119a9aef72d9e118b6e40e4db3dd49d63b0b1490
Author: Alan Lescano <32880862+...@users.noreply.github.com>
Date: 2026-07-31 (Fri, 31 Jul 2026)

Changed paths:
M org.adempiere.base/src/org/adempiere/model/ITaxProvider.java
M org.adempiere.base/src/org/compiere/model/MInvoiceLine.java
M org.adempiere.base/src/org/compiere/model/MOrderLine.java
M org.adempiere.base/src/org/compiere/model/MTaxProvider.java

Log Message:
-----------
IDEMPIERE-7069: Inclusive Pricelist with Summary Tax should be allowed when a custom Tax Provider is used (#3317)

* IDEMPIERE-7069: Inclusive Pricelist with Summary Tax should be allowed when a custom Tax Provider is used

Restore the IDEMPIERE-6749 workaround (forbid a tax-included price list combined
with a summary tax) to its actual scope: the native StandardTaxProvider
calculation. Delegate the decision to the tax provider through a new
ITaxProvider.isTaxIncludedSummarySupported() capability method (default false),
so a correctly-implemented custom Tax Provider can allow the line to be saved.

Co-Authored-By: Claude Opus 4.8 <nor...@anthropic.com>

* IDEMPIERE-7069: Add cache to MTaxProvider to avoid a performance penalty

Following the review, MTaxProvider now implements ImmutablePOSupport and
provides the standard get/getCopy cached accessors (ImmutableIntPOCache),
as done in MTax and MCharge.

MOrderLine and MInvoiceLine use MTaxProvider.get(ctx, C_TaxProvider_ID)
instead of instantiating the model on every beforeSave.

---------

Co-authored-by: Claude Opus 4.8



To unsubscribe from these emails, change your notification settings at https://github.com/idempiere/idempiere/settings/notifications
Reply all
Reply to author
Forward
0 new messages