Some edit page fields missing 'resizable textarea-processed' class

[Jay Cosnett]

We are noticing in 2.3.1 that some of the fields on the edit pages are not getting assigned a class that the other fields are. Most have the class, 'resizable textarea-processed'. The ones that don't, however, end up being invisibly "covered up" by the label of the next field, which results in a problem where a user clicks the field they want to edit, but it activates the field below it.

We are not seeing this problem in 2.4, where all the fields appear to be getting marked up with the correct class.

Is this a bug in 2.3.1 that's been fixed in 2.4? Where is the code that assigns this class to these fields?

In this screen shot, 2.4 is on the left, 2.3.1 on the right.

[Dan Gillean]

Hi Jay,

Thanks for this interesting message - I'm glad to hear that this appears fixed in 2.4, but I don't recall this being a bug we were aware of in 2.3.1 or earlier. I'll check in with our developers and update this thread if they've caught and fixed something I missed.

One thing you could try is recompiling the CSS? I don't know if it would help or not, but it's worth a shot.

• make -C plugins/arDominionPlugin

Let us know if that makes any difference. 

I did notice that in the screenshot on the right, there is still a grippy bar on the bottom right-hand corner of the scope and content field - can you not grab and drag that to expand the field?

It is a bit weird that the field right below uses a different method of indicating it is expandable (it should be consistent), but I can do this in my 2.3.1 test environment:

​

Regards,

Dan Gillean, MAS, MLIS
AtoM Program Manager
Artefactual Systems, Inc.
604-527-2056

@accesstomemory

--
You received this message because you are subscribed to the Google Groups "AtoM Users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to ica-atom-users+unsubscribe@googlegroups.com.
To post to this group, send email to ica-atom-users@googlegroups.com.
Visit this group at https://groups.google.com/group/ica-atom-users.
To view this discussion on the web visit https://groups.google.com/d/msgid/ica-atom-users/248324ec-3f2c-4e87-af48-a02b4f22ca34%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[Jay Cosnett]

Hi Dan,

Thanks for your reply.

Since our custom theme has lots of our own CSS, we recompile after every change. How this has come up is that I'm working on the theme on a local vagrant box running 2.4, but our project is running 2.3.1. 

I've looked at the markup and it seems that the affected field (Scope and content, in this case), is missing a lot of markup, not just the class. When I add in the correct markup in the Inspector, it fixes everything.

So, this is what it has:

<textarea rows="4" cols="30" name="scopeAndContent" id="scopeAndContent">The papers consist of... (more content goes here blah blah)</textarea>

When I give it this structure (so it matches the other fields, and which all fields have in 2.4), life is good again:

<div class="resizable-textarea">

     <span>

          <textarea rows="4" cols="30" name="scopeAndContent" class="resizable textarea-processed" id="scopeAndContent">The papers consist of... (more content goes here blah blah)</textarea>

               <div class="grippie"></div>

     </span>

</div>

So... Since we're launching with 2.3.1, can you point us to where the markup is created for each field? Somehow, this field (and a pretty random assortment of others), is missing out.

Oh, and while the improperly marked-up fields do have a resize-control in the lower-right corner, the missing markup causes the label of the field below to cover it up, so you can't grab it.

At this point, the only workaround is to instruct editors that, if and when this happens, to click the *label* to activate the field below.

Any guidance you can give us will be greatly appreciated!

On Wednesday, May 3, 2017 at 10:48:27 AM UTC-7, Dan Gillean wrote:

Hi Jay,

Thanks for this interesting message - I'm glad to hear that this appears fixed in 2.4, but I don't recall this being a bug we were aware of in 2.3.1 or earlier. I'll check in with our developers and update this thread if they've caught and fixed something I missed.

One thing you could try is recompiling the CSS? I don't know if it would help or not, but it's worth a shot.

• make -C plugins/arDominionPlugin

Let us know if that makes any difference. 

I did notice that in the screenshot on the right, there is still a grippy bar on the bottom right-hand corner of the scope and content field - can you not grab and drag that to expand the field?

It is a bit weird that the field right below uses a different method of indicating it is expandable (it should be consistent), but I can do this in my 2.3.1 test environment:

​

Regards,

Dan Gillean, MAS, MLIS
AtoM Program Manager
Artefactual Systems, Inc.
604-527-2056

@accesstomemory

On Tue, May 2, 2017 at 5:59 PM, Jay Cosnett <jayco...@gmail.com> wrote:

We are noticing in 2.3.1 that some of the fields on the edit pages are not getting assigned a class that the other fields are. Most have the class, 'resizable textarea-processed'. The ones that don't, however, end up being invisibly "covered up" by the label of the next field, which results in a problem where a user clicks the field they want to edit, but it activates the field below it.

We are not seeing this problem in 2.4, where all the fields appear to be getting marked up with the correct class.

Is this a bug in 2.3.1 that's been fixed in 2.4? Where is the code that assigns this class to these fields?

In this screen shot, 2.4 is on the left, 2.3.1 on the right.

--
You received this message because you are subscribed to the Google Groups "AtoM Users" group.

To unsubscribe from this group and stop receiving emails from it, send an email to ica-atom-user...@googlegroups.com.
To post to this group, send email to ica-ato...@googlegroups.com.

[David Juhasz]

Hi Jay,

The scope and content markup in AtoM 2.3 is created here:

https://github.com/artefactual/atom/blob/stable/2.3.x/plugins/sfIsadPlugin/modules/sfIsadPlugin/templates/editSuccess.php#L107-L108

The "array('class' => 'resizable')" code at the end of line 108 adds the "resizable" class to the textarea. On page load a javascript does some magic to make the gripper work and then adds the "textarea-processed" class.

If you check https://demo.accesstomemory.org (which is AtoM Release 2.3.1) you can see that the scope & content field works correctly there, so I think the problem you are experiencing is due to your custom theming work.

Best regards,

David

--

David Juhasz
Director, AtoM Technical Services

Artefactual Systems Inc.
www.artefactual.com

To unsubscribe from this group and stop receiving emails from it, send an email to ica-atom-users+unsubscribe@googlegroups.com.
To post to this group, send email to ica-atom-users@googlegroups.com.

Visit this group at https://groups.google.com/group/ica-atom-users.

To view this discussion on the web visit https://groups.google.com/d/msgid/ica-atom-users/f4c6048a-49a7-4357-9d52-60bc449a86f8%40googlegroups.com.

[Jay Cosnett]

Well, it looks like the demo site does have the same inconsistency of markup that we're seeing as well (the top field is just a <textarea> while the bottom gets a div and a span):

We have also figured out that it is a piece of our css that was making this inconsistency actually create an end-user problem. Since the markup was consistent in 2.4, we didn't see the problem there. Setting the float parameter to back to inherit (ours had been set to right) makes the problem go away for 2.3.

By jove I think we've got it!

Thanks for your help,

Jay

[David Juhasz]

Hi Jay,

Huh, I'm seeing the class tags on scope and content for that Fonds:

​

Are you testing the DACS template maybe?  It may be the "resizable" class is missing for DACS but not ISAD?

Cheers,
David

--

David Juhasz
Director, AtoM Technical Services

Artefactual Systems Inc.
www.artefactual.com

To unsubscribe from this group and stop receiving emails from it, send an email to ica-atom-users+unsubscribe@googlegroups.com.
To post to this group, send email to ica-atom-users@googlegroups.com.

Visit this group at https://groups.google.com/group/ica-atom-users.

To view this discussion on the web visit https://groups.google.com/d/msgid/ica-atom-users/cd0a74ba-2b1d-4d3a-b094-8faff068083b%40googlegroups.com.