Places maps not rendering?

[Shay Telfer]

Hi...

It looks like the template for Places doesn't seem to include the Google Maps API key in the url to maps.googleapis.com, so the map doesn't render even if the API key is set?

https://github.com/artefactual/atom/blob/qa/2.6.x/apps/qubit/modules/term/templates/indexSuccess.php#L114

Thanks,

Shay

[Dan Gillean]

Hi Shay, 

You're right! Thank you for reporting this. I've filed a bug ticket here: https://projects.artefactual.com/issues/13063

The static maps that could be generated on terms using the Code field is a legacy feature added in a very early version of ICA-AtoM and scarcely touched since. Consequently, when the setting was added for the Google Maps API key (to support the ability to add dynamic maps to digital objects, this feature was not integrated with it. 

Previously Google allowed calls to its Maps API without an API key. After a bit of searching online, it seems that they ended this practice in 2016. So you're correct that we'll need to integrate this feature with the Maps API key setting to get it working again. 

We will try to address this for the next release, but please note that filing a ticket alone does not guarantee it will be addressed. You can see this page for more information on how we maintain and develop AtoM. 

If you or your institution is interested in sponsoring a fix for this work, please feel free to contact me off-list. Meanwhile, I've added several code references on the ticket from more recent Maps API integrations in AtoM that could be used as a reference for addressing this - so if you are (or have) a developer and would like to submit a pull request to address this, please review this page - we would welcome your contribution! 

Cheers, 

Dan Gillean, MAS, MLIS
AtoM Program Manager
Artefactual Systems, Inc.
604-527-2056

@accesstomemory

--
You received this message because you are subscribed to the Google Groups "AtoM Users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to ica-atom-user...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/ica-atom-users/CAD2SUhFdqE-rQeXAj68LoY2UUgd8T3a-YNwOxhAVegCqJN5MtA%40mail.gmail.com.