Auto complete search results in 2.3

74 views
Skip to first unread message

Creighton Barrett

unread,
Sep 12, 2016, 12:13:00 PM9/12/16
to ica-ato...@googlegroups.com
Hi there,

We are upgrading from 2.1 to 2.3 and noticed a bug in the search box. Search results and the "all matching descriptions" link in the autocomplete were returning JSON.

From our Developer:

"In AtoM 2.3, the search was changed "from search?query=Dalhousie&repos=" to "informationobject/browse?topLod=0&query=Dalhousie&repos=". The autocomplete drop down for "all matching descriptions" was not updated to match the changes. If a user selects it, they will be shown encoded json instead of a valid AtoM search page."

I don't know, maybe this only happened to us because we made some customizations to the autocomplete results.

We applied a patch that seems to work for us, and Margaret made a pull request: https://github.com/artefactual/atom/pull/434

It updates the autocompleteSuccess.php file. I haven't filed a bug in Redmine in ages, and not sure what the preference is these days for handling this kind of thing. So the pull request doesn't reference a bug in the issue tracker. But it's there for you to have a look!

Cheers,
Creighton

Dan Gillean

unread,
Sep 12, 2016, 6:35:18 PM9/12/16
to ICA-AtoM Users
Hi Creighton,

Thanks for this! I've reproduced this issue in my local 2.3 test VM, and I've filed a bug ticket here: https://projects.artefactual.com/issues/10295

We'll follow up with the developer when we have a bit of time between projects!

Kind regards,

Dan Gillean, MAS, MLIS
AtoM Program Manager
Artefactual Systems, Inc.
604-527-2056
@accesstomemory

--
You received this message because you are subscribed to the Google Groups "AtoM Users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to ica-atom-users+unsubscribe@googlegroups.com.
To post to this group, send email to ica-atom-users@googlegroups.com.
Visit this group at https://groups.google.com/group/ica-atom-users.
To view this discussion on the web visit https://groups.google.com/d/msgid/ica-atom-users/CAHueW_W1aH55gmcE%2BhsFE3zU65K6jsM%3DE2Z6KiSgb8PqM_ej_w%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.

Creighton Barrett

unread,
Sep 12, 2016, 8:14:39 PM9/12/16
to ica-ato...@googlegroups.com
Great, thanks for filing the bug ticket, Dan.

Cheers,
Creighton

On 12 September 2016 at 19:34, Dan Gillean <d...@artefactual.com> wrote:
Hi Creighton,

Thanks for this! I've reproduced this issue in my local 2.3 test VM, and I've filed a bug ticket here: https://projects.artefactual.com/issues/10295

We'll follow up with the developer when we have a bit of time between projects!

Kind regards,

Dan Gillean, MAS, MLIS
AtoM Program Manager
Artefactual Systems, Inc.
604-527-2056
@accesstomemory

On Mon, Sep 12, 2016 at 9:12 AM, Creighton Barrett <csba...@gmail.com> wrote:
Hi there,

We are upgrading from 2.1 to 2.3 and noticed a bug in the search box. Search results and the "all matching descriptions" link in the autocomplete were returning JSON.

From our Developer:

"In AtoM 2.3, the search was changed "from search?query=Dalhousie&repos=" to "informationobject/browse?topLod=0&query=Dalhousie&repos=". The autocomplete drop down for "all matching descriptions" was not updated to match the changes. If a user selects it, they will be shown encoded json instead of a valid AtoM search page."

I don't know, maybe this only happened to us because we made some customizations to the autocomplete results.

We applied a patch that seems to work for us, and Margaret made a pull request: https://github.com/artefactual/atom/pull/434

It updates the autocompleteSuccess.php file. I haven't filed a bug in Redmine in ages, and not sure what the preference is these days for handling this kind of thing. So the pull request doesn't reference a bug in the issue tracker. But it's there for you to have a look!

Cheers,
Creighton

--
You received this message because you are subscribed to the Google Groups "AtoM Users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to ica-atom-users+unsubscribe@googlegroups.com.
To post to this group, send email to ica-ato...@googlegroups.com.

--
You received this message because you are subscribed to the Google Groups "AtoM Users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to ica-atom-users+unsubscribe@googlegroups.com.
To post to this group, send email to ica-atom-users@googlegroups.com.
Visit this group at https://groups.google.com/group/ica-atom-users.
Reply all
Reply to author
Forward
0 new messages