Issue 1495 in ibus: Don't show the iBus Hangul Preferences application launcher

[ib...@googlecode.com]

Status: New
Owner: ----
Labels: Type-Defect Priority-Medium

New issue 1495 by allanp...@gmail.com: Don't show the iBus Hangul
Preferences application launcher
http://code.google.com/p/ibus/issues/detail?id=1495

OS (Linux distributions, UNIX or ...): Fedora
IBus version: 1.4.99
Input method name and version: ibus-hangul-1.4.1

iBus Hangul Preferences can now be accessed from GNOME System Settings - an
application launcher isn't required.

[ib...@googlecode.com]

Updates:
Labels: Component-ibus-hangul

Comment #1 on issue 1495 by damage3...@gmail.com: Don't show the iBus

Hangul Preferences application launcher
http://code.google.com/p/ibus/issues/detail?id=1495

Thank you for your feedback.
Let me apply the component tag for you.

[ib...@googlecode.com]

Updates:
Status: Started
Owner: choe.h...@gmail.com
Cc: choe.h...@gmail.com
Labels: -Type-Defect Type-Review

Comment #2 on issue 1495 by damage3...@gmail.com: Don't show the iBus

Hangul Preferences application launcher
http://code.google.com/p/ibus/issues/detail?id=1495

I've done the related work.
https://github.com/choehwanjin/ibus-hangul/pull/10

Waiting for origin author's review.

[ib...@googlecode.com]

Updates:
Cc: takao.fujiwara1

Comment #3 on issue 1495 by takao.fujiwara1: Don't show the iBus Hangul

Preferences application launcher
http://code.google.com/p/ibus/issues/detail?id=1495

I agreed with this bug. It's not good to have the language specific menus
in application menus and it could cause many engine setup menus.
ibus-setup can launch each engine setup.

[ib...@googlecode.com]

Comment #4 on issue 1495 by damage3...@gmail.com: Don't show the iBus

Hangul Preferences application launcher
http://code.google.com/p/ibus/issues/detail?id=1495

Now I feel that my pull request seems to be too aggressive.
Add "NoDisplay=true" to the .desktop file would be much easier.

@choehwanjin
Can you give a response?

[ib...@googlecode.com]

Comment #5 on issue 1495 by choe.h...@gmail.com: Don't show the iBus

Hangul Preferences application launcher
http://code.google.com/p/ibus/issues/detail?id=1495

Ok, let's remove ibus-setup-hangul menu from desktop settings.
I will merge maxiaojun's branch on github.

[ib...@googlecode.com]

Comment #6 on issue 1495 by eladalfa...@gmail.com: Don't show the iBus

Hangul Preferences application launcher
http://code.google.com/p/ibus/issues/detail?id=1495

Any update? I'd really like this being fixed for Fedora 18

[ib...@googlecode.com]

Comment #7 on issue 1495 by damage3...@gmail.com: Don't show the iBus

Hangul Preferences application launcher
http://code.google.com/p/ibus/issues/detail?id=1495

I made a new pull request, please review.
https://github.com/choehwanjin/ibus-hangul/pull/11

[ib...@googlecode.com]

Comment #8 on issue 1495 by boche...@fedoraproject.org: Don't show the iBus

Hangul Preferences application launcher
http://code.google.com/p/ibus/issues/detail?id=1495

You shouldn't remove the desktop file, otherwise GNOME Control Center won't
find it any more.

Using « Hidden=true » leads to the same result (G-C-C doesn't find the
setup).

Using e.g « NotShowIn=GNOME; » (add more desktops as needed) properly hides
the launcher from the menus, and still lets G-C-C find it. However, at this
point the Application Menu in GNOME Shell won't show the nice title of the
setup application (the value of « Name= » in the desktop file), but instead
will show « Ibus-setup-hangul » (i.e the name of the executable).

In comment #4, you suggest using « NoDisplay=true », but that doesn't even
hide the launcher in the GNOME Shell application list.

Overall, I'm not sure how to properly fix this bug. :-/

[ib...@googlecode.com]

Comment #9 on issue 1495 by boche...@fedoraproject.org: Don't show the iBus

Hangul Preferences application launcher
http://code.google.com/p/ibus/issues/detail?id=1495

Turns out I was wrong about « NoDisplay=true » (I tested it in the wrong
desktop file ^_^)

The rest still stands, so « NoDisplay=true » is the way to go.

maxiaojun's branch removes the desktop file completely, which is wrong, as
GNOME Control Center won't see it any more.

[ib...@googlecode.com]

Comment #10 on issue 1495 by damage3...@gmail.com: Don't show the iBus

Hangul Preferences application launcher
http://code.google.com/p/ibus/issues/detail?id=1495

OK, let me redo it.

"NoDisplay=true" is something I learned here.
https://github.com/ibus/ibus-anthy/blob/master/setup/ibus-setup-anthy.desktop.in.in
It is also used in ibus-pinyin.
https://github.com/ibus/ibus-pinyin/tree/master/data

[ib...@googlecode.com]

Comment #11 on issue 1495 by damage3...@gmail.com: Don't show the iBus

Hangul Preferences application launcher
http://code.google.com/p/ibus/issues/detail?id=1495

The new new pull request:
https://github.com/choehwanjin/ibus-hangul/pull/12

[ib...@googlecode.com]

Comment #12 on issue 1495 by choe.h...@gmail.com: Don't show the iBus

Hangul Preferences application launcher
http://code.google.com/p/ibus/issues/detail?id=1495

Do I mistake this problem?
I understand that the issue is to remove the menu from control panel.
Because Ibus-setup can launch ibus-setup-hangul, we don't need
ibus-setup-hangul menu in control panel.
If this is true, we don't need a desktop file anymore.

[ib...@googlecode.com]

Comment #13 on issue 1495 by damage3...@gmail.com: Don't show the iBus

Hangul Preferences application launcher
http://code.google.com/p/ibus/issues/detail?id=1495

No no.
Have you tried GNOME 3.6 live image?
http://www.gnome.org/getting-gnome/

In GNOME 3.6 environment, it seems like we no longer use ibus-setup.
( ibus-setup has no GUI access as far as I know. )
Management of input sources (including input methods) and their preferences
are done in GNOME Control Center.
The UI looks like this.
https://live.gnome.org/Design/SystemSettings/RegionAndLanguage
Better to try the live image directly though.
( It works in VirtualBox. )

[ib...@googlecode.com]

Comment #14 on issue 1495 by choe.h...@gmail.com: Don't show the iBus

Hangul Preferences application launcher
http://code.google.com/p/ibus/issues/detail?id=1495

I've tried it on vbox but failed
It was too slow and didn't respond to my mouse.

[ib...@googlecode.com]

Comment #15 on issue 1495 by takao.fujiwara1: Don't show the iBus Hangul

Preferences application launcher
http://code.google.com/p/ibus/issues/detail?id=1495

I haven't tried the latest vbox yet but I think vbox 4.1.14 works fine.
But probably you don't have to try gnome-shell.

Running 'gnome-session --session gnome-fallback' shows the metacity +
gnome-panel.
If you run gnome-panel, The application menu -> Others -> 'IBus Hangul
Preferences' is shown and we'd like to disable it.
If you run 'gnome-control-center region' in GNOME 3.6, it has the engine
preference button and the button checks the desktop files in
/usr/share/applications.
g-c-c is used in gnome-shell and ibus-setup is used for non-gnome-shell
desktops.

[ib...@googlecode.com]

Updates:
Status: Fixed

Comment #16 on issue 1495 by choe.h...@gmail.com: Don't show the iBus

Hangul Preferences application launcher
http://code.google.com/p/ibus/issues/detail?id=1495

Ma Xiaojun's branch was merges.

https://github.com/choehwanjin/ibus-hangul/commit/4022bff2bfec3519fe07034ca8277dfaea3b2021