HystrixObservableCommand SEMAPHORE and timeout configuration

[Greg Roodt]

Hi

I've seen various conversations around timeouts in SEMAPHORE isolated Commands.

I'm wondering what the current state is and how to configure the values in the config.properties file?

Does this value still take effect?
hystrix.command.default.execution.isolation.thread.timeoutInMilliseconds=1000

It seems like it does, even for SEMAPHORE isolated Commands.

[Matt Jacobs]

Yes that still works (though now it's poorly-named).  This also works:

hystrix.command.default.execution.timeoutInMilliseconds=1000

In theory, I'd like to remove the use of the former, but that could cause weird, silent breakages for people.  So I don't have a definite timeline for removal of that config namespace.

[Greg Roodt]

Great! Thanks Matt.

Would you like me to update the documentation with the new value so people stop using the old value?

[Greg Roodt]

Hmmmm....

Does this configuration style work for Commands as well? It seems that the shorter syntax doesn't work for me on 1.5.5.

hystrix.command.SomeCommand.execution.timeoutInMilliseconds=2000

[Matt Jacobs]

Yeah, looks like you're right.  in HystrixCommandDemo, there are a couple places where we configure timeouts via a named property.

Using hystrix.command.XXX.execution.isolation.thread.timeoutInMilliseconds=YYY worked

Using hystrix.command.XXX.execution.timeoutInMilliseconds=YYY did not

I already have a ticket to properly deprecate - I'll make sure this gets fixed.

Thanks for the report!

[Greg Roodt]

Cool! Thanks Matt.

If it's an easy enough fix, point me to the issue and I'll take a look.

[Matt Jacobs]

This was the original issue: https://github.com/Netflix/Hystrix/issues/673.  It's specifically around the deprecation/removal lifecycle.  Might be better to open a new Issue/PR.  If you're up for contributing, that would be awesome.  Otherwise, I'll make sure it happens in the 1.5.6 release.

Thanks!