[hyperdbg] CmInitSpinLock() ?

[Jun Koi]

Hi,

I looked at some ASM code, and found something hard to understand.

For example, CmInitSpinLock() is implemented in ASM. What is the
motivation of that code, and why it needs to be done in ASM??

Thanks,
J

[Roberto Paleari]

Hi Jun,

During the development we tried to resort to ASM code only when
absolutely necessary, but I cannot exclude that some of the ASM
functions in the current version of HyperDbg can be safely rewritten
in C.

The Cm*Lock() functions implement a simple spin-lock to guard accesses
to the COM port.
However, at this point I am not really sure this stuff is really
needed.. Probably we can just drop these functions, as there should be
not concurrency issues in root mode.

Cheers,
Roberto

--
Roberto Paleari