geo_concerns file sets

[Eliot Jordan]

Geo Modelers -

I just drafted this email to Eric, but I just realized that I should have addressed it to the WG at large. This is the post from hydra-tech I was referring to.

https://groups.google.com/forum/#!topic/hydra-tech/VtAfE39eoi0

 

- E

Eric -
Saw your post in Hydra-Tech from yesterday. I've been working through the same issues. What really came across was that I was fighting with curation_concerns / works rather that working with it. I started work on an alternative model where instead of subclassing FileSet, we use FileSet as is and simply mark the file type during creation.
Check out this branch. 
https://github.com/projecthydra-labs/geo_concerns/tree/single-file-set
Be warned, it's a little rough, and I was working to flesh out some tests before making a proposal PR. Also, Trey and Esme are on site today this week and I'm hoping to chat with them about this in person.
- Eliot

[James, Eric]

Eliot,

Your PR looks like it addresses the issues I also was trying to hit in (https://github.com/projecthydra-labs/geo_concerns/issues/36), although in a slightly different way.  Will give it a closer look later this afternoon.

-Eric

---

From: hydra-gis-w...@googlegroups.com [hydra-gis-w...@googlegroups.com] on behalf of Eliot Jordan [eliot....@gmail.com]
Sent: Wednesday, December 02, 2015 10:46 AM
To: Hydra GIS Working Group
Subject: geo_concerns file sets

--
You received this message because you are subscribed to the Google Groups "Hydra GIS Working Group" group.
To unsubscribe from this group and stop receiving emails from it, send an email to hydra-gis-working...@googlegroups.com.
To post to this group, send email to hydra-gis-w...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/hydra-gis-working-group/772b55fd-f121-4bab-a72a-8295ecff863e%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[James, Eric]

Awesome Eliot.  Nice consolidation of the FileSets behavior.  Some things I wasn't sure about, like whether ordering members should apply, and I couldn't find a vector_works/_show_actions.  But otherwise looks good!

---

From: hydra-gis-w...@googlegroups.com [hydra-gis-w...@googlegroups.com] on behalf of James, Eric [eric....@yale.edu]
Sent: Wednesday, December 02, 2015 12:32 PM
To: Eliot Jordan; Hydra GIS Working Group
Subject: RE: geo_concerns file sets

To view this discussion on the web visit https://groups.google.com/d/msgid/hydra-gis-working-group/CE283D58C99213489EAEB1F0F49544722C39AD19%40x10-mbx2.yu.yale.edu.

[Eliot Jordan]

Thanks Eric. I'm working right now to finish up the PR so we can have a group discussion/review. I demoed geo_concerns to Trey and Esme, and got some positive feedback. They both agreed that using FileSet as is instead of subclassing into different FileSet types was the way to go if there wasn't a really good reason to do it. FileSet is hard-coded into curation_concerns and hydra-works in many places. If there were good use cases for abstracting it out, that could happen, but it would be a pretty hefty undertaking. 

As for ordered_members, I think you are correct. I can't think of a reason, at this point, why geo_works need to be in a particular order. As you probably know, behavior around ordered and unordered members is under active discussion.

https://groups.google.com/forum/#!topic/hydra-tech/YkYAdo6iDhI

- Eliot