[PATCH] gpu: drm: msm: disp: mdp4: mdp4_crtc: remove unnecessary braces {}

[Fu Zuan]

In the function mdp4_crtc_vblank_irq, there are single
statement blocks with unnecessary braces.

Fix this by removing the unnecessary braces.

Fixes: d47b9587a0d9 ("gpu: drm: msm: disp: mdp4: mdp4_crtc: remove unnecessary braces {}")

Signed-off-by: Fu Zuan <u2021...@hust.edu.cn>
---
drivers/gpu/drm/msm/disp/mdp4/mdp4_crtc.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/msm/disp/mdp4/mdp4_crtc.c b/drivers/gpu/drm/msm/disp/mdp4/mdp4_crtc.c
index 169f9de4a12a..ecebabf6d93f 100644
--- a/drivers/gpu/drm/msm/disp/mdp4/mdp4_crtc.c
+++ b/drivers/gpu/drm/msm/disp/mdp4/mdp4_crtc.c
@@ -506,9 +506,8 @@ static void mdp4_crtc_vblank_irq(struct mdp_irq *irq, uint32_t irqstatus)

pending = atomic_xchg(&mdp4_crtc->pending, 0);

- if (pending & PENDING_FLIP) {
+ if (pending & PENDING_FLIP)
complete_flip(crtc, NULL);
- }

if (pending & PENDING_CURSOR) {
update_cursor(crtc);
--
2.32.1 (Apple Git-133)

[ktest...@126.com]

Hi, Fu Zuan
This email is automatically replied by KTestRobot(version 1.0). Please do not reply to this email.
If you have any questions or suggestions about KTestRobot, please contact Lishuchang <U2020...@hust.edu.cn>

--- Changed Paths ---
drivers/gpu/drm/msm/disp/mdp4/mdp4_crtc.c

--- Log Message ---

In the function mdp4_crtc_vblank_irq, there are single
statement blocks with unnecessary braces.

Fix this by removing the unnecessary braces.

--- Test Result ---
*** CheckPatch FAILED ***
WARNING: Unknown commit id 'd47b9587a0d9', maybe rebased or not pulled?
#9:

Fixes: d47b9587a0d9 ("gpu: drm: msm: disp: mdp4: mdp4_crtc: remove unnecessary braces {}")

total: 0 errors, 1 warnings, 10 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
mechanically convert to the typical style using --fix or --fix-inplace.

/home/pride/Repos/KTestRobot/KTBot/patch/FuZuan_20231116191226.patch has style problems, please review.

NOTE: If any of the errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.



--
KTestRobot(version 1.0)

[Fu Zuan]

In the function mdp4_crtc_vblank_irq, there are single
statement blocks with unnecessary braces.

Fix this by removing the unnecessary braces.

[ktest...@126.com]

Hi, Fu Zuan
This email is automatically replied by KTestRobot(version 1.0). Please do not reply to this email.
If you have any questions or suggestions about KTestRobot, please contact Lishuchang <U2020...@hust.edu.cn>

--- Changed Paths ---
drivers/gpu/drm/msm/disp/mdp4/mdp4_crtc.c

--- Log Message ---

In the function mdp4_crtc_vblank_irq, there are single
statement blocks with unnecessary braces.

Fix this by removing the unnecessary braces.

--- Test Result ---
*** CheckPatch PASS ***
*** ApplyTolinux-next PASS ***
*** ApplyTomainline PASS ***
*** BuildCheck PASS ***
*** CheckCocci PASS ***
*** CheckCppcheck PASS ***

--
KTestRobot(version 1.0)

[Dongliang Mu]

On 11/16/23 19:24, Fu Zuan wrote:

In the function mdp4_crtc_vblank_irq, there are single
statement blocks with unnecessary braces.

This should be "In the function mdp4_crtc_vblank_irq, there is a single statement block with unnecessary braces."

Send a v2 patch.

[Dan Carpenter]

On Thu, Nov 16, 2023 at 07:24:19PM +0800, Fu Zuan wrote:
> In the function mdp4_crtc_vblank_irq, there are single
> statement blocks with unnecessary braces.

Use () for function names. People are becoming strict about that.
(As a reviewer I would ignore this but other people might complain).

"In the function mdp4_crtc_vblank_irq(), ...

regards,
dan carpenter