[PATCH] Makefile: Remove the product of pin_init cleanly in mrporper

[chenmiao]

When I enabled Rust compilation, I wanted to clean up its output, so I
used make cleanand make mrproper. However, I was still able to find that
libpin_init_internal.so in the rust directory was not deleted, while
all other corresponding outputs were cleared.

If this is an intentional design, I will drop this commit.

Signed-off-by: chenmiao <chen...@openatom.club>
---
Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Makefile b/Makefile
index b34a1f4c03967..f43a70413a6aa 100644
--- a/Makefile
+++ b/Makefile
@@ -1590,7 +1590,7 @@ MRPROPER_FILES += include/config include/generated \
certs/x509.genkey \
vmlinux-gdb.py \
rpmbuild \
- rust/libmacros.so rust/libmacros.dylib
+ rust/libmacros.so rust/libmacros.dylib rust/libpin_init_internal.so

# clean - Delete most, but leave enough to build external modules
#
--
2.43.0

[Dongliang Mu]

On 10/30/25 10:26 AM, chenmiao wrote:
> When I enabled Rust compilation, I wanted to clean up its output, so I
> used make cleanand make mrproper. However, I was still able to find that
> libpin_init_internal.so in the rust directory was not deleted, while
> all other corresponding outputs were cleared.

make clean and

missing one space

> If this is an intentional design, I will drop this commit.
>
> Signed-off-by: chenmiao <chen...@openatom.club>
> ---
> Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Makefile b/Makefile
> index b34a1f4c03967..f43a70413a6aa 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -1590,7 +1590,7 @@ MRPROPER_FILES += include/config include/generated \
> certs/x509.genkey \
> vmlinux-gdb.py \
> rpmbuild \
> - rust/libmacros.so rust/libmacros.dylib
> + rust/libmacros.so rust/libmacros.dylib rust/libpin_init_internal.so

I am not quite familar with this library. Rust for linux forgets to
clean this library?

Dongliang Mu

[Chen Miao]

On 10/30/2025 11:56 AM, Dongliang Mu wrote:
>
> On 10/30/25 10:26 AM, chenmiao wrote:
>> When I enabled Rust compilation, I wanted to clean up its output, so I
>> used make cleanand make mrproper. However, I was still able to find that
>> libpin_init_internal.so in the rust directory was not deleted, while
>> all other corresponding outputs were cleared.
>
> make clean and
>
> missing one space

Fixed now.

>
>> If this is an intentional design, I will drop this commit.
>>
>> Signed-off-by: chenmiao <chen...@openatom.club>
>> ---
>>   Makefile | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/Makefile b/Makefile
>> index b34a1f4c03967..f43a70413a6aa 100644
>> --- a/Makefile
>> +++ b/Makefile
>> @@ -1590,7 +1590,7 @@ MRPROPER_FILES += include/config
>> include/generated          \
>>             certs/x509.genkey \
>>             vmlinux-gdb.py \
>>             rpmbuild \
>> -          rust/libmacros.so rust/libmacros.dylib
>> +          rust/libmacros.so rust/libmacros.dylib rust/libpin_init_internal.so
>
> I am not quite familar with this library. Rust for linux forgets to clean
> this library?

I think just forget clean the one library, the other all be cleaned.

Chen Miao

[chenmiao]

When I enabled Rust compilation, I wanted to clean up its output, so I

used make clean and make mrproper. However, I was still able to find that

libpin_init_internal.so in the rust directory was not deleted, while
all other corresponding outputs were cleared.

If this is an intentional design, I will drop this commit.

Signed-off-by: chenmiao <chen...@openatom.club>
---
Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Makefile b/Makefile
index b34a1f4c03967..f43a70413a6aa 100644
--- a/Makefile
+++ b/Makefile
@@ -1590,7 +1590,7 @@ MRPROPER_FILES += include/config include/generated \
certs/x509.genkey \
vmlinux-gdb.py \
rpmbuild \
- rust/libmacros.so rust/libmacros.dylib
+ rust/libmacros.so rust/libmacros.dylib rust/libpin_init_internal.so

# clean - Delete most, but leave enough to build external modules
#

--
2.43.0

[Dongliang Mu]

On 10/30/25 4:57 PM, chenmiao wrote:
> When I enabled Rust compilation, I wanted to clean up its output, so I
> used make clean and make mrproper. However, I was still able to find that
> libpin_init_internal.so in the rust directory was not deleted, while
> all other corresponding outputs were cleared.
>
> If this is an intentional design, I will drop this commit.
>
> Signed-off-by: chenmiao <chen...@openatom.club>

Reviewed-by: Dongliang Mu <dz...@hust.edu.cn>

[chenmiao]

When I enabled Rust compilation, I wanted to clean up its output, so I
used make clean and make mrproper. However, I was still able to find that
libpin_init_internal.so in the rust directory was not deleted, while
all other corresponding outputs were cleared.

If this is an intentional design, I will drop this commit.

Reviewed-by: Dongliang Mu <dz...@hust.edu.cn>
Signed-off-by: chenmiao <chen...@openatom.club>

---
Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Makefile b/Makefile
index b34a1f4c03967..f43a70413a6aa 100644
--- a/Makefile
+++ b/Makefile
@@ -1590,7 +1590,7 @@ MRPROPER_FILES += include/config include/generated \
certs/x509.genkey \
vmlinux-gdb.py \
rpmbuild \
- rust/libmacros.so rust/libmacros.dylib
+ rust/libmacros.so rust/libmacros.dylib rust/libpin_init_internal.so

# clean - Delete most, but leave enough to build external modules
#

--
2.43.0

[Miguel Ojeda]

On Thu, Oct 30, 2025 at 10:08 AM chenmiao <chen...@openatom.club> wrote:
>
> - rust/libmacros.so rust/libmacros.dylib
> + rust/libmacros.so rust/libmacros.dylib rust/libpin_init_internal.so

I think we will need the `.dylib` too, given the other one is there
(for the macOS builds some people do -- Cc'ing Daniel and Tamir). Or
did you avoid it for some reason?

Thanks!

Cheers,
Miguel

[Chen Miao]

Hum, in fact I just seen the `.so` so I ignore the `.dylib`. I think should
add the `.dylib`, I'll make revision later.

Regard,

Chen Miao

>
> Thanks!
>
> Cheers,
> Miguel

[chenmiao]

When I enabled Rust compilation, I wanted to clean up its output, so I
used make clean and make mrproper. However, I was still able to find that
libpin_init_internal.so in the rust directory was not deleted, while
all other corresponding outputs were cleared.

Signed-off-by: chenmiao <chen...@openatom.club>
---
Makefile | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/Makefile b/Makefile
index b34a1f4c03967..29f8956f27c1a 100644
--- a/Makefile
+++ b/Makefile
@@ -1590,7 +1590,8 @@ MRPROPER_FILES += include/config include/generated \
certs/x509.genkey \
vmlinux-gdb.py \
rpmbuild \
- rust/libmacros.so rust/libmacros.dylib
+ rust/libmacros.so rust/libmacros.dylib \
+ rust/libpin_init_internal.so rust/libpin_init_internal.dylib

[Dongliang Mu]

Align with the above line

[chenmiao]

When I enabled Rust compilation, I wanted to clean up its output, so I
used make clean and make mrproper. However, I was still able to find that
libpin_init_internal.so in the rust directory was not deleted, while
all other corresponding outputs were cleared.

Signed-off-by: chenmiao <chen...@openatom.club>
---
Makefile | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/Makefile b/Makefile

index b34a1f4c03967..b38b2895e1e4a 100644

--- a/Makefile
+++ b/Makefile
@@ -1590,7 +1590,8 @@ MRPROPER_FILES += include/config include/generated \
certs/x509.genkey \
vmlinux-gdb.py \
rpmbuild \
- rust/libmacros.so rust/libmacros.dylib
+ rust/libmacros.so rust/libmacros.dylib \
+ rust/libpin_init_internal.so rust/libpin_init_internal.dylib

# clean - Delete most, but leave enough to build external modules
#

--
2.43.0

[chenmiao]

When I enabled Rust compilation, I wanted to clean up its output, so I
used make clean and make mrproper. However, I was still able to find that
libpin_init_internal.so in the rust directory was not deleted, while
all other corresponding outputs were cleared.

Dongliang Mu <dz...@hust.edu.cn>
Signed-off-by: chenmiao <chen...@openatom.club>
---

Changes in V2:
- Add the `.dylib` to mrproper files.

[Chen Miao]

PING.

[Chen Miao]

PING?

On 10/31/2025 10:32 AM, chenmiao wrote:

> When I enabled Rust compilation, I wanted to clean up its output, so I
> used make clean and make mrproper. However, I was still able to find that
> libpin_init_internal.so in the rust directory was not deleted, while
> all other corresponding outputs were cleared.
>

> Dongliang Mu <dz...@hust.edu.cn>
> Signed-off-by: chenmiao <chen...@openatom.club>
> ---
> Changes in V2:
> - Add the `.dylib` to mrproper files.

[Miguel Ojeda]

On Fri, Oct 31, 2025 at 3:32 AM chenmiao <chen...@openatom.club> wrote:
>
> When I enabled Rust compilation, I wanted to clean up its output, so I
> used make clean and make mrproper. However, I was still able to find that
> libpin_init_internal.so in the rust directory was not deleted, while
> all other corresponding outputs were cleared.
>

> Dongliang Mu <dz...@hust.edu.cn>

This line seems broken. Was this meant to be a Reviewed-by, like in v1?

> Signed-off-by: chenmiao <chen...@openatom.club>

I think in another patch/thread you mentioned this should be "Chen Miao", right?

No need for a new patch, I can fix both on apply if you agree.

Adding the relevant people to Cc (pin-init, Kbuild and Rust). And
Tamir for the `.dylib` side.

Also, I guess we could backport this:

Fixes: d7659acca7a3 ("rust: add pin-init crate build infrastructure")
Cc: sta...@vger.kernel.org

Cheers,
Miguel

[Chen Miao]

在 2026/1/19 06:30, Miguel Ojeda 写道:
> On Fri, Oct 31, 2025 at 3:32 AM chenmiao <chen...@openatom.club> wrote:
>> When I enabled Rust compilation, I wanted to clean up its output, so I
>> used make clean and make mrproper. However, I was still able to find that
>> libpin_init_internal.so in the rust directory was not deleted, while
>> all other corresponding outputs were cleared.
>>
>> Dongliang Mu <dz...@hust.edu.cn>
> This line seems broken. Was this meant to be a Reviewed-by, like in v1?

Yes, it should be `Reviewed-by`.

>> Signed-off-by: chenmiao <chen...@openatom.club>
> I think in another patch/thread you mentioned this should be "Chen Miao", right?

Yes, Please modify this to Chen Miao.

>
> No need for a new patch, I can fix both on apply if you agree.
>
> Adding the relevant people to Cc (pin-init, Kbuild and Rust). And
> Tamir for the `.dylib` side.
>
> Also, I guess we could backport this:
>
> Fixes: d7659acca7a3 ("rust: add pin-init crate build infrastructure")
> Cc: sta...@vger.kernel.org
>
> Cheers,
> Miguel

If it’s convenient for you, I think your proposal sounds great and I agree.

Thanks for the review.

Regards,

Chen Miao

[Benno Lossin]

On Sun Jan 18, 2026 at 11:30 PM CET, Miguel Ojeda wrote:
> On Fri, Oct 31, 2025 at 3:32 AM chenmiao <chen...@openatom.club> wrote:
>>
>> When I enabled Rust compilation, I wanted to clean up its output, so I
>> used make clean and make mrproper. However, I was still able to find that
>> libpin_init_internal.so in the rust directory was not deleted, while
>> all other corresponding outputs were cleared.
>>
>> Dongliang Mu <dz...@hust.edu.cn>
>
> This line seems broken. Was this meant to be a Reviewed-by, like in v1?
>
>> Signed-off-by: chenmiao <chen...@openatom.club>
>
> I think in another patch/thread you mentioned this should be "Chen Miao", right?
>
> No need for a new patch, I can fix both on apply if you agree.
>
> Adding the relevant people to Cc (pin-init, Kbuild and Rust). And
> Tamir for the `.dylib` side.

Acked-by: Benno Lossin <los...@kernel.org>

Cheers,
Benno

[Nicolas Schier]

Can you please update the typo in the subject:
- prefix: 'rust' or 'kbuild'
- s/mrporper/mrproper/?

Thanks!

Acked-by: Nicolas Schier <n...@kernel.org>

[Miguel Ojeda]

On Fri, Oct 31, 2025 at 3:32 AM chenmiao <chen...@openatom.club> wrote:
>

> When I enabled Rust compilation, I wanted to clean up its output, so I
> used make clean and make mrproper. However, I was still able to find that
> libpin_init_internal.so in the rust directory was not deleted, while
> all other corresponding outputs were cleared.
>

> Dongliang Mu <dz...@hust.edu.cn>
> Signed-off-by: chenmiao <chen...@openatom.club>

Applied to `rust-fixes` -- thanks everyone!

[ Fixed tags as discussed. Reworded slightly. - Miguel ]

Cheers,
Miguel