[RFC PATCH V3 3/4] rust/hw/core: Provide some interfaces for the GPIO device

[Chen Miao]

From: chenmiao <chen...@openatom.club>

In qdev.rs, we implemented the init_gpio_out_namedfunction, which corresponds
to the C function qdev_init_gpio_out_named. We also refactored the
init_gpio_outfunction to reuse the init_gpio_out_namedinterface.

Signed-off-by: Chen Miao <chen...@openatom.club>
---
rust/hw/core/src/qdev.rs | 12 +++++++++---
1 file changed, 9 insertions(+), 3 deletions(-)

diff --git a/rust/hw/core/src/qdev.rs b/rust/hw/core/src/qdev.rs
index c3097a284d..1d7a0b7c1a 100644
--- a/rust/hw/core/src/qdev.rs
+++ b/rust/hw/core/src/qdev.rs
@@ -17,7 +17,7 @@

pub use crate::bindings::{ClockEvent, DeviceClass, Property, ResetType};
use crate::{
- bindings::{self, qdev_init_gpio_in, qdev_init_gpio_out, ResettableClass},
+ bindings::{self, qdev_init_gpio_in, qdev_init_gpio_out_named, ResettableClass},
irq::InterruptSource,
};

@@ -399,11 +399,17 @@ fn do_init_gpio_in(
}

fn init_gpio_out(&self, pins: &[InterruptSource]) {
+ self.init_gpio_out_named(pins, "", pins.len());
+ }
+
+ fn init_gpio_out_named(&self, pins: &[InterruptSource], name: &str, n: usize) {
+ let c_name = CString::new(name).expect("gpio name new failed");
unsafe {
- qdev_init_gpio_out(
+ qdev_init_gpio_out_named(
self.upcast().as_mut_ptr(),
InterruptSource::slice_as_ptr(pins),
- pins.len() as c_int,
+ c_name.as_ptr(),
+ n as c_int,
);
}
}
--
2.51.1

[Chao Liu]

On 11/28/2025 12:35 PM, Chen Miao wrote:
> From: chenmiao <chen...@openatom.club>
>
> In qdev.rs, we implemented the init_gpio_out_namedfunction, which corresponds

init_gpio_out_namedfunction -> init_gpio_out_named function

> to the C function qdev_init_gpio_out_named. We also refactored the
> init_gpio_outfunction to reuse the init_gpio_out_namedinterface.

init_gpio_outfunction -> init_gpio_out function
init_gpio_out_namedinterface -> init_gpio_out_named interface

Thanks,
Chao

[Chao Liu]

On 11/28/2025 12:35 PM, Chen Miao wrote:

> From: chenmiao <chen...@openatom.club>
>
> In qdev.rs, we implemented the init_gpio_out_namedfunction, which corresponds
> to the C function qdev_init_gpio_out_named. We also refactored the
> init_gpio_outfunction to reuse the init_gpio_out_namedinterface.
>
> Signed-off-by: Chen Miao <chen...@openatom.club>
> ---
> rust/hw/core/src/qdev.rs | 12 +++++++++---
> 1 file changed, 9 insertions(+), 3 deletions(-)
>
> diff --git a/rust/hw/core/src/qdev.rs b/rust/hw/core/src/qdev.rs
> index c3097a284d..1d7a0b7c1a 100644
> --- a/rust/hw/core/src/qdev.rs
> +++ b/rust/hw/core/src/qdev.rs
> @@ -17,7 +17,7 @@
>
> pub use crate::bindings::{ClockEvent, DeviceClass, Property, ResetType};
> use crate::{
> - bindings::{self, qdev_init_gpio_in, qdev_init_gpio_out, ResettableClass},
> + bindings::{self, qdev_init_gpio_in, qdev_init_gpio_out_named, ResettableClass},
> irq::InterruptSource,
> };
>
> @@ -399,11 +399,17 @@ fn do_init_gpio_in(
> }
>
> fn init_gpio_out(&self, pins: &[InterruptSource]) {
> + self.init_gpio_out_named(pins, "", pins.len());

the second param should be: "unnamed-gpio-out"

becase "" just set zero value for string to memory.

see C code:

void qdev_init_gpio_out_named(DeviceState *dev, qemu_irq *pins,
const char *name, int n)
{
int i;
NamedGPIOList *gpio_list = qdev_get_named_gpio_list(dev, name);

assert(gpio_list->num_in == 0 || !name);

if (!name) { // if string is "", the name don't set "unnamed-gpio-out"
name = "unnamed-gpio-out";
}
...

Thanks,
Chao

[Chen Miao]

From: chenmiao <chen...@openatom.club>

In qdev.rs, we implemented the init_gpio_out_named function, which corresponds

to the C function qdev_init_gpio_out_named. We also refactored the
init_gpio_out function to reuse the init_gpio_out_named interface.

Signed-off-by: Chen Miao <chen...@openatom.club>
---

rust/hw/core/src/qdev.rs | 17 ++++++++++++++---
1 file changed, 14 insertions(+), 3 deletions(-)

diff --git a/rust/hw/core/src/qdev.rs b/rust/hw/core/src/qdev.rs
index c3097a284d..28da94dd0a 100644

--- a/rust/hw/core/src/qdev.rs
+++ b/rust/hw/core/src/qdev.rs
@@ -17,7 +17,7 @@

pub use crate::bindings::{ClockEvent, DeviceClass, Property, ResetType};
use crate::{
- bindings::{self, qdev_init_gpio_in, qdev_init_gpio_out, ResettableClass},
+ bindings::{self, qdev_init_gpio_in, qdev_init_gpio_out_named, ResettableClass},
irq::InterruptSource,
};

@@ -399,11 +399,22 @@ fn do_init_gpio_in(

}

fn init_gpio_out(&self, pins: &[InterruptSource]) {

+ self.init_gpio_out_named(pins, "unnamed-gpio-out", pins.len());

+ }
+
+ fn init_gpio_out_named(&self, pins: &[InterruptSource], name: &str, n: usize) {

+ let c_name = if name.is_empty() {
+ CString::new("unnamed-gpio-out").unwrap()
+ } else {
+ CString::new(name).unwrap()
+ };
+

unsafe {
- qdev_init_gpio_out(
+ qdev_init_gpio_out_named(
self.upcast().as_mut_ptr(),
InterruptSource::slice_as_ptr(pins),
- pins.len() as c_int,
+ c_name.as_ptr(),
+ n as c_int,
);
}
}

--
2.43.0