[RFC PREVIEW v2 1/5] rust: hw: core: Add the BusState of rust version

[chenmiao]

A Rust version implementation has been designed for BusState,
which will be used for the subsequent I2CBus implementation.

Signed-off-by: chenmiao <chen...@openatom.club>
---
rust/hw/core/meson.build | 1 +
rust/hw/core/src/bus.rs | 47 ++++++++++++++++++++++++++++++++++++++++
rust/hw/core/src/lib.rs | 3 +++
3 files changed, 51 insertions(+)
create mode 100644 rust/hw/core/src/bus.rs

diff --git a/rust/hw/core/meson.build b/rust/hw/core/meson.build
index 1560dd2..efcda50 100644
--- a/rust/hw/core/meson.build
+++ b/rust/hw/core/meson.build
@@ -50,6 +50,7 @@ _hwcore_rs = static_library(
[
'src/lib.rs',
'src/bindings.rs',
+ 'src/bus.rs',
'src/irq.rs',
'src/qdev.rs',
'src/sysbus.rs',
diff --git a/rust/hw/core/src/bus.rs b/rust/hw/core/src/bus.rs
new file mode 100644
index 0000000..eb23268
--- /dev/null
+++ b/rust/hw/core/src/bus.rs
@@ -0,0 +1,47 @@
+use std::{ffi::CStr, ptr::addr_of_mut};
+
+pub use bindings::BusClass;
+use common::Opaque;
+use qom::{qom_isa, IsA, Object, ObjectCast, ObjectDeref, ObjectType};
+
+use crate::{bindings, DeviceImpl};
+
+#[repr(transparent)]
+#[derive(Debug, common::Wrapper)]
+pub struct BusState(Opaque<bindings::BusState>);
+
+unsafe impl Send for BusState {}
+unsafe impl Sync for BusState {}
+
+unsafe impl ObjectType for BusState {
+ type Class = BusClass;
+ const TYPE_NAME: &'static std::ffi::CStr =
+ unsafe { CStr::from_bytes_with_nul_unchecked(bindings::TYPE_BUS) };
+}
+
+qom_isa!(BusState: Object);
+
+pub trait BusStateImpl: DeviceImpl + IsA<BusState> {}
+
+impl BusClass {
+ pub fn class_init<T: BusStateImpl>(self: &mut BusClass) {
+ self.parent_class.class_init::<T>();
+ }
+}
+
+pub trait BusStateMethods: ObjectDeref
+where
+ Self::Target: IsA<BusState>,
+{
+ fn bus_realize(&self) {
+ assert!(bql::is_locked());
+ unsafe {
+ bindings::qbus_realize(
+ self.upcast().as_mut_ptr(),
+ addr_of_mut!(util::bindings::error_fatal),
+ );
+ }
+ }
+}
+
+impl<R: ObjectDeref> BusStateMethods for R where R::Target: IsA<BusState> {}
diff --git a/rust/hw/core/src/lib.rs b/rust/hw/core/src/lib.rs
index b40801e..10cc516 100644
--- a/rust/hw/core/src/lib.rs
+++ b/rust/hw/core/src/lib.rs
@@ -13,3 +13,6 @@

mod sysbus;
pub use sysbus::*;
+
+mod bus;
+pub use bus::*;
--
2.43.0

[Chao Liu]

LGTM

Reviewed-by: Chao Liu <chao...@openatom.club>

[chenmiao]

A Rust version implementation has been designed for BusState,
which will be used for the subsequent I2CBus implementation.

Signed-off-by: chenmiao <chen...@openatom.club>
---
rust/hw/core/meson.build | 1 +

rust/hw/core/src/bus.rs | 51 ++++++++++++++++++++++++++++++++++++++++
rust/hw/core/src/lib.rs | 3 +++
3 files changed, 55 insertions(+)

create mode 100644 rust/hw/core/src/bus.rs

diff --git a/rust/hw/core/meson.build b/rust/hw/core/meson.build
index 1560dd2..efcda50 100644
--- a/rust/hw/core/meson.build
+++ b/rust/hw/core/meson.build
@@ -50,6 +50,7 @@ _hwcore_rs = static_library(
[
'src/lib.rs',
'src/bindings.rs',
+ 'src/bus.rs',
'src/irq.rs',
'src/qdev.rs',
'src/sysbus.rs',
diff --git a/rust/hw/core/src/bus.rs b/rust/hw/core/src/bus.rs
new file mode 100644

index 0000000..c87d18d
--- /dev/null
+++ b/rust/hw/core/src/bus.rs
@@ -0,0 +1,51 @@
+// Copyright 2025 HUST OpenAtom Open Source Club.
+// Author(s): Chen Miao <chen...@openatom.club>
+// SPDX-License-Identifier: GPL-2.0-or-later
+

--
2.43.0

[Zhao Liu]

On Sat, Oct 25, 2025 at 12:38:49PM +0000, chenmiao wrote:
> Date: Sat, 25 Oct 2025 12:38:49 +0000
> From: chenmiao <chen...@openatom.club>
> Subject: [RFC 1/5] rust: hw: core: Add the BusState of rust version
> X-Mailer: git-send-email 2.43.0

>
> A Rust version implementation has been designed for BusState,
> which will be used for the subsequent I2CBus implementation.
>
> Signed-off-by: chenmiao <chen...@openatom.club>
> ---
> rust/hw/core/meson.build | 1 +
> rust/hw/core/src/bus.rs | 51 ++++++++++++++++++++++++++++++++++++++++
> rust/hw/core/src/lib.rs | 3 +++
> 3 files changed, 55 insertions(+)
> create mode 100644 rust/hw/core/src/bus.rs

After a quick glance, I think this BusState is implemented quite well.

Only a few minor nits inline:

...

> +pub trait BusStateImpl: DeviceImpl + IsA<BusState> {}
> +
> +impl BusClass {
> + pub fn class_init<T: BusStateImpl>(self: &mut BusClass) {
> + self.parent_class.class_init::<T>();
> + }
> +}
> +
> +pub trait BusStateMethods: ObjectDeref

This can be named BusMethods - just like DeviceMethods did.

> +where
> + Self::Target: IsA<BusState>,
> +{
> + fn bus_realize(&self) {

"bus_" prefix is not needed:

dummy_bus.realize() is clear and enough.

> + assert!(bql::is_locked());

It's better to add safety comment from beginning (// SAFETY: xxx).

> + unsafe {
> + bindings::qbus_realize(
> + self.upcast().as_mut_ptr(),
> + addr_of_mut!(util::bindings::error_fatal),
> + );
> + }
> + }
> +}

Regards,
Zhao

[Chen Miao]

Hi Zhao,

Thanks for your review, I'll revisions based on your suggestions after all the
patches reviewed.

Regards,

Chen Miao

[Chao Liu]

On 10/27/2025 2:23 PM, Zhao Liu wrote:

> On Sat, Oct 25, 2025 at 12:38:49PM +0000, chenmiao wrote:
>> Date: Sat, 25 Oct 2025 12:38:49 +0000
>> From: chenmiao <chen...@openatom.club>
>> Subject: [RFC 1/5] rust: hw: core: Add the BusState of rust version
>> X-Mailer: git-send-email 2.43.0
>>
>> A Rust version implementation has been designed for BusState,
>> which will be used for the subsequent I2CBus implementation.
>>
>> Signed-off-by: chenmiao <chen...@openatom.club>
>> ---
>> rust/hw/core/meson.build | 1 +
>> rust/hw/core/src/bus.rs | 51 ++++++++++++++++++++++++++++++++++++++++
>> rust/hw/core/src/lib.rs | 3 +++
>> 3 files changed, 55 insertions(+)
>> create mode 100644 rust/hw/core/src/bus.rs
> After a quick glance, I think this BusState is implemented quite well.
>

Thanks, hh. Paolo also provided many good suggestions regarding the
implementation of BusState.

>Only a few minor nits inline:
>
>...
>
>> +pub trait BusStateImpl: DeviceImpl + IsA<BusState> {}
>> +
>> +impl BusClass {
>> + pub fn class_init<T: BusStateImpl>(self: &mut BusClass) {
>> + self.parent_class.class_init::<T>();
>> + }
>> +}
>> +
>> +pub trait BusStateMethods: ObjectDeref
>
>This can be named BusMethods - just like DeviceMethods did.
>

Thank you for pointing this out. I’ve noted the Rust In QEMU docs also include
relevant coding styles, and we’ll update the related naming conventions in the
next version.

>> +where
>> + Self::Target: IsA<BusState>,
>> +{
>> + fn bus_realize(&self) {
>
>"bus_" prefix is not needed:
>
>dummy_bus.realize() is clear and enough.
>

Ok, qbus_realize() is internally called by the C part during object
instantiation, so there is indeed no need for additional exporting.

>> + assert!(bql::is_locked());
>
>It's better to add safety comment from beginning (// SAFETY: xxx).
>

Get~

>> + unsafe {
>> + bindings::qbus_realize(
>> + self.upcast().as_mut_ptr(),
>> + addr_of_mut!(util::bindings::error_fatal),
>> + );
>> + }
>> + }
>> +}
>
>Regards,
>Zhao
>

Thanks,
Chao