libpano13-2.9.20 unit tests fail on FreeBSD

29 views
Skip to first unread message

Robert Clausecker

unread,
Sep 12, 2021, 2:57:54 PMSep 12
to hugin and other free panoramic software
While working on updating the FreeBSD port for graphics/libpano13 to 2.9.20 (cf. FreeBSD PR #258354), FreeBSD contributor Daniel Engbert encountered a series of unit test failures.  After converting from TIFF to PSD, the image files no longer match the reference files.  Full test logs can be found in this paste: https://paste.debian.net/1211512/

Are these test failures known or benign?  If not, please let us know what we can do to help you debug the issue further.

Yours,
Robert Clausecker

Bruno Postle

unread,
Sep 12, 2021, 4:59:02 PMSep 12
to hugin and other free panoramic software
The tests seem to have been broken since this commit, which suggests a
problem with the test suite:

changeset: 844:d71285db01f0
user: tmodes <tmo...@users.sf.net>
date: Thu Sep 06 17:45:24 2018 +0200
files: version.h
description: Bump up some more version numbers

diff -r 415deb81168f -r d71285db01f0 version.h
--- a/version.h Sun Mar 25 10:45:16 2018 +0100
+++ b/version.h Thu Sep 06 17:45:24 2018 +0200
@@ -31,13 +31,13 @@
#define VERS2 0x00

//version of preferences file, used to verify data
-#define PREF_VERSION "2.9.19 "
+#define PREF_VERSION "2.9.20 "

// String style of global version
-#define VERSION "2.9.19 "
+#define VERSION "2.9.20 "

// Numeric style of global version, same as VERSION with more precision
-#define PTVERSION_FILEVERSIONNUMBER 2,9,19,0
+#define PTVERSION_FILEVERSIONNUMBER 2,9,20,0
#define PTVERSION_NAME_LONG "LongVersion"
#define LONGVERSION VERSION ", Copyright (c) 1998-2006, H. Dersch,
d...@fh-furtwangen.de"

Robert Clausecker

unread,
Sep 12, 2021, 6:04:48 PMSep 12
to hugin and other free panoramic software
Hi Bruno,

Thanks for the quick response.  We'll go ahead and update the port without worrying too much about the failed unit tests.

Yours,
Robert Clausecker

T. Modes

unread,
Sep 14, 2021, 11:54:48 AMSep 14
to hugin and other free panoramic software
bruno...@gmail.com schrieb am Sonntag, 12. September 2021 um 22:59:02 UTC+2:
The tests seem to have been broken since this commit, which suggests a
problem with the test suite:

It is fixed now. The reference files for the tests contains also the version number. So this numbers need also be updated.

The tests should pass now again.

Reply all
Reply to author
Forward
0 new messages