Missing defines for Exiv2 on linux

20 views
Skip to first unread message

Kornel Benko

unread,
Jan 11, 2008, 6:22:27 AM1/11/08
to hugin-ptx

At least this made it compile again.
As I could see, in CMakeModules/FindExiv2.cmake, EXIV2_FOUND was created.

Kornel
--
Kornel Benko
Kornel...@berlin.de

hugin_config.h.in.cmake.diff
SrcPanoImage.h.diff
signature.asc

Bruno Postle

unread,
Jan 11, 2008, 4:39:38 PM1/11/08
to Hugin ptx
On Fri 11-Jan-2008 at 12:22 +0100, Kornel Benko wrote:
>
>At least this made it compile again.
>As I could see, in CMakeModules/FindExiv2.cmake, EXIV2_FOUND was created.

The fix Pablo commited doesn't do it for me with fedora 8, current
SVN (2623) still doesn't compile:

-- Found Exiv2 release >= 0.12
-- Found Exiv2: /usr/lib/libexiv2.so

[snip]

/usr/bin/c++ -Dhuginbase_EXPORTS -O2 -g -fPIC
-I/usr/include/OpenEXR -I/home/bruno/src/hugin/hugin/trunk/src
-I/home/bruno/src/hugin/hugin/trunk/src/hugin_base
-I/home/bruno/src/hugin/hugin/trunk/src/foreign
-I/home/bruno/src/hugin/hugin/trunk/src/foreign/vigra -o
src/hugin_base/CMakeFiles/huginbase.dir/panodata/SrcPanoImage.o -c
/home/bruno/src/hugin/hugin/trunk/src/hugin_base/panodata/SrcPanoImage.cpp
/home/bruno/src/hugin/hugin/trunk/src/hugin_base/panodata/SrcPanoImage.h:412:
error: ‘Exiv2’ has not been declared

--
Bruno

Seb Perez-D

unread,
Jan 11, 2008, 4:55:01 PM1/11/08
to hugi...@googlegroups.com
On Jan 11, 2008 10:39 PM, Bruno Postle <br...@postle.net> wrote:

The fix Pablo commited doesn't do it for me with fedora 8, current
SVN (2623) still doesn't compile:

   /home/bruno/src/hugin/hugin/trunk/src/hugin_base/panodata/SrcPanoImage.cpp
   /home/bruno/src/hugin/hugin/trunk/src/hugin_base/panodata/SrcPanoImage.h:412:
   error: 'Exiv2' has not been declared

Same here, 2623 doesn't compile (Ubuntu 7.04)

Seb

Pablo dAngelo

unread,
Jan 11, 2008, 5:51:26 PM1/11/08
to hugi...@googlegroups.com
Hi all,

Seb wrote:

Should be fixed in SVN. If Exiv2 is found, it will now be used automatically.
If it isn't the old jhead code should still work fine.

ciao
Pablo
_______________________________________________________________________
Jetzt neu! Schützen Sie Ihren PC mit McAfee und WEB.DE. 30 Tage
kostenlos testen. http://www.pc-sicherheit.web.de/startseite/?mc=022220

Gerry Patterson

unread,
Jan 11, 2008, 6:27:02 PM1/11/08
to hugi...@googlegroups.com




1. jpegs directly from the camera vs jpegs created from raw converters aren't allways the same size.  At least the ones from my Canon 40D converted with UFraw are not.  I saw a slight difference in the crop factor between the jpegs and the tiff files.

2. exiftool doesn't report the EXIF image size properly on TIFF files generated by UFraw.  To be clear, I started with a raw file and used UFRaw to create a 16bit tiff.  This new tiff does not have any EXIF as UFraw does not support this (yet).  So, I used exiftool to copy the EXIF data from the RAW file to the TIFF file (exiftool -TagsFromFile <RAWFILE> -x Orientation <TIFFFile>).  Using exiftool to then view the data reports an incorrect size--much smaller.  However, exiv2 reports the correct size on the same file.  Which is why Hugin works fine when reading EXIF data from said TIFF file.  I haven't tracked down yet what is happening in exiftool.  Perhaps I need to update it.

There is still more work to do.  The "Load EXIF" data button on the "Camera Lens panel" does not work with anything other than jpeg files.   Assuming what is currently available is working properly, that is what I will tackle next.


Best Regards and again, sorry for the earlier mistake.

- Gerry

Bob Bright

unread,
Jan 12, 2008, 7:02:24 AM1/12/08
to hugi...@googlegroups.com
On Fri, 2008-01-11 at 17:27 -0600, Gerry Patterson wrote:
1. jpegs directly from the camera vs jpegs created from raw converters aren't allways the same size.  At least the ones from my Canon 40D converted with UFraw are not.  I saw a slight difference in the crop factor between the jpegs and the tiff files.

It's because your camera's internal JPEG converter crops the edges off the raw image data, whereas dcraw and derivatives use all of the available data, right to the edge of the sensor.  (See the answer to "Why are dcraw output images larger than camera JPEGs?" on Dave Coffin's dcraw page.  Note that Canon's own raw conversion software also crops the edges, despite the fact that "C code is cheap"!)


2. exiftool doesn't report the EXIF image size properly on TIFF files generated by UFraw.  To be clear, I started with a raw file and used UFRaw to create a 16bit tiff.  This new tiff does not have any EXIF as UFraw does not support this (yet).  So, I used exiftool to copy the EXIF data from the RAW file to the TIFF file (exiftool -TagsFromFile <RAWFILE> -x Orientation <TIFFFile>).  Using exiftool to then view the data reports an incorrect size--much smaller.  However, exiv2 reports the correct size on the same file.  Which is why Hugin works fine when reading EXIF data from said TIFF file.  I haven't tracked down yet what is happening in exiftool.  Perhaps I need to update it.

Your 40D probably generates raw files with embedded JPEGs (see here).   For .CR2 files produced by my 350D, exiftool reports the following:

  ...
Image Height                    : 1024
Image Width                     : 1536
  ...
Canon Image Width               : 3456
Canon Image Height              : 2304
  ...

The first dimensions are for the embedded JPEG, the second are for the raw image.  Or rather, the second dimensions are for the raw image after it's cropped by Canon's internal or external converter.  UFRaw's output is actually 3474x2314, which is exactly what exiv2 reports, even if I copy over the EXIF data from the raw file.

Summary: You don't need to update your exiftool.  What's happening is that exiv2 is clever enough to recognize that the real dimensions of your TIFF files are not what's reported in the EXIF data, and it's delivering the correct dimensions to hugin.

BBB

--
Bob Bright
Vancouver Island Digital Imaging
(250) 704-0051
BBBr...@VictoriaVR.ca
http://VictoriaVR.ca


Reply all
Reply to author
Forward
0 new messages