PATCH: Replace backslashes in Windows makefile

[Lukáš Jirkovský]

Hello,
since 0.8 is out I think I can bring back some of my patches. This one
changes backslash delimiter (\) on windows to forward slash (/) in
makefile. It should fix test target on windows. Because I don't have
access windows build machine I kindly ask for testing.

Lukáš

[T. Modes]

Lukáš Jirkovský schrieb:

Hi Lukas,

I tested your patch. But the test target does not work, I'm getting

make -f test.pto.mk test
Checking nona...
abnormal program termination
C:\Users\Thomas\AppData\Local\Temp\make21323.sh: fork failed: no error
[1]
d:\src\build\INSTALL\FILES\bin\make: [test] Error 1 (ignored)
Checking enblend...
abnormal program termination
C:\Users\Thomas\AppData\Local\Temp\make21325.sh: fork failed: no error
[1]
d:\src\build\INSTALL\FILES\bin\make: [test] Error 1 (ignored)
Checking enfuse...[OK]
Checking hugin_hdrmerge...
abnormal program termination
C:\Users\Thomas\AppData\Local\Temp\make21329.sh: fork failed: no error
[1]
d:\src\build\INSTALL\FILES\bin\make: [test] Error 1 (ignored)
Checking exiftool...[OK]

When I running make several times the crash occurs on different
programs.

Thomas

[Lukáš Jirkovský]

2009/7/18 T. Modes <Thomas...@gmx.de>:

Oh. Thanks for testing. Did all backslashes been replaced with forward
slashes? In fact I've never compiled hugin with this patch. I've only
experimented with hugin's makefile on windows machine and it seemed to
begin work after replacing slashes. Maybe it can be GNU make related.
I think that windows bundle contains some very old GNU Make version.
I've tested it with make 3.81 from http://gnuwin32.sourceforge.net

Lukáš

[T. Modes]

Lukáš Jirkovský schrieb:

> Oh. Thanks for testing. Did all backslashes been replaced with forward
> slashes? In fact I've never compiled hugin with this patch. I've only
> experimented with hugin's makefile on windows machine and it seemed to
> begin work after replacing slashes. Maybe it can be GNU make related.
> I think that windows bundle contains some very old GNU Make version.
> I've tested it with make 3.81 from http://gnuwin32.sourceforge.net
>
> Lukáš

The backslashes has been replaced for the programs and all variables
with _SHELL suffix.
Some variables like PROJECT_FILE, INPUT_IMAGE_1 and INPUT_IMAGES uses
still backslashes.

The windows version is using make from http://unxutils.sourceforge.net/
I think the problem is not the make file or make. The error arises
from sh.exe (a zsh shell which is in unxutils), which seems to have
trouble with the redirection.

Thomas

[Yuval Levy]

T. Modes wrote:
>
> Lukáš Jirkovský schrieb:

>> I've tested it with make 3.81 from http://gnuwin32.sourceforge.net
>

> The windows version is using make from http://unxutils.sourceforge.net/

problem with unxutils is that the last commit was on Oct 15 2003. To me
it looks like a ticking legacy bomb and we need to move on to keep
Windows support in the future.

<https://sourceforge.net/projects/unxutils/develop>

gnuwin32 does not use one of SF's VCS but at least there are regular
updates and binaries (32bit) and sources are all available at

<http://sourceforge.net/projects/gnuwin32/files/>

I guess our 64bit Windows friends will be able to build 64bit versions
of these.

I started to look into replacing unxutils with gnuwin32 but all of this
is on my Windows workstation which I have not accessed for two weeks.
And this is low on my priorities list for now.

Yuv