missing keyboard shortcuts in os/x and linux

[dex Otaku]

I use Hugin frequently under Windows, OS/X and in linux.

I noticed the lack of keyboard shortcuts that exist in the Windows
version [all except the ones listed in the menus] some time ago with
0.7.0. Now I'm using 0.8.0 on the Mac at work and it still lacks the
shortcuts.

Am I missing something, or is there an actual reason why the workflow
is crippled this way everywhere but on Windows? It takes 2-4x longer
to do everything on the Mac or in linux.

D

[Seb Perez-D]

On Tue, Sep 15, 2009 at 03:26, dex Otaku <dexo...@gmail.com> wrote:
> I noticed the lack of keyboard shortcuts that exist in the Windows
> version [all except the ones listed in the menus] some time ago with
> 0.7.0.  Now I'm using 0.8.0 on the Mac at work and it still lacks the
> shortcuts.

Which shortcuts are you missing in Linux? I have several, so I would
be glad to know which additional ones there are.

F to finetune a control point pair
A to add the pair
G to generate "fixed" control points
Del to delete a control point
Ctrl T to optimize
Ctrl S to save

Cheers,

Seb

[dex Otaku]

> Which shortcuts are you missing in Linux? I have several, so I would
> be glad to know which additional ones there are.
>
> F to finetune a control point pair
> A to add the pair
> G to generate "fixed" control points
> Del to delete a control point
> Ctrl T to optimize
> Ctrl S to save
>

I haven't tried the linux 0.8.0 yet but last I tried using 0.7.0 there
[about a month ago] it was the same as under OS/X; ctrl+s to save
worked, I hadn't tried ctrl+t, none of the other keys did [including F
A Del G as you listed above] .. the keys I use most are in the control
point editor - 0 for "fit in view", 1 for pixels 1:1, f for fine-tune,
a for add, Del to delete, et al. Without these the control point
editor is practically torture to use, requiring constant use of the
mouse to do everything [this is setting aside that the apple "mighty
mouse" itself is torture to use].

Another thing I've noticed is the differences in behaviour in the
control point editor between windows and linux/mac as well - ctrl
+mouse and shift+mouse are next to useless. ctrl+mouse = move the pic
- under windows, it moves fairly consistently in a relative
positioning fashion [deciding occasionally to jump randomly]; under
linux/mac it moves consistently in an absolute positioning fashion
[meaning moving around when zoomed at 1:1 is almost impossible unless
the screen resolution is as large as the pic]. I would love to see
someone implement a simple "hand" tool like in Photoshop here.

[Seb Perez-D]

On Tue, Sep 15, 2009 at 10:57, dex Otaku <dexo...@gmail.com> wrote:
> I haven't tried the linux 0.8.0 yet but last I tried using 0.7.0 there

> [about a month ago] it was the same as under OS/X. [...]

> Another thing I've noticed is the differences in behaviour in the
> control point editor between windows and linux/mac as well - ctrl
> +mouse and shift+mouse are next to useless. ctrl+mouse = move the pic
> - under windows, it moves fairly consistently in a relative
> positioning fashion [deciding occasionally to jump randomly]; under
> linux/mac it moves consistently in an absolute positioning fashion
> [meaning moving around when zoomed at 1:1 is almost impossible unless

> the screen resolution is as large as the pic]. [...]

Strange, because it works for me - and I would imagine for other linux
users as well, and I'm pretty sure for OS/X users too.

Can you give more information about:
* your linux distribution
* your window manager
* your international setting (are you under a particular keyboard?
non-western character set?)
* are you using Hugin in English or in another language?
* whether you compiled Hugin yourself
* your graphic/video card
* the amount of RAM you have
* other information that may help diagnose what your computer has.

Cheers,

Seb

[dex Otaku]

> Strange, because it works for me - and I would imagine for other linux
> users as well, and I'm pretty sure for OS/X users too.
>
> Can you give more information about:
> * your linux distribution

Ubuntu 7.10, 8.04, 8.10, 9.04

> * your window manager
Both gnome and KDE

> * your international setting (are you under a particular keyboard?
> non-western character set?)

Both standard US-105 and Dvorak-RH layouts, locale is Canada, used
under both US, UK, and Canadian English.

> * are you using Hugin in English or in another language?

English.

> * whether you compiled Hugin yourself

Nay. Standard packages available through the Ubuntu repos.

> * your graphic/video card
Nvidia FX5200 and GForce 7000-something
ATI X300 and X300 mobile

> * the amount of RAM you have

Between 1-4GB depending on the machine [talking about 3 desktops and a
notebook, noting the behavior is the same in OS/X on 2 macs]

> * other information that may help diagnose what your computer has.

Nothing else that would seem related or relevant.

[dex Otaku]

Correction: same issue under Ubuntu 8.04 having compiled one of the
0.8.0 RCs a while back.

[rok senk]

Hi,

I compiled hugin recently on Arch linux. For me all shortcuts work,
except for delete key. I use slovenian keyboard.

[Seb Perez-D]

On Tue, Sep 15, 2009 at 15:02, rok senk <rok....@gmail.com> wrote:
> I compiled hugin recently on Arch linux. For me all shortcuts work,
> except for delete key. I use slovenian keyboard.

For the delete key to work, you have to have selected a control point
pair. I assume this is the case?

[rok senk]

> For the delete key to work, you have to have selected a control point
> pair. I assume this is the case?

Yes, I select control pair first.

Delete key worked before hugin 7.0 for me, but not since.

[jzander]

> I use Hugin frequently under Windows, OS/X and in linux.
>
> I noticed the lack of keyboard shortcuts that exist in the Windows
> version [all except the ones listed in the menus]

That should be this bug (more or less a problem inside of the mac-
branch of wxwidgets):
https://sourceforge.net/tracker/?func=detail&atid=550441&aid=2125481&group_id=77506

Cheers
Johannes

[Bruno Postle]

On Tue 15-Sep-2009 at 06:20 -0700, rok senk wrote:
>
>Delete key worked before hugin 7.0 for me, but not since.

Same here, the Delete key hasn't worked in the Control Points tab
for a long time.

--
Bruno

[Seb Perez-D]

Same here - but it works in the control points window (the one that
you raise with F3... ;-)

S

[dex Otaku]

> That should be this bug (more or less a problem inside of the mac-

> branch of wxwidgets):https://sourceforge.net/tracker/?func=detail&atid=550441&aid=2125481&...

Thanks, jzander. Perhaps I should brave building it on my own.

[Milan Knížek]

Seb Perez-D píše v St 16. 09. 2009 v 00:24 +0200:

Same here.

Was there a bug open for this "del" key nonfuctionality in Control
Points editing tab?

I have found only a significantly old one:
https://sourceforge.net/tracker/index.php?func=detail&aid=781374&group_id=77506&atid=550444

regards,

Milan Knizek
knizek (dot) confy (at) volny (dot) cz
http://www.milan-knizek.net - About linux and photography (Czech
language only)

[AKS-Gmail-IMAP]

This may be because there are all sorts of keyboards. There are two
keys labeled delete on a extended white iMac keyboard. It is the
delete key (the "forwards" delete ) under the help key on this
keyboard that deletes a control point in the Control Points tab. The
delete key above the \ key does not delete a point. The older colored
iMac keyboard has only the delete key above the \ key and that key
does not delete a control point when using that keyboard. In each
keyboard it is the "backwards" delete key that does not delete a
control point for OS X Hugin. I believe the newer iBooks lack the
forwards delete key but have the ability to forwards delete with a key
combination. Perhaps that key combination (option delete maybe?) is
what will delete a control point.

By the way, F3 has always worked for me on OS X and Windows setups.

Allan

> --
> You received this message because you are subscribed to the Google
> Groups "hugin and other free panoramic software" group.
> A list of frequently asked questions is available at: http://wiki.panotools.org/Hugin_FAQ
> To post to this group, send email to hugi...@googlegroups.com
> To unsubscribe from this group, send email to hugin-ptx+...@googlegroups.com
> For more options, visit this group at http://groups.google.com/group/hugin-ptx

[ArAgost]

this may need some reconsidering, since under OS X it's common UI
pracice to delete things with backspace

> >https://sourceforge.net/tracker/index.php?func=detail&aid=781374&grou...

>
> > regards,
>
> > Milan Knizek
> > knizek (dot) confy (at) volny (dot) cz

> >http://www.milan-knizek.net- About linux and photography (Czech

[Milan Knížek]

Bruno Postle píše v Út 15. 09. 2009 v 23:09 +0100:

Since it is really a bit annoying, I tried to debug the code and found
two things: (1) any keyboard press is ignored in CP Editor Panel and (2)
"Del" key is made available only for MS Windows.

Ad 1.
When mouse-clicked in Control Point Editor Panel (the list of control
points below the left and right image in CP tab), no shortcut actually
works. It does not matter if some control point pair is selected or not.

E.g. on pressing "f" key, no fine-tuning takes place, the debugger shows
only:

TRACE 17:32:48.614777
(/home/modeluser/src/hugin/src/hugin1/hugin/CPEditorPanel.cpp:1931)
OnKeyUp(): key:70

When moving mouse outside the CP editor panel, say over the left or
right image and pressing "h" key, the debugger shows both down and up
keys (I have chosen the non-existing shortcut to have a shorter output
of the debugger):

TRACE 17:34:27.413057
(/home/modeluser/src/hugin/src/hugin1/hugin/CPImageCtrl.cpp:1379)
OnMouseEnter(): MOUSE Enter, setting focus
TRACE 17:34:27.418962
(/home/modeluser/src/hugin/src/hugin1/hugin/CPImageCtrl.cpp:1137)
update(): edit state:1
TRACE 17:34:29.178220
(/home/modeluser/src/hugin/src/hugin1/hugin/CPImageCtrl.cpp:1333)
OnKeyDown(): key:72
TRACE 17:34:29.179143
(/home/modeluser/src/hugin/src/hugin1/hugin/CPImageCtrl.cpp:1229)
OnKey(): OnKey, key:104
TRACE 17:34:29.316542
(/home/modeluser/src/hugin/src/hugin1/hugin/CPEditorPanel.cpp:1931)
OnKeyUp(): key:72


This looks like a bug, since the user may want to delete or fine tune
control points manually selected in the CP Editor Panel.


Ad 2.
The code of src/hugin1/hugin/CPImageCtrl.cpp shows:
1303 case WXK_DOWN:
1304 #ifdef __WXMSW__
1305 case WXK_DELETE:
1306 #endif
1307 forward = true;

Getting rid of the #ifdef and #endif lines seems to solve the problem
with ignored DEL key. At least on Ubuntu 9.10.

I believe there was a reason why the WXK_DELETE key code was defined
only for WXMSW, the question is whether the reason is still valid now or
not.


Regards,

Milan Knizek
knizek (dot) confy (at) volny (dot) cz

http://www.milan-knizek.net - About linux and photography (Czech
language only)

[Bruno Postle]

On Tue 17-Nov-2009 at 17:59 +0100, Milan Knížek wrote:
>
>The code of src/hugin1/hugin/CPImageCtrl.cpp shows:
>1303 case WXK_DOWN:
>1304 #ifdef __WXMSW__
>1305 case WXK_DELETE:
>1306 #endif
>1307 forward = true;
>
>Getting rid of the #ifdef and #endif lines seems to solve the problem
>with ignored DEL key. At least on Ubuntu 9.10.
>
>I believe there was a reason why the WXK_DELETE key code was defined
>only for WXMSW, the question is whether the reason is still valid now or
>not.

This #ifdef was added in svn 1879:

2007-01-24 dangelo
* [r1879] src/hugin/CPImageCtrl.cpp: bugfix: keys in Control point
editor should work again

This is probably when the delete key stopped working for me on
Linux. Removing the #ifdef fixes it here (wx-2.8.10).

It would be interesting to see if removing the #ifdef is ok on OS X
too.

--
Bruno

[Bruno Postle]

Hi Milan has this fix for the Del key in the Control Points tab not
working for Linux users (patch attached). Can somebody confirm that
this doesn't break anything on OS X.

--
Bruno

[skip]

Bruno,

Updated my code to revision 4737, built and the delete key worked fine
in CP Editor (before patch)
Applied patch, rebuilt and retested CP Editor, and the delete key
still worked.

I think we're good.

--skip
>
>
>
>  control-point-tab-delete.patch
> < 1KViewDownload

[Harry van der Wolf]

Hi Skip,

You just beat me at it! Great!

Harry

2009/12/1 skip <sga...@comcast.net>

[bruno.postle]

On Dec 1, 10:21 am, Harry van der Wolf <hvdw...@gmail.com> wrote:
>
> You just beat me at it! Great!

Would you like to commit it to the trunk and then merge the fix to the
2009.4 branch? I can't do it from here.

--
Bruno

[Harry van der Wolf]

2009/12/1 bruno.postle <bruno...@googlemail.com>

On Dec 1, 10:21 am, Harry van der Wolf <hvdw...@gmail.com> wrote:
>
> You just beat me at it! Great!

Would you like to commit it to the trunk and then merge the fix to the
2009.4 branch? I can't do it from here.

--

Bruno

 

I will do that tonight.

 

Harry

[AKS-Gmail-IMAP]

Are we sure we are referring to the correct keyboard key? 

The Delete key, not the Backspace key, already works to delete control points in OS X. I understood that the problem is that the Backspace key, which is labeled as the Delete key on older keyboards ( ones that are not the expanded layout ) has in the past been the traditional "Delete" key and is therefore expected to function as Delete in this instance. The Delete key on the older Apple keyboard is this way. The current Hugin does not delete control points points when using this keyboard. 

Allan

[Bruno Postle]

On Tue 01-Dec-2009 at 19:50 -0600, AKS-Gmail-IMAP wrote:
>Are we sure we are referring to the correct keyboard key?
>
>The Delete key, not the Backspace key, already works to delete control
>points in OS X. I understood that the problem is that the Backspace
>key, which is labeled as the Delete key on older keyboards ( ones that
>are not the expanded layout ) has in the past been the traditional
>"Delete" key and is therefore expected to function as Delete in this
>instance.

This will need a separate fix, the bugfix here enabled the Del key
on Linux - Which hasn't worked for a long time. The call for
testers was to check that the fix didn't break any OS X behaviour,
the patch itself didn't change anything for Windows users.

--
Bruno