enblend patch

50 views
Skip to first unread message

Wirz

unread,
Dec 3, 2013, 9:18:31 AM12/3/13
to hugi...@googlegroups.com
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi,

[I'm not sure if this is the right place to post. Please direct my to a
different place if appropriate.]

I was trying to trace down a bug in enblend. I didn't find the one I
was looking for but another one. Not sure if it causes anyone grief but
it should probably be fixed anyway. My suggested (most simple)
patch is attached.

While I'm at it: How do I compile enblend in a way that valgrind
displays line numbers? I tried to add '-g3' to the CXXFLAGS is
configure.in but that doesn't do the trick.

cheers, lukas

- --
Do not believe the naysayers who say it cannot be done.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.12 (GNU/Linux)
Comment: Using GnuPG with Icedove - http://www.enigmail.net/

iEYEARECAAYFAlKd6CYACgkQ1m2kmG8CIy0pVQCgmeFhvHXeyfyddTr4gNn6GYld
gAUAoMmSL+u5PD/EVTVGmCVNFhitwkqR
=nm9u
-----END PGP SIGNATURE-----
patch

cspiel

unread,
Dec 3, 2013, 10:43:32 AM12/3/13
to hugi...@googlegroups.com
Lukas -


On Tuesday, December 3, 2013 3:18:31 PM UTC+1, lukas wrote:
[I'm not sure if this is the right place to post.  Please direct my to a
different place if appropriate.]

    It reached the right guy, don't worry.

 
Not sure if it causes anyone grief but
it should probably be fixed anyway.  My suggested (most simple)
patch is attached.

    THX!  You are blessed with very sharp eyes.  My guess why
this bug never has been triggered yet is that std::vector::capacity()
has been larger than then number of layers in a single input file.

Please contact me via e-mail so that I can give correct credit to
you when committing the patch.
 

While I'm at it:  How do I compile enblend in a way that valgrind
displays line numbers?  I tried to add '-g3' to the CXXFLAGS is
configure.in but that doesn't do the trick.

    If you are using gcc(1) `-g' already generates enough info.

For cases like yours when you quickly wnat to add some new
options we have created a plethora of make(1) flags all starting
with `EXTRA'.  Grep "README" for EXTRA.

For valgrind(1) in memcheck mode (again assuming gcc(1))
    EXTRACXXFLAGS='-fno-inline -O2'
works well and does not slow down execution too much.

/Chris

Reply all
Reply to author
Forward
0 new messages