[PATCH] Install MIME type icon into the hicolor theme

60 views
Skip to first unread message

Chris Mayo

unread,
May 7, 2020, 2:13:23 PM5/7/20
to hugin and other free panoramic software
Most Hugin icons are installed into the hicolor theme but the MIME type icon is still going into the defunct gnome theme.
The attached patch changes that and removes the gnome-mime- prefix from the icon filename.

For me this appears to fix the icon not displaying for .pto files in GNOME Files (nautilus).

The patch also updates this filename in artwork-src/update_artwork.sh, I only found that with grep and haven't tested it.

Chris

mimeicon.patch

T. Modes

unread,
May 24, 2020, 7:36:27 AM5/24/20
to hugin and other free panoramic software
Hi Chris,


Am Donnerstag, 7. Mai 2020 20:13:23 UTC+2 schrieb Chris Mayo:
Most Hugin icons are installed into the hicolor theme but the MIME type icon is still going into the defunct gnome theme.
The attached patch changes that and removes the gnome-mime- prefix from the icon filename.

Thanks for the patch.
But before applying I would like to hear from somebody else that it works also for him.

So a questions to other Linux user: can you confirm that the patch works also for you? Or does it break on other distros?

Thomas

Kornel Benko

unread,
May 24, 2020, 8:11:45 AM5/24/20
to hugi...@googlegroups.com
Am Sun, 24 May 2020 04:36:27 -0700 (PDT)
schrieb "T. Modes" <Thomas...@gmx.de>:
I use 'mate', which is built over gnome. No problems with the patch.

Kornel

T. Modes

unread,
May 25, 2020, 1:59:11 PM5/25/20
to hugin and other free panoramic software
Hi,

thanks for testing, Kornel and the patch, Chris,
I committed the changes to the repository.

Thomas

akl...@gmail.com

unread,
Dec 18, 2020, 4:42:38 AM12/18/20
to hugin and other free panoramic software
On Monday, 25 May 2020 at 18:59:11 UTC+1 T. Modes wrote:
 
Appears that the file rename got applied, but the installation directory is still:
${DATADIR}/icons/gnome/48x48/mimetypes

not:
${DATADIR}/icons/hicolor/48x48/mimetypes



T. Modes

unread,
Dec 18, 2020, 11:06:35 AM12/18/20
to hugin and other free panoramic software
akl schrieb am Freitag, 18. Dezember 2020 um 10:42:38 UTC+1:
On Monday, 25 May 2020 at 18:59:11 UTC+1 T. Modes wrote:
 
Appears that the file rename got applied, but the installation directory is still:

Fixed in repository. Nobody complained in a half year or during the release cycle. So it seems not critical.
Reply all
Reply to author
Forward
0 new messages