Failed to build latest hg version: undefined reference to symbol 'LZ4_decompress_safe_continue'

[Jean-Luc Coulon (f5ibh)]

Hi,

I tried to build the latest hg version and I got the following:

[...]

[ 71%] Built target align_image_stack
[ 71%] Linking CXX executable cpfind
/usr/bin/ld: CMakeFiles/cpfind.dir/PanoDetectorLogic.cpp.o: undefined reference to symbol 'LZ4_decompress_safe_continue'
/usr/bin/ld: //lib/x86_64-linux-gnu/liblz4.so.1: error adding symbols: DSO missing from command line
collect2: error: ld returned 1 exit status
make[2]: *** [src/hugin_cpfind/cpfind/CMakeFiles/cpfind.dir/build.make:206: src/hugin_cpfind/cpfind/cpfind] Error 1
make[1]: *** [CMakeFiles/Makefile2:1458: src/hugin_cpfind/cpfind/CMakeFiles/cpfind.dir/all] Error 2
make[1]: *** Waiting for unfinished jobs....
[ 71%] Linking CXX shared library libhuginbasewx.so
[...]

I run debian/sid and I've lzy installed.

Any clue / advice ?

Regards

Jean-Luc

[Andreas Metzler]

Add
https://salsa.debian.org/debian-phototools-team/hugin/raw/unstable/debian/patches/20_flann_find_pkg-config.patch

cu And- need to forward this -reas
--
`What a good friend you are to him, Dr. Maturin. His other friends are
so grateful to you.'
`I sew his ears on from time to time, sure'

[T. Modes]

Hi Andreas,

Am Donnerstag, 1. November 2018 14:46:53 UTC+1 schrieb Andreas Metzler:

Add
https://salsa.debian.org/debian-phototools-team/hugin/raw/unstable/debian/patches/20_flann_find_pkg-config.patch

Can we use the patch in our repository?

Thomas

[Andreas Metzler]

Yes, I think so.

For the archives a little bit of background:

flann bundles liblz. Flann not only exposes lz4 in its header but also
flann-using packages directly call lz4-functions when using flann
functions. Debian has patched flann to use the system liblz (both
because bundled libraries suck when there is a security update and
because it caused breakage.). Now a package using flann needs to also
link against the system liblz.

When using pkgconfig this just works. Which is what the patch does.

cu Andreas

[T. Modes]

Hi Andreas

Am Donnerstag, 1. November 2018 19:51:18 UTC+1 schrieb Andreas Metzler:

> Can we use the patch in our repository?

Yes, I think so.

Thanks for the patch and the explanation.

I committed a slightly modified version so that it works also on Windows.

Please report back if I broke something.

Thomas

[Andreas Metzler]

Thanks. I can confirm that the comitted version works for me.