libpano13 PTtiff2psd testsuite error on multiple archs

[Andreas Metzler]

Hello,

as a side effect of switching to cmake I have found that the PTtiff2psd
tests fail on s390x, hppa, powerpc ppc64 and sparc64. (This test was not
run in the autotools buildsystem)

------------
(sid_s390x-dchroot)ametzler@zelenka:~/PANO/libpano13-2.9.21/obj$ ctest --rerun-failed --output
-on-fail --extra-verbose
UpdateCTestConfiguration from :/home/ametzler/PANO/libpano13-2.9.21/obj/DartConfiguration.tcl
UpdateCTestConfiguration from :/home/ametzler/PANO/libpano13-2.9.21/obj/DartConfiguration.tcl
Test project /home/ametzler/PANO/libpano13-2.9.21/obj
Constructing a list of tests
Done constructing a list of tests
Updating test list for fixtures
Added 0 tests to meet fixture requirements
Checking test dependency graph...
Checking test dependency graph end
test 3
Start 3: simpleTiff2psd-1-layer

3: Test command: /usr/bin/perl "/home/ametzler/PANO/libpano13-2.9.21/tests/panoAutomatePSDtest.pl" "simpleStitch_crop_1_layer.psd" "../simpleStitch/reference/tiff_m0000.tif"
3: Test timeout computed to be: 10000000
3: PTtiff2psd Version 2.9.21 , based on code by Helmut Dersch, rewritten by Daniel M German and Jim Watters
3:
3: Creating output file simpleStitch_crop_1_layer.psd
3: Converting TIFF to PSD 100%TIFFReadDirectory: Warning, Sum of Photometric type-related color channels and ExtraSamples doesn't match SamplesPerPixel. Defining non-color channels as ExtraSamples..
100%
3: Binary files reference/simpleStitch_crop_1_layer.psd and tests/simpleStitch_crop_1_layer.psd differ
1/6 Test #3: simpleTiff2psd-1-layer ..............***Failed 0.02 sec
test 4
Start 4: simpleTiff2psd-2-layers

4: Test command: /usr/bin/perl "/home/ametzler/PANO/libpano13-2.9.21/tests/panoAutomatePSDtest.pl" "simpleStitch_crop_2_layer.psd" "../simpleStitch/reference/tiff_m0000.tif" "../simpleStitch/reference/tiff_m0001.tif"
4: Test timeout computed to be: 10000000
4: PTtiff2psd Version 2.9.21 , based on code by Helmut Dersch, rewritten by Daniel M German and Jim Watters
4:
4: Creating output file simpleStitch_crop_2_layer.psd
4: Converting TIFF to PSD 100%
4: Binary files reference/simpleStitch_crop_2_layer.psd and tests/simpleStitch_crop_2_layer.psd differ
2/6 Test #4: simpleTiff2psd-2-layers .............***Failed 0.01 sec
test 5
Start 5: simpleTiff2psd-1-layer-uncropped

5: Test command: /usr/bin/perl "/home/ametzler/PANO/libpano13-2.9.21/tests/panoAutomatePSDtest.pl" "simpleStitch_uncrop_1_layer.psd" "../simpleStitch/reference/tiff_m_uncropped0000.tif"
5: Test timeout computed to be: 10000000
5: PTtiff2psd Version 2.9.21 , based on code by Helmut Dersch, rewritten by Daniel M German and Jim Watters
5:
5: Creating output file simpleStitch_uncrop_1_layer.psd
5: Converting TIFF to PSD 100%TIFFReadDirectory: Warning, Sum of Photometric type-related color channels and ExtraSamples doesn't match SamplesPerPixel. Defining non-color channels as ExtraSamples..
100%
5: Binary files reference/simpleStitch_uncrop_1_layer.psd and tests/simpleStitch_uncrop_1_layer.psd differ
3/6 Test #5: simpleTiff2psd-1-layer-uncropped ....***Failed 0.01 sec
test 6
Start 6: simpleTiff2psd-2-layers-uncropped

6: Test command: /usr/bin/perl "/home/ametzler/PANO/libpano13-2.9.21/tests/panoAutomatePSDtest.pl" "simpleStitch_uncrop_2_layer.psd" "../simpleStitch/reference/tiff_m_uncropped0000.tif" "../simpleStitch/reference/tiff_m_uncropped0001.tif"
6: Test timeout computed to be: 10000000
6: PTtiff2psd Version 2.9.21 , based on code by Helmut Dersch, rewritten by Daniel M German and Jim Watters
6:
6: Creating output file simpleStitch_uncrop_2_layer.psd
6: Converting TIFF to PSD 100%
6: Binary files reference/simpleStitch_uncrop_2_layer.psd and tests/simpleStitch_uncrop_2_layer.psd differ
4/6 Test #6: simpleTiff2psd-2-layers-uncropped ...***Failed 0.01 sec
test 7
Start 7: simpleTiff16-16bit-1-layer

7: Test command: /usr/bin/perl "/home/ametzler/PANO/libpano13-2.9.21/tests/panoAutomatePSDtest.pl" "simpleTiff16-16-_uncrop_1_layer.psd" "../simpleTiff16/reference/tiff_m0000.tif"
7: Test timeout computed to be: 10000000
7: PTtiff2psd Version 2.9.21 , based on code by Helmut Dersch, rewritten by Daniel M German and Jim Watters
7:
7: Creating output file simpleTiff16-16-_uncrop_1_layer.psd
7: Converting TIFF to PSD 100%TIFFReadDirectory: Warning, Sum of Photometric type-related color channels and ExtraSamples doesn't match SamplesPerPixel. Defining non-color channels as ExtraSamples..
100%
7: Binary files reference/simpleTiff16-16-_uncrop_1_layer.psd and tests/simpleTiff16-16-_uncrop_1_layer.psd differ
5/6 Test #7: simpleTiff16-16bit-1-layer ..........***Failed 0.01 sec
test 8
Start 8: simpleTiff16-16bit-2-layers

8: Test command: /usr/bin/perl "/home/ametzler/PANO/libpano13-2.9.21/tests/panoAutomatePSDtest.pl" "simpleTiff16-16-_uncrop_2_layer.psd" "../simpleTiff16/reference/tiff_m0000.tif" "../simpleTiff16/reference/tiff_m0000.tif"
8: Test timeout computed to be: 10000000
8: PTtiff2psd Version 2.9.21 , based on code by Helmut Dersch, rewritten by Daniel M German and Jim Watters
8:
8: Creating output file simpleTiff16-16-_uncrop_2_layer.psd
8: Converting TIFF to PSD 100%
8: Binary files reference/simpleTiff16-16-_uncrop_2_layer.psd and tests/simpleTiff16-16-_uncrop_2_layer.psd differ
6/6 Test #8: simpleTiff16-16bit-2-layers .........***Failed 0.01 sec

0% tests passed, 6 tests failed out of 6

Total Test time (real) = 0.09 sec

The following tests FAILED:
3 - simpleTiff2psd-1-layer (Failed)
4 - simpleTiff2psd-2-layers (Failed)
5 - simpleTiff2psd-1-layer-uncropped (Failed)
6 - simpleTiff2psd-2-layers-uncropped (Failed)
7 - simpleTiff16-16bit-1-layer (Failed)
8 - simpleTiff16-16bit-2-layers (Failed)
Errors while running CTest
Output from these tests are in: /home/ametzler/PANO/libpano13-2.9.21/obj/Testing/Temporary/LastTest.log
Use "--rerun-failed --output-on-failure" to re-run the failed cases verbosely.
------------

Filesize matches but the contents don't.
ametzler@argenau:/tmp/s390/libpano13-2.9.21/obj/tests/simpleTiff2psd$ ls -l ../../../obj/tests/simpleTiff2psd/reference/simpleStitch_crop_1_layer.psd ../../../obj/tests/simpleTiff2psd/tests/simpleStitch_crop_1_layer.psd
-rwxr-xr-x 1 ametzler ametzler 74984 1. Nov 13:39 ../../../obj/tests/simpleTiff2psd/reference/simpleStitch_crop_1_layer.psd
-rw-r--r-- 1 ametzler ametzler 74984 1. Nov 13:41 ../../../obj/tests/simpleTiff2psd/tests/simpleStitch_crop_1_layer.psd

cu Andreas
--
`What a good friend you are to him, Dr. Maturin. His other friends are
so grateful to you.'
`I sew his ears on from time to time, sure'

[T. Modes]

Andreas Metzler schrieb am Montag, 1. November 2021 um 13:47:18 UTC+1:

as a side effect of switching to cmake I have found that the PTtiff2psd
tests fail on s390x, hppa, powerpc ppc64 and sparc64. (This test was not
run in the autotools buildsystem)

 it seems to be an endianness problem. All affected architectures are big endian, but it's working on little endian systems, isn't it.

In panorama.h, line 47 it is commented out

//#define PT_BIGENDIAN                  1
Could you try to change this to

#define PT_BIGENDIAN                  1

(remove the comment ) and try again?

If this works we need to find a way to detect the endianness either in CMake or in C.

Thanks

Thomas

[T. Modes]

Okay, it was easier than thought. Attached the patch which should detect the endian for GNU C systems and set the preprocessor variable.

[Bruno Postle]

I applied the patch, and now run the test on build, and it seems to be ok with ppc64 and s390: https://copr.fedorainfracloud.org/coprs/bpostle/panorama/build/2917144/

[Gunter Königsmann]

https://cmake.org/cmake/help/v3.5/module/TestBigEndian.html

[Andreas Metzler]

On 2021-11-01 "T. Modes" <Thomas...@gmx.de> wrote:
> Okay, it was easier than thought. Attached the patch which should detect
> the endian for GNU C systems and set the preprocessor variable.

works foor me, thank you!

cu Andreas

[Bruno Postle]

On Tue, 2 Nov 2021 at 18:15, Andreas Metzler wrote:

>
> On 2021-11-01 "T. Modes" wrote:
> > Okay, it was easier than thought. Attached the patch which should detect
> > the endian for GNU C systems and set the preprocessor variable.
>
> works foor me, thank you!

Ok, I've committed the fix.

--
Bruno