SkyFill tutorials completed

[Jeff Welty]

https://github.com/weltyj/SkyFill

On the main branch of SkyFill, in the Tutorials subdirectory, look for tutorial_index.md

Also on the main branch, a couple of bug fixes.

Writing tutorials is difficult.  I'd be surprised if I didn't make it clear enough in places because I have such in depth knowledge of how it all works.  So, if you are using this and find any part confusing, or could be improved -- *please* let me know.

Enjoy!

Jeff

[Tobias]

Hi,

thanks for the nice tutorials. The sun mode is just wow. I'll have to play with SkyFill again. Have you thought about creating an interactive tool, or even better integret it into GIMP? Then I don't neet two tools for the post processing.

And I wounder if your tool would even work for not natrual skies like this one here:

https://dablogter.blogspot.com/2019/04/tutorial-dresden-1824-inside-image-from.html

Regards,

Tobias

[Jeff Welty]

Thanks Tobias,

I think SkyFill might work for the not natural skies example you posted.  There isn't a "blue" sky assumption.  What might make it difficult is if there is not enough HSV difference between the nearly constant color of the "sky", and how that changes to non sky.   It would also likely fail for non-normal skies that are in the red-range -- which is a hue value of 0, and SkyFill wouldn't be able to make a negative hue map correctly back to a value near 360.

Oh yes, I have thought an interactive tool would be very nice.   Probably not GIMP though -- the programming interface to get at image data is complicated and would require major rewrites of SkyFill.  (GIMP does it for good reason because of the way GIMP handles layers and data, so it has to manage large amounts of image data "nicely".)  Actually, a nice place would be in Hugin itself.  A tab that would be enabled after stitching... I could sure imagine a nice GUI to draw masks, vary parameters etc.  But I'm certainly not going to ask for that right now.

Cheers,

Jeff

[PanoSeek]

Hey Jeff!

This tool is what I have been searching for.  Unfortunately, I cannot make it compile on Windows 10.  I am 100% not a programmer, so that is probably part of it. 
I see in another thread - https://groups.google.com/g/hugin-ptx/c/mWPCrUoh6II/m/I9cvaunfCQAJ - T.Modes seems to have it working and I attempted to follow those steps and just cannot get it to compile.  I am guessing I am missing something obvious. 

Here is what I have done so far -

1. setup directories
2. git clone the repo to the local directory - git clone https://github.com/weltyj/SkyFill
3. Installed cmake 3.27.4
4. Installed tiff-3.8.2-1.exe to the same directory as the clone of the repo.
5. added a few lines to the cmakelists.txt file as I could not get the find package to work.
   

...

# find all required packages
# currently only libtiff is required
    set(TIFF_INCLUDE_DIR "C:/Users/Rod/SkyFill/TIFF")
    set(TIFF_LIBRARY "C:/Users/Rod/SkyFill/TIFF/lib/libtiff.lib")
FIND_PACKAGE(TIFF REQUIRED)
INCLUDE_DIRECTORIES(${TIFF_INCLUDE_DIR})
SET(NEEDED_LIBS ${TIFF_LIBRARIES})

...

6. ran cmake from the \build directory - cmake C:\Users\Rod\SkyFill\

7. Opened the solution in visual studio community 2022

8. tweaked the projects include locations because it was still not finding the TIFF files it needed.

9. Attempted Build and got 9 errors like this- Severity Code Description Project File Line Suppression State
Error LNK2019 unresolved external symbol __imp__TIFFmalloc referenced in function read_tif_image skyfill C:\Users\Rod\SkyFill\Build\skyfill_tif.obj 1

At this time, I have no idea why I cannot get it to compile.

So ask for ya - 

1. Any chance you (or T.Modes) can throw a release/compiled file up on your Github for Windows?

2. Any idea what I am doing wrong? 

Thank you!

[T. Modes]

PanoSeek schrieb am Dienstag, 5. September 2023 um 20:48:35 UTC+2:

Here is what I have done so far -

1. setup directories
2. git clone the repo to the local directory - git clone https://github.com/weltyj/SkyFill
3. Installed cmake 3.27.4
4. Installed tiff-3.8.2-1.exe to the same directory as the clone of the repo.

I don't know what this file is. But the libtiff library has to be compiled with the same compiler as the one you are using for skyfill.

Probably they don't match. (From the name libtiff could be from gcc and you are compiling skyfill with Visual Studio, just guessing.)

 

1. added a few lines to the cmakelists.txt file as I could not get the find package to work.

 

5. added a few lines to the makelists.txt file as I could not get the find package to work.

6. ran cmake from the \build directory - cmake C:\Users\Rod\SkyFill\

7. Opened the solution in visual studio community 2022

8. tweaked the projects include locations because it was still not finding the TIFF files it needed.

CMake does not work this way. You should not modify the CMakeLists.txt file. Instead enter the correct path in the CMake-GUI.

 

9. Attempted Build and got 9 errors like this- Severity Code Description Project File Line Suppression State
Error LNK2019 unresolved external symbol __imp__TIFFmalloc referenced in function read_tif_image skyfill C:\Users\Rod\SkyFill\Build\skyfill_tif.obj 1

At this time, I have no idea why I cannot get it to compile.

So above.

Also Hugin has the fill edges option to fill missing edges. Not sure if this would also work in your usecase.

Thomas

[Rod Bibeau]

Thank you! I will give this a try.

As for my use case, I am attempting to fill in the tops of images like
this - https://1drv.ms/f/s!Ah3sXKXawuGfgaQlgH14Q6u0SylHuw?e=Dia5XB
Specifically attempting to script a solution that I can use in an
automated manner due to the thousands of Panos' I have taken. Output
Pano image from my script - 100_0278.jpg and the same image from the
drone that does the stitching/fill automatically, but in poor quality
(and omits exif gps data) -
dji_fly_20230814_210712_278_1692061764447_pano_optimized.jpg

> --
> A list of frequently asked questions is available at: http://wiki.panotools.org/Hugin_FAQ
> ---
> You received this message because you are subscribed to the Google Groups "hugin and other free panoramic software" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to hugin-ptx+...@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/hugin-ptx/0fd605b3-c90e-402e-8ae0-5b4cdca32125n%40googlegroups.com.