Re: Remove dependence on gflags (issue 7628044)

[jcgre...@google.com]

Great, I fat-fingered the upload and overwrote it with httplib2 changes,
let me see if I can revert.

On 2013/03/26 17:30:26, jcgregorio_google wrote:
> I will update all the rest of the samples in another CL.

> I also took another pass at plus.py to simplify it further.


https://codereview.appspot.com/7628044/diff/12004/oauth2client/tools.py
> File oauth2client/tools.py (right):


https://codereview.appspot.com/7628044/diff/12004/oauth2client/tools.py#newcode45
> oauth2client/tools.py:45: To make this sample run you will need to
populate the
> client_secrets.json file
> On 2013/03/18 20:31:01, dhermes wrote:
> > AFAICT these indents were only there to line up with the return. You
should
> > dedent this line and the following ones by two spaces.

> Done.



https://codereview.appspot.com/7628044/

[Joe Gregorio]

OK, fixed.

-joe

[Danny Hermes]

Sorry, having a hard time figuring out what has changed since Patch Set 7 (the last time I looked AFAICT).

What's more, there seem to be a few patch sets in a permanently broken state:

https://codereview.appspot.com/7628044/diff2/51001:74002/Makefile

https://codereview.appspot.com/7628044/diff2/51001:74002/README

They both just say "Upload in progress."

--
Danny Hermes
Developer Programs Engineer

[Joe Gregorio]

Look at the diffs between 8 and 11. The only files to change are
plus.py and tools.py.

--
Joe Gregorio http://bitworking.org