Making indents consistent with PEP8. (issue 7314118)

[dhe...@google.com]

Reviewers: jcgregorio,

Description:
Making indents consistent with PEP8.

Please review this at http://codereview.appspot.com/7314118/

Affected files:
M python2/httplib2/__init__.py
M python2/httplib2/iri2uri.py
M python3/httplib2/__init__.py
M python3/httplib2/iri2uri.py

[dhe...@google.com]

setup.py, socks.py and the tests could also use some work, though I
didn't touch these.

Should I?

https://codereview.appspot.com/7314118/

[dhe...@google.com]

Also, pylint complained about some of the Python3 syntax, so my changes
there were done fully by hand.

https://codereview.appspot.com/7314118/

[Joe Gregorio]

One thing I've been pondering is can we use 3to2 and kill the Python
2.x version of the code?

--
Joe Gregorio http://bitworking.org

[Danny Hermes]

Not likely. None of the AppEngine specific parts are in the python3 package.

Though we could try to tear them out a a separate module in the python2 package.

--
Danny Hermes
Developer Programs Engineer

[joe.gr...@gmail.com]

On 2013/02/20 02:15:41, dhermes wrote:
> Not likely. None of the AppEngine specific parts are in the python3
package.

> Though we could try to tear them out a a separate module in the
python2
> package.

SGTM, but let's do that as a separate CL.

> On Tue, Feb 19, 2013 at 5:17 PM, Joe Gregorio
<mailto:j...@bitworking.org> wrote:

> > One thing I've been pondering is can we use 3to2 and kill the Python
> > 2.x version of the code?
> >
> > On Tue, Feb 19, 2013 at 6:25 PM, <mailto:dhe...@google.com> wrote:
> > > Also, pylint complained about some of the Python3 syntax, so my
changes
> > > there were done fully by hand.
> > >
> > > https://codereview.appspot.com/7314118/
> >
> >
> >
> > --
> > Joe Gregorio http://bitworking.org
> >



> --
> Danny Hermes
> Developer Programs Engineer

https://codereview.appspot.com/7314118/

[joe.gr...@gmail.com]

Just tried to apply the patch and it failed with:


applying issue7314118_1.diff
patching file python3/httplib2/iri2uri.py
Hunk #1 FAILED at 27
1 out of 1 hunks FAILED -- saving rejects to file
python3/httplib2/iri2uri.py.rej
patch failed, unable to continue (try -v)
patch failed, rejects left in working dir
errors during apply, please fix and refresh issue7314118_1.diff
jcgregorio@wpgntai-ubiq72:~/oldhome/projects/httplib2 on default?
[issue7314118_1.diff]
$

[dhe...@google.com]

I'm not sure I've ever gotten Rietveld to behave when it comes to
patches. I'll send it your way as a zip.

https://codereview.appspot.com/7314118/

[joe.gr...@gmail.com]

LGTM

Committed in
https://code.google.com/p/httplib2/source/detail?r=ca286f380ff89ef20029c5f6db95576ae8be1eed