Re: Making httplib2.Http instances pickleable. (issue 6506074)

[jcgre...@google.com]

Committed at
http://code.google.com/p/httplib2/source/detail?r=1f1f7d61957691b482eea7b5c193b0c9c8ae338d

On 2012/09/20 21:44:16, dhermes wrote:
> Does this work?


> On Tue, Sep 18, 2012 at 8:30 AM, Daniel Hermes
<mailto:dhe...@google.com> wrote:

> > I did sync to head. I am also getting failed hunks when I try to
apply to
> > a clean repo, but it is unclear why they are failing.
> >
> > The first hunk is an "import pickle" statement that falls in
alphabetical
> > order in python3/httplib2test.py and the second is just the tests I
added.
> >
> > I don't know enough about mercurial/rietveld to understand why this
is
> > failing. I manually applied the failed hunks and ran an "hg diff >
> > manual_apply.diff" and have attached that diff, which will
successfully
> > apply.
> >
> > Let me know if that works for you.
> >
> >
> > On Tue, Sep 18, 2012 at 7:04 AM, <mailto:jcgre...@google.com>
wrote:
> >
> >> Are you sure you are sync'd to head? I get failed hunks
> >> when I try to apply this.
> >>
> >>
> >> On 2012/09/18 14:00:33, jcgregorio_google wrote:
> >>
> >>> LGTM
> >>>
> >>
> >> Conditional on getting that next CL to fix up python3 :)
> >>>
> >>
> >> On 2012/09/17 17:48:19, dhermes wrote:
> >>> >
> >>>
> >> https://codereview.appspot.**com/6506074/diff/14002/**
> >>

python3/httplib2/__init__.py<https://codereview.appspot.com/6506074/diff/14002/python3/httplib2/__init__.py>
> >>
> >>> > File python3/httplib2/__init__.py (right):
> >>> >
> >>> >
> >>>
> >>
> >> https://codereview.appspot.**com/6506074/diff/14002/**
> >>

python3/httplib2/__init__.py#**newcode801<https://codereview.appspot.com/6506074/diff/14002/python3/httplib2/__init__.py#newcode801>
> >>
> >>> > python3/httplib2/__init__.py:**801: def __init__(self,
cache=None,
> >>>
> >> timeout=None,
> >>
> >>> > proxy_info=None,
> >>> > Joe,
> >>> >
> >>> > This never existed before. Can we add this in a subsequent
change?
> >>>
> >> The point
> >>
> >>> of
> >>> > this change was to make Http instances pickle-able.
> >>> >
> >>> > I'll be happy to start working on the next change right away.
> >>> >
> >>> > On 2012/09/17 17:46:22, jcgregorio_google wrote:
> >>> > > Looks like defaulting to proxyinfo from environment never made
it
> >>>
> >> into the
> >>
> >>> > code,
> >>> > > even though that's what the doc comments say. Can you update
the
> >>>
> >> proxy
> >>
> >>> > handling
> >>> > > for Python 3 be the same as Python 2?
> >>>
> >>
> >>
> >>
> >>

https://codereview.appspot.**com/6506074/%3Chttps://codereview.appspot.com/6506074/>
> >>
> >
> >
> >
> > --
> > Daniel Hermes
> > Developer Programs Engineer
> >



> --
> Daniel Hermes
> Developer Programs Engineer


https://codereview.appspot.com/6506074/