Identifying Disconnected Hooks on hook::disconnected

[Jeremy Martin]

For some of the stuff I'm working on (and it would seem in general), it would be handy to be able to identify which hook disconnected when reacting to a hook::disconnected event.

Currently the data associated with this event contains the name of the server hook, as well as the proposedRank.  If this idea seems sane, I would suggest that simply using the name of the disconnected hook instead of the server hook might make sense, but I'm not sure if and how the current value is used internally.  If that doesn't work, details about the disconnected hook could simply be stored in another property.

Thoughts?

[Marak Squires]

Seems you've got two different problems going on here. 

If you want to add more metadata to the disconnect event, try adding it here: https://github.com/hookio/hook.io/blob/master/lib/hookio/hook.js#L688

As for event names, there are many open discussions on this. 

--

-- 

Marak Squires

Co-founder and Chief Evangelist

Nodejitsu, Inc.

marak....@gmail.com

[Jeremy Martin]

Thanks. I'll submit a patch that adds a new property with details on the disconnected hook. I'm not sure what a good name for that is, so I'll just go with `disconnected` if that sounds ok.  Example usage would be:

someHook.on('*::hook::disconnected', function(data) {

    console.log(data.disconnected.name + ' is no longer connected');

});

[Jeremy Martin]

Submitted the pull request: https://github.com/hookio/hook.io/pull/193

[Jeremy Martin]

Thanks for the merge! Any chance of a version bump/npm publish in the near future?