RPM Changes (Fedora/EPEL)

10 views
Skip to first unread message

BJ Dierkes

unread,
Oct 20, 2010, 10:47:45 AM10/20/10
to hollan...@googlegroups.com
There are a few changes that I'd like to make in the Holland RPM spec to make it jive better with Fedora/EPEL policy:

* Move /etc/holland/README to %{_docdir}/README.configuration

* Move /etc/holland/examples to %{_docdir}/examples


Please let me know if you have any issues with that. Obviously it makes things easier to have the examples and README right there in /etc ... but by design, that stuff should all be in the standard docdir location.

---
derks

Tim Soderstrom

unread,
Oct 20, 2010, 10:53:14 AM10/20/10
to hollan...@googlegroups.com
Can we symlink /etc/holland/examples to %{_docdir}/examples?

> --
> WIKI: http://wiki.hollandbackup.org
> CODE: http://github.com/holland-backup
> UNSUBSCRIBE: holland-deve...@googlegroups.com
>

Andrew Garner

unread,
Oct 20, 2010, 11:07:29 AM10/20/10
to hollan...@googlegroups.com
I had initially tried this approach in an early 1.0 rpm. Replacing
directories (in old packages) with symlinks is messy in RPM, and doing
so is going to be a headache if we support upgrading older packages.

Honestly, I don't think it's that big of a deal. I'm perfectly fine
with examples/README only being in %{_docdir}.

I might note that we have a 'mk-config' command to generate a
configuration which covers most of the use cases for examples/. We
can certainly improve on that command, as needed.

~Andy

Tim Soderstrom

unread,
Oct 20, 2010, 1:13:48 PM10/20/10
to hollan...@googlegroups.com
mk-config still generates an odd mysql-lvm config but sure if we make this better I would not have as much of an issue. The examples are very well commented (something one might not always want when using mk-config). Perhaps we can add options to mk-config to suppress comments and things?

I dunno I still would like to see a symlink there but that above might make things easier for newbs.

BJ Dierkes

unread,
Oct 20, 2010, 2:02:25 PM10/20/10
to hollan...@googlegroups.com

On Oct 20, 2010, at 12:13 PM, Tim Soderstrom wrote:

> mk-config still generates an odd mysql-lvm config but sure if we make this better I would not have as much of an issue. The examples are very well commented (something one might not always want when using mk-config). Perhaps we can add options to mk-config to suppress comments and things?
>
> I dunno I still would like to see a symlink there but that above might make things easier for newbs.
>

Like Andy said, symlinks can make RPM upgrades explode... especially in config dirs (etc). I know its a lot easier to have examples and README right there... but it should also be pretty common knowledge to look in %{_docdir} for that stuff... and shouldn't really make exceptions just because people don't do it.

---
derks


Tim Soderstrom

unread,
Oct 20, 2010, 2:12:15 PM10/20/10
to hollan...@googlegroups.com


I mean I get what you're saying there but I think you're thinking as an idealist and even a bit arrogant there. If everyone had a clue, we wouldn't need documentation. So the fact that some Linux newb doesn't know about /usr/share/doc is not out fault. But I don't want to make it more difficult for that same user than it has to be.

I think if we add features to mk-config (specifically being able to include or prune out comments) then I'm happier anyway. I kinda find it a bit silly we can't put a README file there. Perhaps we can put 'example.conf' or put 'default.conf' into internal and external distributions of Holland? In there we could then make mention of where to find more example files. I'd be ok with that.


Andrew Garner

unread,
Oct 20, 2010, 2:38:47 PM10/20/10
to hollan...@googlegroups.com

If someone does not know about /usr/share/doc/, are you sure they'll
know about /etc/holland/ or (for that matter) what the implications of
even editing files in that directory might have? I think talking
about the "mythical newb" isn't particularly useful. :) There are a
reason there are packaging and filesystem standards exist and they are
not all idealist or "arrogant".

We can certainly cleanup mk-config to address various use cases. I
note we haven't had any bug reports (or comments that I'm aware of),
despite it seeming to have odd output for a long time now. I see that
the comment ordering is currently rather broken and pretty messy
(particularly with mysql-lvm). I see the issue, so I'll open a bug
and we'll address that along with --terse/--minimal output.

~Andy

Tim Soderstrom

unread,
Oct 20, 2010, 2:46:52 PM10/20/10
to hollan...@googlegroups.com

Lack of the bug report was my fault :) Though I know we talked about before early in the development of the LVM plugin so yeah I think this basically solves all problems and makes this particular issue case-closed (hence, go ahead and put the examples wherever the Fedora standard says to put them)

BJ Dierkes

unread,
Oct 20, 2010, 3:05:23 PM10/20/10
to hollan...@googlegroups.com

On Oct 20, 2010, at 1:38 PM, Andrew Garner wrote:
>
> If someone does not know about /usr/share/doc/, are you sure they'll
> know about /etc/holland/ or (for that matter) what the implications of
> even editing files in that directory might have? I think talking
> about the "mythical newb" isn't particularly useful. :) There are a
> reason there are packaging and filesystem standards exist and they are
> not all idealist or "arrogant".
>

I'd just like to take a moment of silence and acknowledge the fact that Andy and I are in full agreement on something. ;)

---
derks

Jason Kölker

unread,
Oct 20, 2010, 3:38:44 PM10/20/10
to hollan...@googlegroups.com
On Wed, 2010-10-20 at 13:12 -0500, Tim Soderstrom wrote:
> I kinda find it a bit silly we can't put a README file there. Perhaps
> we can put 'example.conf' or put 'default.conf' into internal and
> external distributions of Holland? In there we could then make mention
> of where to find more example files. I'd be ok with that.

Why not have rs-holland-config or whatever it is called put the docs
there?

I think we might be confusing the Rackspace specific, here it is let me
hold your hand, with the hey lets get this into EPEL stuff.

Happy Hacking!

7-11

--
A. Because it breaks the logical sequence of discussion
Q. Why is top posting bad?

Jason Kölker

unread,
Oct 20, 2010, 3:39:41 PM10/20/10
to hollan...@googlegroups.com
On Wed, 2010-10-20 at 14:05 -0500, BJ Dierkes wrote:
> I'd just like to take a moment of silence and acknowledge the fact that Andy and I are in full agreement on something. ;)

Group hug!

Mike Griffin

unread,
Oct 20, 2010, 6:09:31 PM10/20/10
to hollan...@googlegroups.com, BJ Dierkes
/me golfclaps

Confidentiality Notice: This e-mail message (including any attached or
embedded documents) is intended for the exclusive and confidential use of the
individual or entity to which this message is addressed, and unless otherwise
expressly indicated, is confidential and privileged information of Rackspace.
Any dissemination, distribution or copying of the enclosed material is prohibited.
If you receive this transmission in error, please notify us immediately by e-mail
at ab...@rackspace.com, and delete the original message.
Your cooperation is appreciated.

Reply all
Reply to author
Forward
0 new messages