Hobo::Model::Lifecycles::Transition #run is probably buggy

11 views
Skip to first unread message

Gert Thiel

unread,
Nov 19, 2012, 7:07:42 AM11/19/12
to hobo...@googlegroups.com
see https://gist.github.com/4110320 which includes my patch

Bryan Larsen

unread,
Nov 19, 2012, 11:28:30 AM11/19/12
to hobo...@googlegroups.com
Hmmm, that looks like fairly deliberate ordering. I imagine that Tom
placed the user_becomes logic before the permission check because the
use case he had in mind was the nobody -> somebody transition. In
that case it makes sense to run the permission check against the
somebody. OTOH, in the case of a Jack -> Jill transition, it
probably makes more sense to to the check against Jack.

Matt, do you have an opinion on this one?

Bryan



On Mon, Nov 19, 2012 at 7:07 AM, Gert Thiel <gert...@gmail.com> wrote:
> see https://gist.github.com/4110320 which includes my patch
>
> --
> You received this message because you are subscribed to the Google Groups
> "Hobo Users" group.
> To view this discussion on the web visit
> https://groups.google.com/d/msg/hobousers/-/Lf9s66uRQJQJ.
> To post to this group, send email to hobo...@googlegroups.com.
> To unsubscribe from this group, send email to
> hobousers+...@googlegroups.com.
> For more options, visit this group at
> http://groups.google.com/group/hobousers?hl=en.
Reply all
Reply to author
Forward
0 new messages