hledger-web: how to show running total on filtered chart

[shaun smiley]

I'm just diving into hledger.  I have converted several years worth from kmymoney successfully. 

In hledger-web it shows a nice chart to the top right.  The values looks good until I select a subset to zoom in (i.e. filter).  Then the running total starts at the start of the filtered dates, which means it's no longer a running total. 

How can I get this to show a true running total?  

I have used --historical in hledger for a few balance reports, but hledger-web doesn't accept --historical. 

[Simon Michael]

Welcome Shaun. Sorry you hit it, but that seems a fairly blatant hledger-web bug! The register and chart should probably always be in historical mode, like hledger-ui's.

--

You received this message because you are subscribed to the Google Groups "hledger" group.

To unsubscribe from this group and stop receiving emails from it, send an email to hledger+u...@googlegroups.com.

To view this discussion on the web visit https://groups.google.com/d/msgid/hledger/117e3009-ab2d-4c27-84b7-bbe991def585n%40googlegroups.com.

[shaun]

Thanks for confirming.  This may be a reason to up my haskell game and figure out the code base!

--

Shaun

You received this message because you are subscribed to a topic in the Google Groups "hledger" group.
To unsubscribe from this topic, visit https://groups.google.com/d/topic/hledger/jSAYYL6ujGQ/unsubscribe.
To unsubscribe from this group and all its topics, send an email to hledger+u...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/hledger/22c36618-f93e-4e56-9a52-601245407581%40app.fastmail.com.

[Simon Michael]

Sounds good! Happy to support in the hledger chat.

To view this discussion on the web visit https://groups.google.com/d/msgid/hledger/CAMQv9hBTmoVPiaR%2BtjbYLDfjHVaBp60FfWaBFJcBkjdw2coAYg%40mail.gmail.com.

[shaun]

I finally got around to doing this, although I'm still a baby haskeller.  

I did use A.I. (Gemini 3.6 flash) to work out the solution.  

I tested it locally by building the hledger-web and confirmed that it implemented the equivalent of adding --historical. 

I went to open a PR and read the policy #4: 

> 4. First-time hledger contributors must not use AI to generate PRs.
>    New-contributor PRs that seem AI-generated will be closed.

So I stopped and did not submit the PR.  

The fix was very small, 1 change and 2 additions: 

https://github.com/senorsmile/hledger/commit/dccdf4477315810376e089ebb1a00882122f6c6e

--

Shaun

To view this discussion on the web visit https://groups.google.com/d/msgid/hledger/5afb957e-3242-4d71-9184-66b4185bf5ff%40app.fastmail.com.

[Simon Michael]

Thanks for respecting the policy Shaun.  If you'd like, do some other small PR manually, then you could submit this one and get the credit. Otherwise, I'll apply the fix in a while. Thanks!

To view this discussion visit https://groups.google.com/d/msgid/hledger/CAMQv9hAh%2BbrthjPjsfDDzvfLco_pweOOoL7aTespYJO_QUVS%2Bg%40mail.gmail.com.

[shaun]

I tested it a bit more and realized that my first patch applies historical in all contexts, which is actually not always desirable.  I am working on a way to toggle it on or off.  I have that working by manually appending `&hist=1` to the URL, but not with any sort of UI option yet.  Once I have it working I'll push to my fork.  

> If you'd like, do some other small PR manually

Sure, I'll take a look around on the Github issues for something else I could contribute to and fix it up, then come back to opening a PR afterwards. 

--

Shaun

To view this discussion visit https://groups.google.com/d/msgid/hledger/0ed79e69-5ddf-4f32-b59e-e219836cc856%40app.fastmail.com.