Use --pretty-tables (require non-ascii line characters) by default ?

5 views
Skip to first unread message

Simon Michael

unread,
Sep 20, 2021, 2:52:30 PMSep 20
to hledger
It was suggested in chat yesterday that we should step into the modern age and make --pretty-tables the default, using non-ascii line characters for tabular reports in the terminal.

https://github.com/simonmichael/hledger/pull/1705 makes this change, adding a general --pretty=yes/no flag, and a NO_PRETTY environment variable that can be used to change the default to off.

What are your thoughts ? Please let us know if you can see this causing significant problems.

My biggest concern is if you run hledger in a terminal environment/font where the standard unicode box drawing characters aren't available, you would see junk characters, which is a bad impression.

It will also create a giant diff for everyone who version-controls their report outputs.

Jonathan Jouty

unread,
Sep 20, 2021, 5:53:14 PMSep 20
to hle...@googlegroups.com
Personally, it sounds like a good move.

Minor feedback to alleviate the giant diff concerns:
- with git you can use --word-diff for a cleaner view
- giant diffs happen anyway in reports with account name changes (or new longer ones), unless you have a max-width naming in place (or some truncation option)

--
You received this message because you are subscribed to the Google Groups "hledger" group.
To unsubscribe from this group and stop receiving emails from it, send an email to hledger+u...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/hledger/433DB484-8EB7-4E23-B8BD-605B1790142D%40joyful.com.
Reply all
Reply to author
Forward
0 new messages