Bunch of updates in SVN - testers please!

1 view
Skip to first unread message

Drew McLellan

unread,
Apr 21, 2008, 1:00:45 PM4/21/08
to hkit-discuss
Hi everyone,

I've committed a bunch of changes into the trunk today, including some
community contributions. Important changes now are:

* Will now always return an array of results, even if only one result
is found. Previously if there was only a single result, everything was
shifted up the structure one step. $results[0] will always be the
first result, even if there's only one. Thanks to Ueli Weiss for the
patch.

* Fixed some whitespace handling stuff that was letting double-
whitespace through.

* Finally address the long-standing issue where Tidy would wrap long
lines and trim whitespace, resulting in words being joined when hkit
then removed the line breaks. Ueli voiced an additional vote for the
suggested "just add a space, idiot!" approach, so I just went with
it.

* Addressed a really tricky problem where getting the node text of a
value like 'note' was resulting in broken and duplicated text. This is
because the code was getting the text for the node (including
descendants) and then again for each descendant in turn. The results
were a mess. I've replaced this with a change that seems way too
simple and I'm worried it won't work. I'm now getting the XML output
of the node and stripping tags to get the text. From my tests it
works, but I could really used some extra tests on this.
Resolves http://code.google.com/p/hkit/issues/detail?id=1

* Made some changes to the hkit profile and the way unicode is handled
in the implied n optimisation. It was failing to match the 'Surname
Initial.' pattern when the initial was a non-ascii character. Should
be ok now.

If all this seems to work for people, I'm tempted to tag this as hkit
0.6 and push a release. Please let me know how you get along with it.

(wiki will be updated once it comes out of maintenance mode)

Thanks

drew mclellan.

Drew McLellan

unread,
May 31, 2008, 5:04:17 PM5/31/08
to hkit-discuss
Has anyone had a chance to try this out? I'd like to make a 0.6
release soon.

Drew.


On 21 Apr, 18:00, Drew McLellan <drew.mclel...@gmail.com> wrote:
> Hi everyone,
>
> I've committed a bunch of changes into the trunk today, including some
> community contributions. Important changes now are:
>
> * Will now always return an array of results, even if only one result
> is found. Previously if there was only a single result, everything was
> shifted up the structure one step. $results[0] will always be the
> first result, even if there's only one. Thanks to Ueli Weiss for the
> patch.
>
> * Fixed some whitespace handling stuff that was letting double-
> whitespace through.
>
> * Finally address the long-standing issue where Tidy would wrap long
> lines and trim whitespace, resulting in words being joined when hkit
> then removed the line breaks. Ueli voiced an additional vote for the
> suggested "just add a space, idiot!" approach, so I just went with
> it.
>
> * Addressed a really tricky problem where getting the node text of a
> value like 'note' was resulting in broken and duplicated text. This is
> because the code was getting the text for the node (including
> descendants) and then again for each descendant in turn. The results
> were a mess. I've replaced this with a change that seems way too
> simple and I'm worried it won't work. I'm now getting the XML output
> of the node and stripping tags to get the text. From my tests it
> works, but I could really used some extra tests on this.
> Resolveshttp://code.google.com/p/hkit/issues/detail?id=1

Pfefferle

unread,
Jun 1, 2008, 6:05:17 AM6/1/08
to hkit-discuss
Thanks Drew, I will try the new version with all of my WordPress
Plugins this evening.
Reply all
Reply to author
Forward
0 new messages